Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blog #233

Merged
merged 6 commits into from
Nov 6, 2024
Merged

Add blog #233

merged 6 commits into from
Nov 6, 2024

Conversation

vladh
Copy link
Member

@vladh vladh commented Oct 31, 2024

Closes #228

Screen Shot 2024-10-31 at 20 01 09

Screen Shot 2024-10-31 at 20 01 13

Screen Shot 2024-10-31 at 20 01 18

Screen Shot 2024-10-31 at 20 01 22

@selviano
Copy link
Collaborator

selviano commented Nov 6, 2024

hey @vladh this looks great. Is this a mockup or is this ready to ship? Curious what CMS you used to make it? We are going to onboard Sanity soon so it would be cool to use their headless CMS if it makes sense

@vladh
Copy link
Member Author

vladh commented Nov 6, 2024

Hey @selviano! This is ready to ship. I used some Astro features to set up a system where we can easily author Markdown articles (same flavour of Markdown as these GitHub comments etc).

Here's an example of what that looks like: https://github.com/opensourcepledge/opensourcepledge.com/blob/vladh/create-blog/src/content/articles/join-the-pledge.md?plain=1

From my perspective, this meets our current needs, but if you'd like to have Sanity implemented, I can absolutely do that.

@selviano
Copy link
Collaborator

selviano commented Nov 6, 2024

@vladh I think at some point we will want a full-fledged CMS, but I don't know that we need it now. WRT Sanity, I know lots of people who love it, but that doesn't necessarily mean it's the best for our use case. So I'll defer to you on that. I just think that all things being equal, we should use Pledge members' tech wherever we can.

@chadwhitacre
Copy link
Contributor

@vladh Worth standardizing w/ the quote and date format from the press page?

@vladh
Copy link
Member Author

vladh commented Nov 6, 2024

@vladh I think at some point we will want a full-fledged CMS, but I don't know that we need it now. WRT Sanity, I know lots of people who love it, but that doesn't necessarily mean it's the best for our use case. So I'll defer to you on that. I just think that all things being equal, we should use Pledge members' tech wherever we can.

Gotcha! We can use the Astro solution for now, then switch to Sanity when required.

@vladh
Copy link
Member Author

vladh commented Nov 6, 2024

@vladh Worth standardizing w/ the quote and date format from the press page?

Good point, on it!

@vladh vladh force-pushed the vladh/create-blog branch from 0e9fef4 to 5b06404 Compare November 6, 2024 20:31
@vladh
Copy link
Member Author

vladh commented Nov 6, 2024

@chadwhitacre Done!

2024-11-06-20-43-42

2024-11-06-20-44-36

@chadwhitacre
Copy link
Contributor

Can we be consistent with nomenclature? Looking at blog vs. articles in URL and h1, I think blog is the more standard in our case.

image

@chadwhitacre
Copy link
Contributor

Ooh! I like the usage in blockquotes. I was thinking of the listing page, though. Shouldn't press and blog have consistent design?

@vladh
Copy link
Member Author

vladh commented Nov 6, 2024

Can we be consistent with nomenclature? Looking at blog vs. articles in URL and h1, I think blog is the more standard in our case.

Done!

Ooh! I like the usage in blockquotes. I was thinking of the listing page, though. Shouldn't press and blog have consistent design?

Right, of course. Done!

2024-11-06-21-01-34

@chadwhitacre chadwhitacre merged commit 2b6306b into main Nov 6, 2024
3 checks passed
@chadwhitacre chadwhitacre deleted the vladh/create-blog branch November 6, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider starting a blog
3 participants