Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ARM images #54877

Merged
merged 1 commit into from
Aug 8, 2024
Merged

fix: ARM images #54877

merged 1 commit into from
Aug 8, 2024

Conversation

mateusoliveira43
Copy link
Contributor

@mateusoliveira43 mateusoliveira43 commented Jul 26, 2024 •
edited
Loading

Create both AMD and ARM images in images jobs

@mateusoliveira43

This comment was marked as outdated.

Sign in to view
@openshift-ci openshift-ci bot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 26, 2024
@openshift-ci openshift-ci bot requested review from mrnold and sseago July 26, 2024 15:19
@mateusoliveira43
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-oadp-operator-master-images

@openshift-ci-robot
Copy link
Contributor

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mateusoliveira43
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-oadp-operator-master-images

@openshift-ci-robot
Copy link
Contributor

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mateusoliveira43
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-oadp-operator-master-images pull-ci-openshift-oadp-operator-master-unit-test-arm pull-ci-openshift-oadp-operator-master-unit-test

@openshift-ci-robot
Copy link
Contributor

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mateusoliveira43
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-oadp-operator-master-images pull-ci-openshift-oadp-operator-oadp-1.4-images

@openshift-ci-robot
Copy link
Contributor

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mateusoliveira43 mateusoliveira43 mentioned this pull request Jul 26, 2024
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2024
@openshift-ci openshift-ci bot removed the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2024
@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 29, 2024
This was referenced Jul 29, 2024
Merged
Merged
Merged
Merged
Merged
@openshift-merge-robot openshift-merge-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2024
@openshift-ci-robot
Copy link
Contributor

@mateusoliveira43, pj-rehearse: unable to determine affected jobs. This could be due to a branch that needs to be rebased. ERROR:

couldn't prepare candidate: couldn't rebase candidate onto master: %!w(<nil>)
Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@openshift-merge-robot openshift-merge-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Aug 5, 2024
@mateusoliveira43
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-oadp-operator-master-images pull-ci-openshift-oadp-operator-oadp-1.4-images pull-ci-openshift-velero-plugin-for-aws-konveyor-dev-images pull-ci-openshift-velero-plugin-for-aws-oadp-1.4-images pull-ci-openshift-velero-konveyor-dev-images pull-ci-openshift-velero-oadp-1.4-images

@openshift-ci-robot
Copy link
Contributor

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot
Copy link
Contributor

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mateusoliveira43
fix: ARM images
6c70c9e 
Signed-off-by: Mateus Oliveira <[email protected]>
@openshift-ci-robot
Copy link
Contributor

[REHEARSALNOTIFIER]
@mateusoliveira43: the pj-rehearse plugin accommodates running rehearsal tests for the changes in this PR. Expand 'Interacting with pj-rehearse' for usage details. The following rehearsable tests have been affected by this change:

Test name Repo Type Reason
pull-ci-openshift-velero-plugin-for-gcp-konveyor-dev-images openshift/velero-plugin-for-gcp presubmit Presubmit changed
pull-ci-openshift-velero-plugin-for-gcp-oadp-1.0-images openshift/velero-plugin-for-gcp presubmit Presubmit changed
pull-ci-openshift-velero-plugin-for-gcp-oadp-1.3-images openshift/velero-plugin-for-gcp presubmit Presubmit changed
pull-ci-openshift-velero-plugin-for-gcp-oadp-1.4-images openshift/velero-plugin-for-gcp presubmit Presubmit changed
pull-ci-openshift-velero-plugin-for-gcp-oadp-1.3-unit-test openshift/velero-plugin-for-gcp presubmit Ci-operator config changed
pull-ci-openshift-velero-plugin-for-gcp-konveyor-dev-unit-test openshift/velero-plugin-for-gcp presubmit Ci-operator config changed
pull-ci-openshift-velero-plugin-for-gcp-oadp-1.4-unit-test openshift/velero-plugin-for-gcp presubmit Ci-operator config changed
pull-ci-openshift-velero-plugin-for-gcp-oadp-1.0-unit-test openshift/velero-plugin-for-gcp presubmit Ci-operator config changed
pull-ci-openshift-velero-konveyor-dev-images openshift/velero presubmit Presubmit changed
pull-ci-openshift-velero-oadp-1.0-images openshift/velero presubmit Presubmit changed
pull-ci-openshift-velero-oadp-1.3-images openshift/velero presubmit Presubmit changed
pull-ci-openshift-velero-oadp-1.4-images openshift/velero presubmit Presubmit changed
pull-ci-openshift-velero-oadp-1.3-unit-test openshift/velero presubmit Ci-operator config changed
pull-ci-openshift-velero-oadp-1.4-unit-test openshift/velero presubmit Ci-operator config changed
pull-ci-openshift-velero-oadp-1.0-unit-test openshift/velero presubmit Ci-operator config changed
pull-ci-openshift-velero-konveyor-dev-unit-test openshift/velero presubmit Ci-operator config changed
pull-ci-openshift-oadp-operator-master-images openshift/oadp-operator presubmit Presubmit changed
pull-ci-openshift-oadp-operator-oadp-1.0-images openshift/oadp-operator presubmit Presubmit changed
pull-ci-openshift-oadp-operator-oadp-1.3-images openshift/oadp-operator presubmit Presubmit changed
pull-ci-openshift-oadp-operator-oadp-1.4-images openshift/oadp-operator presubmit Presubmit changed
pull-ci-openshift-oadp-operator-oadp-1.0-4.12-ci-index openshift/oadp-operator presubmit Ci-operator config changed
pull-ci-openshift-oadp-operator-oadp-1.0-4.12-e2e-test-aws openshift/oadp-operator presubmit Ci-operator config changed
pull-ci-openshift-oadp-operator-oadp-1.0-4.12-images openshift/oadp-operator presubmit Ci-operator config changed
pull-ci-openshift-oadp-operator-oadp-1.0-4.14-ci-index openshift/oadp-operator presubmit Ci-operator config changed
pull-ci-openshift-oadp-operator-oadp-1.0-4.14-e2e-test-aws openshift/oadp-operator presubmit Ci-operator config changed

A total of 106 jobs have been affected by this change. The above listing is non-exhaustive and limited to 25 jobs.

A full list of affected jobs can be found here

Interacting with pj-rehearse

Comment: /pj-rehearse to run up to 5 rehearsals
Comment: /pj-rehearse skip to opt-out of rehearsals
Comment: /pj-rehearse {test-name}, with each test separated by a space, to run one or more specific rehearsals
Comment: /pj-rehearse more to run up to 10 rehearsals
Comment: /pj-rehearse max to run up to 25 rehearsals
Comment: /pj-rehearse auto-ack to run up to 5 rehearsals, and add the rehearsals-ack label on success
Comment: /pj-rehearse abort to abort all active rehearsals

Once you are satisfied with the results of the rehearsals, comment: /pj-rehearse ack to unblock merge. When the rehearsals-ack label is present on your PR, merge will no longer be blocked by rehearsals.
If you would like the rehearsals-ack label removed, comment: /pj-rehearse reject to re-block merging.

@mateusoliveira43
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-oadp-operator-master-images pull-ci-openshift-oadp-operator-oadp-1.4-images pull-ci-openshift-velero-plugin-for-aws-konveyor-dev-images pull-ci-openshift-velero-plugin-for-aws-oadp-1.4-images pull-ci-openshift-velero-konveyor-dev-images pull-ci-openshift-velero-oadp-1.4-images

@openshift-ci-robot
Copy link
Contributor

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mateusoliveira43
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-velero-plugin-for-gcp-konveyor-dev-unit-test pull-ci-openshift-velero-plugin-for-gcp-oadp-1.4-unit-test pull-ci-openshift-velero-konveyor-dev-unit-test pull-ci-openshift-velero-oadp-1.4-unit-test pull-ci-openshift-oadp-operator-master-unit-test pull-ci-openshift-oadp-operator-oadp-1.4-unit-test pull-ci-openshift-velero-plugin-for-aws-konveyor-dev-unit-test pull-ci-openshift-velero-plugin-for-aws-oadp-1.4-unit-test pull-ci-openshift-velero-plugin-for-microsoft-azure-konveyor-dev-unit-test pull-ci-openshift-velero-plugin-for-microsoft-azure-oadp-1.4-unit-test pull-ci-openshift-openshift-velero-plugin-master-unit-test pull-ci-openshift-openshift-velero-plugin-oadp-1.4-unit-test

@openshift-ci-robot
Copy link
Contributor

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mateusoliveira43
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-oadp-operator-oadp-1.4-4.16-e2e-test-aws pull-ci-openshift-oadp-operator-oadp-1.4-4.16-e2e-test-kubevirt-aws

@openshift-ci-robot
Copy link
Contributor

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mateusoliveira43
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-velero-plugin-for-gcp-konveyor-dev-unit-test pull-ci-openshift-velero-plugin-for-gcp-oadp-1.4-unit-test pull-ci-openshift-velero-konveyor-dev-unit-test pull-ci-openshift-velero-oadp-1.4-unit-test pull-ci-openshift-velero-plugin-for-aws-konveyor-dev-unit-test pull-ci-openshift-velero-plugin-for-aws-oadp-1.4-unit-test pull-ci-openshift-velero-plugin-for-microsoft-azure-konveyor-dev-unit-test pull-ci-openshift-velero-plugin-for-microsoft-azure-oadp-1.4-unit-test

@openshift-ci-robot
Copy link
Contributor

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mateusoliveira43
Copy link
Contributor Author

/pj-rehearse pull-ci-openshift-velero-plugin-for-gcp-konveyor-dev-unit-test pull-ci-openshift-velero-plugin-for-gcp-oadp-1.4-unit-test pull-ci-openshift-velero-konveyor-dev-unit-test pull-ci-openshift-velero-oadp-1.4-unit-test pull-ci-openshift-velero-plugin-for-aws-konveyor-dev-unit-test pull-ci-openshift-velero-plugin-for-aws-oadp-1.4-unit-test pull-ci-openshift-velero-plugin-for-microsoft-azure-konveyor-dev-unit-test pull-ci-openshift-velero-plugin-for-microsoft-azure-oadp-1.4-unit-test

@openshift-ci-robot
Copy link
Contributor

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@mateusoliveira43
Copy link
Contributor Author

/unhold
/pj-rehearse ack

@openshift-ci-robot
Copy link
Contributor

@mateusoliveira43: now processing your pj-rehearse request. Please allow up to 10 minutes for jobs to trigger or cancel.

@openshift-ci-robot openshift-ci-robot added the rehearsals-ack Signifies that rehearsal jobs have been acknowledged label Aug 8, 2024
@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Aug 8, 2024
@sseago
Copy link
Contributor

sseago commented Aug 8, 2024

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 8, 2024
@kaovilai
Copy link
Member

kaovilai commented Aug 8, 2024

/approve /lgtm

@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 8, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mateusoliveira43, sseago

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 8, 2024
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 8, 2024

@mateusoliveira43: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 8fa2705 into openshift:master Aug 8, 2024
37 checks passed
@openshift-ci OpenShift CI
Copy link
Contributor

openshift-ci bot commented Aug 8, 2024

@mateusoliveira43: Updated the image-mirror-mappings configmap in namespace ci at cluster app.ci using the following files:

  • key mapping_konveyor_latest using file core-services/image-mirroring/konveyor/mapping_konveyor_latest

In response to this:

Create both AMD and ARM images in images jobs

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@droslean droslean droslean left review comments

@kaovilai kaovilai kaovilai approved these changes

@sseago sseago sseago approved these changes

@mrnold mrnold Awaiting requested review from mrnold

Assignees

@sseago sseago

@kaovilai kaovilai

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. rehearsals-ack Signifies that rehearsal jobs have been acknowledged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@mateusoliveira43 @openshift-ci-robot @sseago @kaovilai @droslean @openshift-merge-robot