fix: ARM images

[mateusoliveira43]

Add ARM images to PROW CI

Example image: https://quay.io/repository/msouzaol/velero

Related to openshift/release#54877

How to build

docker build -t <TAG> -f Dockerfile.ubi . --platform=linux/arm64

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[openshift-ci]

@mateusoliveira43: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[kaovilai]

Suggested change

	FROM quay.io/konveyor/builder:ubi9-latest AS builder
	FROM --platform=$BUILDPLATFORM quay.io/konveyor/builder:ubi9-latest AS builder
	ARG BUILDPLATFORM

Since we are optimizing, and golang can cross compile binary, and this is not the final stage, we can set BUILDPLATFORM to get more optimum performance.

ref: cross-compilation

[mateusoliveira43]

but this would make only multi platform builds faster, not?

since multi platform builds are CI responsibility (and I do not know how PROW does it), I think we do not need this

[kaovilai]

right do not need. but doesn't hurt to add for local dev builds either when building for dev/customers who are on arch other than the dev machine.

[kaovilai]

im on arm, so this would speed up builds of amd64 images to use on amd64 cluster.

[kaovilai]

This would make single platform build faster if the OS building (ie. laptop is arm64) is different than intended image platform (for amd64 cluster)

[kaovilai]

Suggested change

	FROM quay.io/konveyor/builder:ubi9-latest AS builder
	FROM --platform=$BUILDPLATFORM quay.io/konveyor/builder:ubi9-latest AS builder
	ARG BUILDPLATFORM

[kaovilai]

Suggested change

	FROM quay.io/konveyor/builder:ubi9-latest AS restic-builder
	FROM --platform=$BUILDPLATFORM quay.io/konveyor/builder:ubi9-latest AS restic-builder
	ARG BUILDPLATFORM

[weshayutin]

/LGTM

[mateusoliveira43]

/cherry-pick oadp-1.4

[openshift-cherrypick-robot]

@mateusoliveira43: once the present PR merges, I will cherry-pick it on top of oadp-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick oadp-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kaovilai, mateusoliveira43, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• DOWNSTREAM_OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-cherrypick-robot]

@mateusoliveira43: #332 failed to apply on top of branch "oadp-1.4":

Applying: fix: ARM images
Using index info to reconstruct a base tree...
M	Dockerfile.ubi
Falling back to patching base and 3-way merge...
Auto-merging Dockerfile.ubi
CONFLICT (content): Merge conflict in Dockerfile.ubi
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 fix: ARM images
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick oadp-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.