Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ARM images #55

Merged

Conversation

mateusoliveira43
Copy link

@mateusoliveira43 mateusoliveira43 commented Jul 29, 2024

Add ARM images to PROW CI

Example image: https://quay.io/repository/msouzaol/velero-plugin-for-aws

Related to openshift/release#54877

How to build

docker build -t <TAG> -f Dockerfile.ubi . --platform=linux/arm64

Signed-off-by: Mateus Oliveira <[email protected]>
@openshift-ci openshift-ci bot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Jul 29, 2024
Copy link

openshift-ci bot commented Jul 29, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@mateusoliveira43 mateusoliveira43 marked this pull request as ready for review August 5, 2024 16:08
@openshift-ci openshift-ci bot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 5, 2024
Copy link

openshift-ci bot commented Aug 5, 2024

@mateusoliveira43: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Copy link

@weshayutin weshayutin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/LGTM

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Aug 6, 2024
@mateusoliveira43
Copy link
Author

/cherry-pick oadp-1.4

@openshift-cherrypick-robot

@mateusoliveira43: once the present PR merges, I will cherry-pick it on top of oadp-1.4 in a new PR and assign it to you.

In response to this:

/cherry-pick oadp-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kaovilai kaovilai added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 6, 2024
Copy link

openshift-ci bot commented Aug 6, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kaovilai, mateusoliveira43, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit bf0f1ef into openshift:konveyor-dev Aug 6, 2024
3 checks passed
@openshift-cherrypick-robot

@mateusoliveira43: new pull request created: #56

In response to this:

/cherry-pick oadp-1.4

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

shubham-pampattiwar pushed a commit to shubham-pampattiwar/velero-plugin-for-aws that referenced this pull request Aug 22, 2024
Signed-off-by: Mateus Oliveira <[email protected]>
sseago pushed a commit to sseago/velero-plugin-for-aws that referenced this pull request Dec 11, 2024
Signed-off-by: Mateus Oliveira <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants