OADP-2959: Add missing descriptions to all CRDs

[mpryc]

Adds missing descriptions to the following CRDs:

 - DataDownload
 - DataUpload
 - VolumeSnapshotBackup
 - VolumeSnapshotRestore
 - CloudStorage

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[mpryc]

/jira refresh

[openshift-ci-robot]

@mpryc: No Jira issue is referenced in the title of this pull request.
To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[openshift-ci-robot]

@mpryc: This pull request references OADP-2959 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target either version "4.15." or "openshift-4.15.", but it targets "OADP 1.3.0" instead.

In response to this:

Adds missing descriptions to the following CRDs:

- DataDownload
- DataUpload
- VolumeSnapshotBackup
- VolumeSnapshotRestore
- CloudStorage

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mateusoliveira43]

VSB and VSR do not exist in master anymore, this can be applied to others branch

[mateusoliveira43]

Lets wait for rebase to get @shubham-pampattiwar PR for descriptions of DU and DD CRDs?

[shubham-pampattiwar]

yeah @mateusoliveira43 I can do a cherry-pick against openshift/velero if needed, upstream PR is merged @mpryc

[sseago]

We won't be doing any more rebases to konveyor-dev until we've created oadp-1.3 branches, since we're already on the upstream release we're shipping for 1.3 -- any upstream commits needed for 1.3 will need to be cherry-picked via PR.

[shubham-pampattiwar]

ok ok, I will create a cherry-pick PR

[mpryc]

So there won't be any rebase meaning this PR is ok'ish and should be valid for the master. If there is any update removal of description needed following this patch it should be removed with PR. Am I understanding this correctly?

[shubham-pampattiwar]

I would remove changes related to DUCR and DDCR from this PR. As they will be automatically picked up once the Velero CRDs are updated.

[mpryc]

Will they? This is the bases manifest for the top level CSV so I don't think we have any automagic which is updating this file?

[mpryc]

I mean it's not the config/crd/bases/*.yaml it's the config/manifests/bases/*.yaml. The first one is for the description in the config object and those are automatically picked from the CRDs, however the second one living n the config/manifests/bases/*.yaml applies to our top level operator and as such it's not automatically synced from any other resources.

[kaovilai]

As they will be automatically picked up once the Velero CRDs are updated.

The description wouldn't be picked up automatically.

The operator-sdk bundle generation only automate Name, Version, Kind into bundle/CSV.

	for _, defKey := range defKeys {
		if owned, ownedExists := descMap[defKey]; ownedExists {
			ownedDescs = append(ownedDescs, owned)
		} else {
			ownedDescs = append(ownedDescs, operatorsv1alpha1.CRDDescription{
				Name:    defKey.Name,
				Version: defKey.Version,
				Kind:    defKey.Kind,
			})
		}
	}

https://redhat-internal.slack.com/archives/C0144ECKUJ0/p1698773258374849

Still have to put in description manually and phase/specDescriptors if desired.

[mpryc]

/retest

[shubham-pampattiwar]

Please add the descriptions that got merged upstream: https://github.com/vmware-tanzu/velero/pull/7028/files

[mpryc]

Changed.

[openshift-ci]

@mpryc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[weshayutin]

Definitions are present, and look right to me.

[kaovilai]

#1200 (comment)

[kaovilai]

Sounds like we're ok adding ignored descriptions because it's easier in the moment. Follow up to remove perhaps.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mpryc, sseago, weshayutin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [kaovilai,sseago]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[kaovilai]

/lgtm

[mpryc]

VSB and VSR need to be removed from the master branch. They are unnecessary in OADP 1.3+, but they also don't pose any harm. In the absence of the VSB and VSR in the CRD's / OCP APIs, the description will not be displayed, so adding extra description won't create any issues. For OADP 1.2, this will be a straightforward backport from the master branch because it contains VSB and VSR, which are required in OADP 1.2.