Add description markers for dataupload and datadownload CRDs #7028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Shubham Pampattiwar <[email protected]> add changelog file Signed-off-by: Shubham Pampattiwar <[email protected]>
shubham-pampattiwar
force-pushed
the
add-desc-markers
branch
from
8a6c37d to
4dbb262
Compare
Lyndon-Li
approved these changes
Oct 27, 2023
Codecov Report
@@ Coverage Diff @@
## main #7028 +/- ##
==========================================
- Coverage 61.03% 61.00% -0.03%
==========================================
Files 252 252
Lines 26898 26898
==========================================
- Hits 16417 16409 -8
- Misses 9319 9326 +7
- Partials 1162 1163 +1 |
| @@ -131,6 +131,7 @@ type DataDownloadStatus struct { | |||
| // +kubebuilder:printcolumn:name="Age",type="date",JSONPath=".metadata.creationTimestamp",description="Time duration since this DataDownload was created" | |||
| // +kubebuilder:printcolumn:name="Node",type="string",JSONPath=".status.node",description="Name of the node where the DataDownload is processed" | |||
|
|
|||
| // DataDownload acts as the protocol between data mover plugins and data mover controller for the datamover restore operation | |||
There was a problem hiding this comment.
One thing I would add is that users should not create it, Velero creates it
There was a problem hiding this comment.
User actions aren't referenced in any of the description markers for the CRDs -- that's something that is probably better handled in the user documentation. Also, the description that was added implies that it's not user-managed in any case -- there are several velero CRDs that are like this, it's not unique to these two.
sseago
approved these changes
Oct 27, 2023
sseago
approved these changes
Oct 27, 2023
shubham-pampattiwar
added a commit
to shubham-pampattiwar/velero
that referenced
this pull request
Oct 31, 2023
…tanzu#7028) add changelog file Signed-off-by: Shubham Pampattiwar <[email protected]> (cherry picked from commit 23921e5)
shubham-pampattiwar
added a commit
to shubham-pampattiwar/velero
that referenced
this pull request
Oct 31, 2023
…tanzu#7028) add changelog file Signed-off-by: Shubham Pampattiwar <[email protected]> (cherry picked from commit 23921e5) rename changelog file Signed-off-by: Shubham Pampattiwar <[email protected]>
shubham-pampattiwar
added a commit
to shubham-pampattiwar/velero
that referenced
this pull request
Nov 7, 2023
…tanzu#7028) add changelog file Signed-off-by: Shubham Pampattiwar <[email protected]> (cherry picked from commit 23921e5) rename changelog file Signed-off-by: Shubham Pampattiwar <[email protected]> fix PR CI validation errors Signed-off-by: Shubham Pampattiwar <[email protected]>
blackpiglet
added a commit
that referenced
this pull request
Jan 17, 2024
…12-rel Add description markers for dataupload and datadownload CRDs (#7028)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Velero!
Please add a summary of your change
Add description markers for dataupload and datadownload CRDs
Does your change fix a particular issue?
Related to openshift/oadp-operator#1204
Please indicate you've done the following:
/kind changelog-not-requiredas a comment on this pull request.site/content/docs/main.