Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[oadp-1.2] [OADP-2959] Add missing descriptions to all CRDs (#1200) #1213

Merged

Conversation

mpryc
Copy link
Contributor

@mpryc mpryc commented Nov 3, 2023

Adds missing descriptions to the following CRDs:

  • DataDownload
  • DataUpload
  • VolumeSnapshotBackup
  • VolumeSnapshotRestore
  • CloudStorage

…t#1200)

Adds missing descriptions to the following CRDs:

 - DataDownload
 - DataUpload
 - VolumeSnapshotBackup
 - VolumeSnapshotRestore
 - CloudStorage

Signed-off-by: Michal Pryc <[email protected]>
@kaovilai
Copy link
Member

kaovilai commented Nov 3, 2023

/lgtm

Copy link

openshift-ci bot commented Nov 3, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kaovilai, mpryc

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 3, 2023
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Nov 3, 2023
@mpryc
Copy link
Contributor Author

mpryc commented Nov 3, 2023

/retest

Copy link

openshift-ci bot commented Nov 3, 2023

@mpryc: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-ci openshift-ci bot merged commit 7924da8 into openshift:oadp-1.2 Nov 3, 2023
@mateusoliveira43
Copy link
Contributor

DataUpload and DataDownLoad do not exist in 1.2 branch

@mpryc
Copy link
Contributor Author

mpryc commented Nov 6, 2023

DataUpload and DataDownLoad do not exist in 1.2 branch

As I stated in 1.3 that is fine, as long as we have coverage between 1.3 and 1.2 the descriptions will be properly rendered, and having the additional ones will make the cherry pick process easier as it's 1-1 patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants