*: remove the old installer code #342
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
the
approved
openshift-ci-robot
added
the
size/XXL
|
/hold Waiting on CI to be merged. |
openshift-ci-robot
added
the
do-not-merge/hold
This was referenced Sep 27, 2018
|
/hold cancel |
openshift-ci-robot
removed
the
do-not-merge/hold
|
conflicts ;) |
Merged
openshift-bot
added
the
needs-rebase
This removes all of the files which are directly required by bazel.
The installer no longer reads Ignition files or the CA from disk, so these aren't needed.
The installer package is going to be removed. This moves the remaining validation functionality.
openshift-bot
removed
the
needs-rebase
|
@crawford: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
More to get when you rebase: $ git grep -i bazel | cat
.gitignore:# non-default Bazel stuff
.gitignore:# Created by https://www.gitignore.io/api/go,bazel,terraform
.gitignore:### Bazel ###
.gitignore:/bazel-*
.gitignore:# End of https://www.gitignore.io/api/go,bazel,terraform
CONTRIBUTING.md: hack/test-bazel-build-tarball.sh
docs/design/assetgeneration.md:The installer internally uses a directed acyclic graph to represent all of the assets it creates as well as their dependencies. This process looks very similar to many build systems (e.g. Bazel, Make).
docs/dev/libvirt-howto.md:bazel build tarball
docs/dev/libvirt-howto.md:tar -zxf bazel-bin/tectonic-dev.tar.gz
hack/test-bazel-build-tarball.sh: bazel --output_base=/tmp build "$@" tarball
hack/test-bazel-build-tarball.sh: quay.io/coreos/tectonic-builder:bazel-v0.3 \
hack/test-bazel-build-tarball.sh: ./hack/test-bazel-build-tarball.sh
images/installer-origin-release/Dockerfile.ci:FROM openshift/origin-release:bazel
images/installer-origin-release/Dockerfile.ci:ENV USER="bazel"
images/installer-origin-release/Dockerfile.ci:RUN bazel --output_base=/tmp build smoke_tests && \
images/installer-origin-release/Dockerfile.ci: cp bazel-bin/tests/smoke/linux_amd64_pure_stripped/go_default_test /usr/bin/smoke && \
images/installer-origin-release/Dockerfile.ci: bazel clean
images/tectonic-installer/Dockerfile:# from bazel-bin/tectonic.tar.gz to the docker build context folder of your
pkg/terraform/terraform.go:// TODO(yifan): Get rid of this when moving off building with bazel.
tests/run.sh:bazel build tarball smoke_tests
tests/run.sh:# In future bazel build could be extracted to another job which could be running in docker container like this:
tests/run.sh:# docker run --rm -v $PWD:$PWD:Z -w $PWD quay.io/coreos/tectonic-builder:bazel-v0.3 bazel build tarball smoke_tests
tests/run.sh:tar -zxf bazel-bin/tectonic-dev.tar.gz
tests/run.sh:cp bazel-bin/tests/smoke/linux_amd64_pure_stripped/go_default_test tectonic-dev/smoke
tests/smoke/README.md:bazel build smoke_tests
tests/smoke/README.md:The tests can then be run by invoking the `go_default_test` binary in the `bazel-bin/tests/smoke/linux_amd64_pure_stripped` directory.
tests/smoke/README.md:bazel-bin/tests/smoke/linux_amd64_pure_stripped/go_default_test -cluster -test.v
|
This is the last of the old installer code. It's no longer used and can be removed.
After removing the installer code, these dependencies were removed by glide.
These were used by the old installer, which has now been deleted.
Rather than just checking the old directories, we'd might as well test the entire repository. This also updates all of the yaml files, making them more readable, in my opinion.
|
@wking Added your suggestions (leaving off the things you have in flight). |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Sep 28, 2018
Generated with: $ glide remove github.com/AlecAivazis/survey $ glide get --strip-vendor gopkg.in/AlecAivazis/survey [INFO]Preparing to install 1 package. [INFO]Attempting to get package gopkg.in/AlecAivazis/survey.v1 [INFO]--> Gathering release information for gopkg.in/AlecAivazis/survey.v1 [INFO]The package gopkg.in/AlecAivazis/survey.v1 appears to have Semantic Version releases (http://semver.org). [INFO]The latest release is v1.6.2. You are currently not using a release. Would you like [INFO]to use this release? Yes (Y) or No (N) y [INFO]The package gopkg.in/AlecAivazis/survey.v1 appears to use semantic versions (http://semver.org). [INFO]Would you like to track the latest minor or patch releases (major.minor.patch)? [INFO]The choices are: [INFO] - Tracking minor version releases would use '>= 1.6.2, < 2.0.0' ('^1.6.2') [INFO] - Tracking patch version releases would use '>= 1.6.2, < 1.7.0' ('~1.6.2') [INFO] - Skip using ranges [INFO]For more information on Glide versions and ranges see https://glide.sh/docs/versions [INFO]Minor (M), Patch (P), or Skip Ranges (S)? m [INFO]--> Adding gopkg.in/AlecAivazis/survey.v1 to your configuration with the version ^1.6.2 ... $ glide-vc --use-lock-file --no-tests --only-code $ git checkout HEAD -- vendor/github.com/shurcooL/httpfs using: $ glide --version glide version 0.13.2-dev $ (cd $GOPATH/src/github.com/Masterminds/glide && git describe) v0.13.1-7-g3e13fd1 $ (cd $GOPATH/src/github.com/sgotti/glide-vc && git describe) v0.1.0-2-g6ddf6ee The httpfs works around our busted vfsutil vendor, see a8cce08 (vendor: Add shurcooL/httpfs/vfsutil, 2018-09-26, openshift#340). The formatting change unwinds ff9e547 (*: format all yaml files, 2018-09-27, openshift#342), but it doesn't seem to be worth fighting Glide on this front.
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Sep 28, 2018
Catching up with 0c6d53b (*: remove bazel, 2018-09-24, openshift#342).
This was referenced Sep 28, 2018
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Oct 4, 2018
With openshift-install, the config type is a one-way map from InstallConfig to Terraform, so we can drop these methods. The last consumers were removed in b6c0d8c (installer: remove package, 2018-09-26, openshift#342).
wking
added a commit
to wking/openshift-installer
that referenced
this pull request
Oct 20, 2018
These escaped the great purge of 0c6d53b (*: remove bazel, 2018-09-24, openshift#342). kubernetes/BUILD.bazel snuck in with 70ea0e8 (tests/smoke/vendor: switch from glide to dep, 2018-09-28, openshift#380), and tectonic/BUILD.bazel snuck in with e2d9fd3 (manifests: make tectonic/ flat dir, 2018-09-25, openshift#330). I'd guess both were due to rebases from commits originally made before openshift#342 landed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.