Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*/BUILD.bazel: Remove leftover Bazel files #505

Merged
merged 1 commit into from
Oct 20, 2018

Conversation

wking
Copy link
Member

@wking wking commented Oct 20, 2018

These escaped the great purge of 0c6d53b (#342). kubernetes/BUILD.bazel snuck in with 70ea0e8 (#380), and tectonic/BUILD.bazel snuck in with e2d9fd3 (#330). I'd guess both were due to rebases from commits originally made before #342 landed.

These escaped the great purge of 0c6d53b (*: remove bazel,
2018-09-24, openshift#342).  kubernetes/BUILD.bazel snuck in with 70ea0e8
(tests/smoke/vendor: switch from glide to dep, 2018-09-28, openshift#380), and
tectonic/BUILD.bazel snuck in with e2d9fd3 (manifests: make tectonic/
flat dir, 2018-09-25, openshift#330).  I'd guess both were due to rebases from
commits originally made before openshift#342 landed.
@openshift-ci-robot openshift-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Oct 20, 2018
Copy link
Contributor

@abhinavdahiya abhinavdahiya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Oct 20, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abhinavdahiya, wking

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [abhinavdahiya,wking]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 974a95f into openshift:master Oct 20, 2018
@wking wking deleted the build-bazel-purge branch October 20, 2018 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants