pkg/types/config: Prefix "pull secret" in validatePullSecret #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openshift-ci-robot
added
size/XS
wking
changed the title
wking
force-pushed
the
prefix-pull-secret-error
branch
2 times, most recently
from
35d88e1 to
28ec9f7
Compare
|
/retest Please review the full test history for this PR and help us cut down flakes. |
1 similar comment
|
/retest Please review the full test history for this PR and help us cut down flakes. |
wking
force-pushed
the
prefix-pull-secret-error
branch
from
28ec9f7 to
5f0e2a4
Compare
wking
force-pushed
the
prefix-pull-secret-error
branch
from
5f0e2a4 to
13dfc10
Compare
|
CI is failing with: |
|
Ahh, it's |
wking
force-pushed
the
prefix-pull-secret-error
branch
from
13dfc10 to
3ab0f7d
Compare
To match a lot of other error handling in this package and give more useful error messages (if we somehow get past the input validation in pkg/asset/installconfig).
|
Green now ;) |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: crawford, wking The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To match a lot of other error handling in this package and give more useful error messages (if we somehow get past the input validation in
pkg/asset/installconfig)./assign @crawford
Dunno if you're tearing this out with your overhaul, but here it is in case it doesn't collide ;).