HOSTEDCP-1542: cmd/cluster: refactor to remove example fixtures

[stevekuznetsov]

The goal of this refactor is to reduce the complexity in the command-line tooling. Overall, the changes here remove duplicative structures that copied data around and co-locate the logic with the data, instead of first aggregating all data into one uber-structure and then conditionally acting on that structure. These refactors have a number of benefits:

• locality of behavior: in the past, it was very difficult if not impossible to determine where a value was used, as it would be bound to a flag in one package, copied around between container structs a couple of times, then have some generic logic act on the presence or absence of the value to e.g. change a field on the HostedCluster. Simply reading the generic logic was often not enough to understand what was going on, as many of the conditional branches in the example fixture code could only ever trigger for one specific platform, and you'd never know unless you traced how the example options uber-struct had its fields set in every provider.
• clear go-to-definition: as a knock-on effect of the above, now there's one structure that holds a command-line flag and it's trivial to use the LSP when determining where that flag is used and how
• composability: as exemplified in the KubeVirt NodePool code, we are able to compose commands as necessary. When commands re-use the same arguments with the same flags and the same validation logic, there's no need to copy things around and re-implement anything; by localizing flag binding, validation and option completion, we gain small, composable parts that we can use to build larger commands with

[openshift-ci-robot]

@stevekuznetsov: This pull request references HOSTEDCP-1542 which is a valid jira issue.

In response to this:

The goal of this refactor is to reduce the complexity in the command-line tooling. Overall, the changes here remove duplicative structures that copied data around and co-locate the logic with the data, instead of first aggregating all data into one uber-structure and then conditionally acting on that structure. These refactors have a number of benefits:

• locality of behavior: in the past, it was very difficult if not impossible to determine where a value was used, as it would be bound to a flag in one package, copied around between container structs a couple of times, then have some generic logic act on the presence or absence of the value to e.g. change a field on the HostedCluster. Simply reading the generic logic was often not enough to understand what was going on, as many of the conditional branches in the example fixture code could only ever trigger for one specific platform, and you'd never know unless you traced how the example options uber-struct had its fields set in every provider.
• clear go-to-definition: as a knock-on effect of the above, now there's one structure that holds a command-line flag and it's trivial to use the LSP when determining where that flag is used and how
• composability: as exemplified in the KubeVirt NodePool code, we are able to compose commands as necessary. When commands re-use the same arguments with the same flags and the same validation logic, there's no need to copy things around and re-implement anything; by localizing flag binding, validation and option completion, we gain small, composable parts that we can use to build larger commands with

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[davidvossel]

kubevirt parts look accurate

[netlify]

✅ Deploy Preview for hypershift-docs ready!

Name	Link
🔨 Latest commit	3e68ee3
🔍 Latest deploy log	https://app.netlify.com/sites/hypershift-docs/deploys/6669b8dc4029e5000830c0dc
😎 Deploy Preview	https://deploy-preview-4018--hypershift-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[stevekuznetsov]

/retest

[sjenning]

=== RUN   TestAutoscaling/ValidateHostedCluster/EnsureNoCrashingPods
    util.go:533: Container cloud-controller-manager in pod kubevirt-cloud-controller-manager-7cc4ccf9b9-644r2 has a restartCount > 0 (1)

=== RUN   TestCreateCluster/ValidateHostedCluster/EnsureNoCrashingPods
    util.go:533: Container cloud-controller-manager in pod kubevirt-cloud-controller-manager-6d48cd658d-d6k7n has a restartCount > 0 (1)
    util.go:533: Container oauth-apiserver in pod openshift-oauth-apiserver-5c7dd4b5dc-l2s5z has a restartCount > 0 (1)

Seems like a flake but some jobs are passing now (new development)

/retest-required

[sjenning]

/approve
/lgtm

[stevekuznetsov]

/retest

[stevekuznetsov]

/retest

[stevekuznetsov]

/hold cancel

[stevekuznetsov]

/retest

[csrwng]

/lgtm

[bryan-cox]

/lgtm

[openshift-ci-robot]

/retest-required

Remaining retests: 0 against base HEAD 1f16f14 and 2 for PR HEAD ee7e223 in total

[openshift-ci]

@stevekuznetsov: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
ci/prow/e2e-azure	ee7e223	link	false	/test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[openshift-bot]

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.17.0-202406130611.p0.gba61c73.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.