HOSTEDCP-1542: cmd: add an option to render into a file, use it in e2e #4036
Conversation
|
@stevekuznetsov: This pull request references HOSTEDCP-1542 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
bot
added
area/cli
stevekuznetsov
force-pushed
the
skuznets/expose-cli-output
branch
from
c4660fa to
87ccad6
Compare
stevekuznetsov
force-pushed
the
skuznets/expose-cli-output
branch
from
87ccad6 to
a833ee0
Compare
|
/lgtm |
|
/retest-required |
stevekuznetsov
force-pushed
the
skuznets/expose-cli-output
branch
from
a833ee0 to
f801ac1
Compare
|
why do we even need this? all resources created by the cli are already part of the dump. What is the added value of having them in a single manifest. You will mainly be looking only at the HostedCluster / NodePool resources, which are easily found in the dump, |
I wrote a PR that changes how the CLI works. I want to test that, and to do that I wanted to capture what the CLI was going to do by dumping the objects it would make, then we can assert over that output. I don't want post-creation modifications, etc, to influence this. Can you think of another way to capture it? |
|
|
@muraee I want to test the CLI. While it's possible that nothing touches these manifests after the fact, having to a) know what the list of manifests is, b) collect them from the larger artifact dir, c) know which fields to ignore and when is much more difficult than simply asserting over the output of the CLI. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: csrwng, stevekuznetsov The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
openshift-merge-robot
added
the
needs-rebase
The closest thing we have to testing the command-line is our end-to-end code that re-uses the options structs and runs them through the logic that the command-line does. We can capture a lot of the work done in the command-line by inspecting the output manifests, which is easiest to do by rendering them as a test artfact. Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
|
/hold Revision eef4a0a was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
|
/retest |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/hold Revision eef4a0a was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/retest |
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
/retest |
|
/hold Revision eef4a0a was retested 3 times: holding |
openshift-ci
bot
added
the
do-not-merge/hold
|
/unhold |
openshift-ci
bot
removed
the
do-not-merge/hold
|
/retest-required |
|
@stevekuznetsov: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
/test e2e-kubevirt-aws-ovn |
openshift-merge-bot
bot
merged commit e66add8
into
openshift:main
|
holy moly we did it |
…s/expose-cli-output" This reverts commit e66add8, reversing changes made to cd2d529. Signed-off-by: Steve Kuznetsov <[email protected]>
|
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.17.0-202406041942.p0.ge66add8.assembly.stream.el9 for distgit hypershift. |
The closest thing we have to testing the command-line is our end-to-end code that re-uses the options structs and runs them through the logic that the command-line does. We can capture a lot of the work done in the command-line by inspecting the output manifests, which is easiest to do by rendering them as a test artfact.
Helps to test #4018