Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HOSTEDCP-1542: Fixed infra-id not being defaulted first #4210

Merged
merged 3 commits into from
Jun 14, 2024

Conversation

muraee
Copy link
Contributor

@muraee muraee commented Jun 13, 2024

What this PR does / why we need it:

  • Fixes infra-id not being defaulted first
  • Fixes platform specific validations not being executed

follow-up of #4018

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Jun 13, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Jun 13, 2024

@muraee: This pull request references HOSTEDCP-1542 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead.

In response to this:

What this PR does / why we need it:

  • Fixes infra-id not being defaulted first
  • Fixes platform specific validations not being executed

follow-up of #4018

Which issue(s) this PR fixes (optional, use fixes #<issue_number>(, fixes #<issue_number>, ...) format, where issue_number might be a GitHub issue, or a Jira story:
Fixes #

Checklist

  • Subject and description added to both, commit and PR.
  • Relevant issues have been referenced.
  • This change includes docs.
  • This change includes unit tests.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@muraee muraee changed the title HOSTEDCP-1542:: Fixed infra-id not being defaulted first HOSTEDCP-1542: Fixed infra-id not being defaulted first Jun 13, 2024
@openshift-ci openshift-ci bot added the area/cli Indicates the PR includes changes for CLI label Jun 13, 2024
Copy link
Contributor

openshift-ci bot commented Jun 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: muraee

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-area labels Jun 13, 2024
@Patryk-Stefanski
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@stevekuznetsov
Copy link
Contributor

If possible please let's get this in after #4018

/hold

@openshift-ci openshift-ci bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2024
@stevekuznetsov
Copy link
Contributor

I'm blind as a bat and my tabs didn't refresh this morning... already merged

/hold cancel

@openshift-ci openshift-ci bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jun 13, 2024
cmd/cluster/core/create.go Show resolved Hide resolved
cmd/cluster/core/create.go Show resolved Hide resolved
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
- fixed platfrom specifc validation not being executed
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@openshift-ci openshift-ci bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
- ResourceGroupName, VNetID and SubnetID
@stevekuznetsov
Copy link
Contributor

/lgtm

@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label Jun 13, 2024
@openshift-ci-robot
Copy link

/retest-required

Remaining retests: 0 against base HEAD 2b6f01a and 2 for PR HEAD 48180fb in total

@stevekuznetsov
Copy link
Contributor

Superseded by #4212

@muraee
Copy link
Contributor Author

muraee commented Jun 14, 2024

/override ci/prow/e2e-kubevirt-aws-ovn

Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

@muraee: Overrode contexts on behalf of muraee: ci/prow/e2e-kubevirt-aws-ovn

In response to this:

/override ci/prow/e2e-kubevirt-aws-ovn

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

openshift-ci bot commented Jun 14, 2024

@muraee: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure 48180fb link false /test e2e-azure

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@openshift-merge-bot openshift-merge-bot bot merged commit 049c72e into openshift:main Jun 14, 2024
12 of 13 checks passed
@muraee
Copy link
Contributor Author

muraee commented Jun 14, 2024

@stevekuznetsov getting this merged to unblock folks, the infra-id issue is also showing in aws.

@openshift-bot
Copy link

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-hypershift-container-v4.17.0-202406141211.p0.g049c72e.assembly.stream.el9 for distgit hypershift.
All builds following this will include this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/cli Indicates the PR includes changes for CLI jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. lgtm Indicates that a PR is ready to be merged.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants