-
Notifications
You must be signed in to change notification settings - Fork 331
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HOSTEDCP-1542: Fixed infra-id not being defaulted first #4210
Conversation
@muraee: This pull request references HOSTEDCP-1542 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.17." or "openshift-4.17.", but it targets "openshift-4.16" instead. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: muraee The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/lgtm |
If possible please let's get this in after #4018 /hold |
I'm blind as a bat and my tabs didn't refresh this morning... already merged /hold cancel |
- fixed platfrom specifc validation not being executed
/lgtm |
- ResourceGroupName, VNetID and SubnetID
/lgtm |
Superseded by #4212 |
/override ci/prow/e2e-kubevirt-aws-ovn |
@muraee: Overrode contexts on behalf of muraee: ci/prow/e2e-kubevirt-aws-ovn In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
@muraee: The following test failed, say
Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
049c72e
into
openshift:main
@stevekuznetsov getting this merged to unblock folks, the infra-id issue is also showing in aws. |
[ART PR BUILD NOTIFIER] This PR has been included in build ose-hypershift-container-v4.17.0-202406141211.p0.g049c72e.assembly.stream.el9 for distgit hypershift. |
What this PR does / why we need it:
infra-id
not being defaulted firstfollow-up of #4018
Which issue(s) this PR fixes (optional, use
fixes #<issue_number>(, fixes #<issue_number>, ...)
format, where issue_number might be a GitHub issue, or a Jira story:Fixes #
Checklist