Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CONSOLE-3081: Include pf charts dark theme css file in app.jsx to ensure they are loaded last #11535

Merged
merged 1 commit into from
May 24, 2022
Merged

CONSOLE-3081: Include pf charts dark theme css file in app.jsx to ensure they are loaded last #11535

merged 1 commit into from
May 24, 2022

Conversation

sg00dwin
Copy link
Member

@sg00dwin sg00dwin commented May 19, 2022 •
edited
Loading

The latest PatternFly charts updated for dark theme support are pulled in, but its @patternfly/patternfly/patternfly-charts-theme-dark.css needs to be imported after all other css is loaded, so it is included in app.jsx
Similar to #11370

before
overview-broke
routes-bad

after
overview-good
routes-good

@openshift-ci openshift-ci bot requested review from jcaianirh and jhadvig May 19, 2022 15:29
@openshift-ci openshift-ci bot added the component/core Related to console core functionality label May 19, 2022
mattnolting
mattnolting approved these changes May 19, 2022
View reviewed changes
Copy link
Contributor

@mattnolting mattnolting left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm 👍

jcaianirh
jcaianirh reviewed May 19, 2022
View reviewed changes
Copy link
Member

@jcaianirh jcaianirh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@jcaianirh jcaianirh changed the title Include pf charts dark theme css file in app.jsx to ensure they are loaded last CONSOLE-3081: Include pf charts dark theme css file in app.jsx to ensure they are loaded last May 19, 2022
@openshift-ci openshift-ci bot added the lgtm Indicates that a PR is ready to be merged. label May 19, 2022
@jcaianirh
Copy link
Member

/label docs-approved
/label px-approved

QE Approver:
/assign @yapei

@openshift-ci openshift-ci bot added docs-approved Signifies that Docs has signed off on this PR px-approved Signifies that Product Support has signed off on this PR labels May 19, 2022
@jcaianirh
Copy link
Member

/test analyze

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 19, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewballantyne, jcaianirh, mattnolting, sg00dwin

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci openshift-ci bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 19, 2022
@yanpzhan
Copy link
Contributor

/label qe-approved

@openshift-ci openshift-ci bot added the qe-approved Signifies that QE has signed off on this PR label May 23, 2022
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

6 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jcaianirh
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jcaianirh
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jcaianirh
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

2 similar comments
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@jcaianirh
Copy link
Member

/retest

@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

1 similar comment
@openshift-bot
Copy link
Contributor

/retest-required

Please review the full test history for this PR and help us cut down flakes.

@openshift-ci
Copy link
Contributor

openshift-ci bot commented May 24, 2022

@sg00dwin: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@openshift-merge-robot openshift-merge-robot merged commit 7b3e4ff into openshift:master May 24, 2022
@jpinsonneau jpinsonneau mentioned this pull request May 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jcaianirh jcaianirh jcaianirh approved these changes

@andrewballantyne andrewballantyne andrewballantyne approved these changes

@mattnolting mattnolting mattnolting approved these changes

@jhadvig jhadvig Awaiting requested review from jhadvig

Assignees

@yapei yapei

@jcaianirh jcaianirh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality docs-approved Signifies that Docs has signed off on this PR lgtm Indicates that a PR is ready to be merged. px-approved Signifies that Product Support has signed off on this PR qe-approved Signifies that QE has signed off on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@sg00dwin @jcaianirh @yanpzhan @openshift-bot @mattnolting @andrewballantyne @yapei @openshift-merge-robot