CONSOLE-3081: moved imports #11370
CONSOLE-3081: moved imports #11370
Conversation
frontend/public/components/app.jsx
Outdated
| @@ -61,6 +61,7 @@ const NOTIFICATION_DRAWER_BREAKPOINT = 1800; | |||
| // Edge lacks URLSearchParams | |||
| import 'url-search-params-polyfill'; | |||
| import { graphQLReady } from '../graphql/client'; | |||
| import '@patternfly/patternfly/patternfly-theme-dark.scss'; // load dark theme here as MiniCssExtractPlugin ignores load order of sass and dark theme must load after all other css | |||
There was a problem hiding this comment.
Can this go on line 55 so it's with the other (s)css?
There was a problem hiding this comment.
Yes, if line 57 can move to line 52, above the css imports
There was a problem hiding this comment.
Sure. The goal is to keep things grouped.
There was a problem hiding this comment.
@rhamilto updated
openshift-ci
bot
added
the
needs-ok-to-test
|
Hi @mattnolting. Thanks for your PR. I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
mattnolting
force-pushed
the
fix-dark-theme-import
branch
from
73e4010
to
b6721b2
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: mattnolting, rhamilto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
the
approved
|
I have a feeling this is due to https://github.com/openshift/console/blob/master/frontend/webpack.config.ts#L39 |
|
QE Approver: |
|
/ok-to-test |
openshift-ci
bot
added
ok-to-test
|
/label docs-approved We have docs- and px-approval for the epic. |
openshift-ci
bot
added
docs-approved
|
@yanpzhan will test the PR |
|
@mattnolting Launched a cluster against the pr, about white box mentioned in #11384 (comment), still found on the cluster: |
@yanpzhan No, #11384 converts this component to a PF toggle group. For the toggle group to appear correctly in @sg00dwin's PR, this PR will need to be merged. |
|
@mattnolting Thanks for your info. |
openshift-ci
bot
added
the
qe-approved
|
/retest |
|
/retest-required Please review the full test history for this PR and help us cut down flakes. |
|
@mattnolting: all tests passed! Full PR test history. Your PR dashboard. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There's a bug in
MiniCssExtractPluginthat misorderscssimports. To resolve this, it appears that.scssimported inapp.jsxAFTER other imports works as expected, but to ensure that dark theme imports are correctly ordered, it's most reliable to use.css(MiniCssExtractPlugindoes not seem to present this issue with.cssfiles).