Dark theme support

[jpinsonneau]

Updated PF libs and fixed css for dark theme
Also updated topology label icons since there was breaking changes in the lib

[jpinsonneau]

Topology prerelease version 4.60.3 works fine

I guess we should wait for latest tag to be updated before merge

[jpinsonneau]

console has been updated to include PF chart CSS openshift/console#11535 keeping "@patternfly/react-charts": "6.67.1"

No changes needed on our side:

[jotak]

Code lgtm
(not tested)

[jpinsonneau]

Code lgtm (not tested)

thanks @jotak
Do you want some time to test or can I merge it ?

[jotak]

Code lgtm (not tested)

thanks @jotak Do you want some time to test or can I merge it ?

Hmm since there's no JIRA Mehul may miss it, but no problem I'll do a quick test

[jotak]

Actually, how can I test it? Do I need to run console latest / master, to get this dark mode? I don't see it on my cluster (4.9.15)

[jpinsonneau]

Actually, how can I test it? Do I need to run console latest / master, to get this dark mode? I don't see it on my cluster (4.9.15)

You need 4.11 to run all of this in the Openshift environment.
If you want to test on OKD only, you can simply pull console main branch, build it and then run the bridge.
Finally there is the santalone way #163 that uses the same dependencies versions as the console.

[jotak]

ok I'll try with the bridge

(btw I meant I use 4.10.15, not 4.9.15 ... I'm not that far behind! :) )

[jotak]

tests ok, nice!
/lgtm

[jpinsonneau]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jpinsonneau

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [jpinsonneau]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment