OCPBUGS-44880: Fetch service instance id from spec of IBMPowerVSCluster object while setting provider id

[aman4433]

What this PR does / Why we need it:

This PR addresses a scenario where the service instance ID is explicitly passed when using an external cloud-provider template, but it is not set under the status field of the IBMPowerVSCluster object. In such cases, the provider ID for the machine is incorrectly set to an empty string, which can lead to issues.

To resolve this, this PR updates the logic to retrieve the service instance ID from the spec field of the IBMPowerVSCluster object if it is not found under the status field. This ensures that the service instance ID is correctly populated, even when not set in the status.

Release note:

Fetches the service instance ID from the spec field of the IBMPowerVSCluster object if it is not present under the status.

[openshift-ci-robot]

@aman4433: This pull request references Jira Issue OCPBUGS-44880, which is invalid:

• expected the bug to target the "4.17.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-44880 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to this:

What this PR does / Why we need it:

This PR addresses a scenario where the service instance ID is explicitly passed when using an external cloud-provider template, but it is not set under the status field of the IBMPowerVSCluster object. In such cases, the provider ID for the machine is incorrectly set to an empty string, which can lead to issues.

To resolve this, this PR updates the logic to retrieve the service instance ID from the spec field of the IBMPowerVSCluster object if it is not found under the status field. This ensures that the service instance ID is correctly populated, even when not set in the status.

Release note:

Fetches the service instance ID from the spec field of the IBMPowerVSCluster object if it is not present under the status.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci]

Hi @aman4433. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[mkumatag]

@Karthik-K-N this fix is already in upstream repo right? wondering if rebasing to the latest release will help fixing this one?

[dharaneeshvrd]

/jira refresh

[openshift-ci-robot]

@dharaneeshvrd: This pull request references Jira Issue OCPBUGS-44880, which is invalid:

• expected the bug to target the "4.17.z" version, but no target version was set
• release note text must be set and not match the template OR release note type must be set to "Release Note Not Required". For more information you can reference the OpenShift Bug Process.
• expected Jira Issue OCPBUGS-44880 to depend on a bug targeting a version in 4.18.0 and in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[Karthik-K-N]

@Karthik-K-N this fix is already in upstream repo right? wondering if rebasing to the latest release will help fixing this one?

4.18 we rebased recently and add this fix to 4.17 only. More info.

[Karthik-K-N]

/ok-to-test

[dharaneeshvrd]

/jira refresh

[openshift-ci-robot]

@dharaneeshvrd: This pull request references Jira Issue OCPBUGS-44880, which is invalid:

• dependent bug OCPCLOUD-2747 is not in the required OCPBUGS project

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[damdo]

We should title the commit in this PR: UPSTREAM: 1816: Use ignition only when Ignition is set in IBMPowerVSCluster
Could you git amend? @aman4433
Thanks!

/hold

[aman4433]

We should title the commit in this PR: UPSTREAM: 1816: Use ignition only when Ignition is set in IBMPowerVSCluster Could you git amend? @aman4433 Thanks!

/hold

Done @damdo
Thanks!

[damdo]

/approve

/unhold

leaving the LGTM to @mkumatag @Karthik-K-N

[openshift-ci]

@aman4433: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[Karthik-K-N]

/lgtm
Thanks

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[damdo]

/assign @JoelSpeed
For the valid-bug label

[damdo]

/label backport-risk-assessed

[sunzhaohua2]

/label cherry-pick-approved

[JoelSpeed]

You need to create a bug against the future branches and create a chain back, you can just assign them directly to the QE phase for them to move to verified (assuming the fix is in and verified), we can't make them dependent against an OCPCLOUD card

[dharaneeshvrd]

Thanks @JoelSpeed for the suggestion, created a JIRA issue here https://issues.redhat.com/browse/OCPBUGS-44944

[dharaneeshvrd]

@juliemathew Could you please help verify this issue https://issues.redhat.com/browse/OCPBUGS-44944?

[dharaneeshvrd]

/jira refresh

[openshift-ci-robot]

@dharaneeshvrd: This pull request references Jira Issue OCPBUGS-44880, which is invalid:

• expected dependent Jira Issue OCPBUGS-44944 to target a version in 4.18.0, but it targets "4.18.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dharaneeshvrd]

/jira refresh

[openshift-ci-robot]

@dharaneeshvrd: This pull request references Jira Issue OCPBUGS-44880, which is invalid:

• expected dependent Jira Issue OCPBUGS-44944 to target a version in 4.18.0, but it targets "4.18.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dharaneeshvrd]

/jira refresh

[openshift-ci-robot]

@dharaneeshvrd: This pull request references Jira Issue OCPBUGS-44880, which is invalid:

• expected dependent Jira Issue OCPBUGS-44944 to target a version in 4.18.0, but it targets "4.18.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dharaneeshvrd]

/jira refresh

[openshift-ci-robot]

@dharaneeshvrd: This pull request references Jira Issue OCPBUGS-44880, which is invalid:

• expected dependent Jira Issue OCPBUGS-44944 to target a version in 4.18.0, but it targets "4.18.z" instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[dharaneeshvrd]

/jira refresh

[openshift-ci-robot]

@dharaneeshvrd: This pull request references Jira Issue OCPBUGS-44880, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

• bug is open, matching expected state (open)
• bug target version (4.17.z) matches configured target version for branch (4.17.z)
• bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)
• release note text is set and does not match the template
• dependent bug Jira Issue OCPBUGS-44944 is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA))
• dependent Jira Issue OCPBUGS-44944 targets the "4.18.0" version, which is one of the valid target versions: 4.18.0
• bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira ([email protected]), skipping review request.

In response to this:

/jira refresh

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-ci-robot]

@aman4433: Jira Issue OCPBUGS-44880: All pull requests linked via external trackers have merged:

• openshift/cluster-api-provider-ibmcloud#94

Jira Issue OCPBUGS-44880 has been moved to the MODIFIED state.

In response to this:

What this PR does / Why we need it:

This PR addresses a scenario where the service instance ID is explicitly passed when using an external cloud-provider template, but it is not set under the status field of the IBMPowerVSCluster object. In such cases, the provider ID for the machine is incorrectly set to an empty string, which can lead to issues.

To resolve this, this PR updates the logic to retrieve the service instance ID from the spec field of the IBMPowerVSCluster object if it is not found under the status field. This ensures that the service instance ID is correctly populated, even when not set in the status.

Release note:

Fetches the service instance ID from the spec field of the IBMPowerVSCluster object if it is not present under the status.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-ibmcloud-cluster-api-controllers
This PR has been included in build ose-ibmcloud-cluster-api-controllers-container-v4.17.0-202411281306.p0.g213d34d.assembly.stream.el9.
All builds following this will include this PR.