Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OSDOCS-12853: 4.17.8 RN #86109

Merged
merged 1 commit into from
Dec 11, 2024
Merged

OSDOCS-12853: 4.17.8 RN #86109

merged 1 commit into from
Dec 11, 2024

Conversation

obrown1205
Copy link
Contributor

@obrown1205 obrown1205 commented Dec 11, 2024 •
edited
Loading

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Dec 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2024 •
edited by openshift-ci bot
Loading

@obrown1205: This pull request references OSDOCS-12853 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
https://github.com/obrown1205/openshift-docs/pull/new/OSDOCS-12853

Link to docs preview:

QE review:

  • QE has approved this change.

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2024 •
edited by openshift-ci bot
Loading

@obrown1205: This pull request references OSDOCS-12853 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
https://github.com/obrown1205/openshift-docs/pull/new/OSDOCS-12853

Link to docs preview:

QE review:
N/A

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Dec 11, 2024
@ocpdocs-previewbot
Copy link

ocpdocs-previewbot commented Dec 11, 2024 •
edited
Loading

🤖 Wed Dec 11 21:06:14 - Prow CI generated the docs preview:

https://86109--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-17-release-notes.html

@obrown1205
Copy link
Contributor Author

/label peer-review-needed

@openshift-ci openshift-ci bot added the peer-review-needed Signifies that the peer review team needs to review this PR label Dec 11, 2024
@openshift-ci-robot
Copy link

openshift-ci-robot commented Dec 11, 2024 •
edited by openshift-ci bot
Loading

@obrown1205: This pull request references OSDOCS-12853 which is a valid jira issue.

In response to this:

Version(s):
4.17

Issue:
https://github.com/obrown1205/openshift-docs/pull/new/OSDOCS-12853

Link to docs preview:
https://86109--ocpdocs-pr.netlify.app/openshift-enterprise/latest/release_notes/ocp-4-17-release-notes.html#ocp-4-17-8_release-notes

QE review:
N/A

Additional information:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@lahinson lahinson added the peer-review-in-progress Signifies that the peer review team is reviewing this PR label Dec 11, 2024
lahinson
lahinson reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! Just a couple of suggestions for your consideration.

release_notes/ocp-4-17-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-17-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-17-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-17-release-notes.adoc Outdated Show resolved Hide resolved
release_notes/ocp-4-17-release-notes.adoc Outdated Show resolved Hide resolved
@lahinson lahinson added peer-review-done Signifies that the peer review team has reviewed this PR and removed peer-review-in-progress Signifies that the peer review team is reviewing this PR peer-review-needed Signifies that the peer review team needs to review this PR labels Dec 11, 2024
@openshift-ci OpenShift CI
Copy link

openshift-ci bot commented Dec 11, 2024

@obrown1205: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@obrown1205
Copy link
Contributor Author

/label merge-review-needed

@openshift-ci openshift-ci bot added the merge-review-needed Signifies that the merge review team needs to review this PR label Dec 11, 2024
@lahinson lahinson added the merge-review-in-progress Signifies that the merge review team is reviewing this PR label Dec 11, 2024
lahinson
lahinson reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@lahinson lahinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM to merge

@lahinson lahinson merged commit 1a46438 into openshift:enterprise-4.17 Dec 11, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lahinson lahinson lahinson left review comments

Assignees
No one assigned
Labels
jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. merge-review-in-progress Signifies that the merge review team is reviewing this PR merge-review-needed Signifies that the merge review team needs to review this PR peer-review-done Signifies that the peer review team has reviewed this PR size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@obrown1205 @openshift-ci-robot @ocpdocs-previewbot @lahinson