OCPCLOUD-2747: Merge https://github.com/kubernetes-sigs/cluster-api-provider-ibmcloud:v0.9.0-beta.1 (9b07704) into main

[cloud-team-rebase-bot]

No description provided.

[damdo]

/hold

For manual e2e testing from @Karthik-K-N

[damdo]

/lgtm

[Karthik-K-N]

Testing updates

Uncovered couple of bugs during testing and submitted a fix upstream.
kubernetes-sigs/cluster-api-provider-ibmcloud#2037
kubernetes-sigs/cluster-api-provider-ibmcloud#2039

Also tested with the fix and e2e are passing as expected

  [SKIPPED] Skipping AWS E2E tests
  In [BeforeAll] at: /Users/karthikkn/openshift-workspace/cluster-capi-operator/e2e/aws_test.go:41 @ 11/06/24 11:00:24.285

  Full Stack Trace
    github.com/openshift/cluster-capi-operator/e2e.init.func1.1()
    	/Users/karthikkn/openshift-workspace/cluster-capi-operator/e2e/aws_test.go:41 +0x114
------------------------------

Ran 1 of 5 Specs in 1015.874 seconds
SUCCESS! -- 1 Passed | 0 Failed | 0 Pending | 4 Skipped
PASS

Ginkgo ran 1 suite in 17m3.001716667s
Test Suite Passed

[JoelSpeed]

@Karthik-K-N Thanks for testing and getting those fixes up, looks like one has now merged, the other needs a rebase. Keen to get this in soon so, @damdo can you keep an eye on those two upstream PRs and make sure we get this updated as soon as the second is in?

[damdo]

@JoelSpeed we are in close contact, @Karthik-K-N an I, I'm already keeping an eye on them.

[Karthik-K-N]

Both the Upstream PRs have been merged.

[damdo]

Thanks @Karthik-K-N I've updated this rebase PR adding upstream PRs 2037 and 2039

[openshift-ci]

@cloud-team-rebase-bot[bot]: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[damdo]

Based on CI results and manual e2e tests conducted by @Karthik-K-N
#92 (comment)

I'm happy to get this merged.

/approve
/lgtm
/unhold

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: damdo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [damdo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-bot]

[ART PR BUILD NOTIFIER]

Distgit: ose-ibmcloud-cluster-api-controllers
This PR has been included in build ose-ibmcloud-cluster-api-controllers-container-v4.18.0-202411071138.p0.gda36260.assembly.stream.el9.
All builds following this will include this PR.

[Karthik-K-N]

@damdo We would like to cherry-pick only this commit to 4.17, as its needed for hypershift to work. Can we do it or should I submit a separate PR to 4.17.

[damdo]

@Karthik-K-N Let's have a separate PR for that commit, as 0.9.0-beta.1 won't be aligned in terms of capi/k8s deps with 4.17

[Karthik-K-N]

@Karthik-K-N Let's have a separate PR for that commit, as 0.9.0-beta.1 won't be aligned in terms of capi/k8s deps with 4.17

Thank you will do.