Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint YAML #39

Merged
merged 3 commits into from
Sep 10, 2018
Merged

Lint YAML #39

merged 3 commits into from
Sep 10, 2018

Conversation

paulfantom
Copy link

@paulfantom paulfantom commented Sep 10, 2018

Make YAML linter happy

@openshift-ci-robot openshift-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 10, 2018
@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 10, 2018
@paulfantom paulfantom changed the title Lint code Lint YAML Sep 10, 2018
@enxebre
Copy link
Member

enxebre commented Sep 10, 2018

thanks! can you include commits for fixes for go-vet and go-lint?

@spangenberg
Copy link

/lgtm

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2018
@openshift-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: paulfantom, spangenberg

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [paulfantom,spangenberg]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@paulfantom
Copy link
Author

can you include commits for fixes for go-vet and go-lint

Depends if you want it done ASAP, or not? 😄

@openshift-ci-robot
Copy link

New changes are detected. LGTM label has been removed.

@openshift-ci-robot openshift-ci-robot removed the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2018
@paulfantom
Copy link
Author

Force merging this. More linting will happen after removal of cluster-controller, which will also affect CI config.

@paulfantom paulfantom merged commit 57db36f into master Sep 10, 2018
@paulfantom paulfantom deleted the lint branch September 10, 2018 12:31
@openshift-ci-robot
Copy link

@paulfantom: The following tests failed, say /retest to rerun them all:

Test name Commit Details Rerun command
ci/prow/go-vet e99c5d5 link /test go-vet
ci/prow/golint e99c5d5 link /test golint

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants