Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint YAML #39

Merged
merged 3 commits into from
Sep 10, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cloud/aws/actuators/machine/actuator.go
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ func (a *Actuator) removeStoppedMachine(machine *clusterv1.Machine, client awscl
return TerminateInstances(client, instances, mLog)
}

func buildEc2Filters(inputFilters []providerconfigv1.Filter) []*ec2.Filter{
func buildEc2Filters(inputFilters []providerconfigv1.Filter) []*ec2.Filter {
filters := make([]*ec2.Filter, len(inputFilters))
for i, f := range inputFilters {
values := make([]*string, len(f.Values))
Expand Down
2 changes: 1 addition & 1 deletion cloud/aws/actuators/machine/utils.go
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ func TerminateInstances(client awsclient.Client, instances []*ec2.Instance, mLog
return nil
}

// MachineConfigProviderFromClusterAPIMachineSpec gets the machine provider config MachineSetSpec from the
// MachineProviderFromClusterAPIMachineSpec gets the machine provider config MachineSetSpec from the
// specified cluster-api MachineSpec.
func MachineProviderConfigFromClusterAPIMachineSpec(ms *clusterv1.MachineSpec) (*providerconfigv1.AWSMachineProviderConfig, error) {
if ms.ProviderConfig.Value == nil {
Expand Down
6 changes: 3 additions & 3 deletions cmd/aws-actuator/main.go
Original file line number Diff line number Diff line change
Expand Up @@ -214,20 +214,20 @@ cat <<EOF > /etc/default/kubelet
KUBELET_KUBEADM_EXTRA_ARGS=--cgroup-driver=systemd
EOF

kubeadm join {{ .MasterIp }}:8443 --token 2iqzqm.85bs0x6miyx1nm7l --discovery-token-unsafe-skip-ca-verification
kubeadm join {{ .MasterIP }}:8443 --token 2iqzqm.85bs0x6miyx1nm7l --discovery-token-unsafe-skip-ca-verification

HEREDOC

bash /root/user-data.sh > /root/user-data.logs
`

type userDataParams struct {
MasterIp string
MasterIP string
}

func generateWorkerUserData(masterIp string, workerUserDataSecret *apiv1.Secret) (*apiv1.Secret, error) {
params := userDataParams{
MasterIp: masterIp,
MasterIP: masterIp,
}
t, err := template.New("workeruserdata").Parse(workerUserDataBlob)
if err != nil {
Expand Down
4 changes: 2 additions & 2 deletions examples/addons.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -10,5 +10,5 @@ metadata:
namespace: test
type: Opaque
data:
awsAccessKeyId:
awsSecretAccessKey:
awsAccessKeyId:
awsSecretAccessKey:
22 changes: 11 additions & 11 deletions examples/machine-set.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -50,16 +50,16 @@ spec:
id: openshift_master_launch_instances
keyName: libra
tags:
- name: openshift-node-group-config
value: node-config-master
- name: host-type
value: master
- name: sub-host-type
value: default
- name: openshift-node-group-config
value: node-config-master
- name: host-type
value: master
- name: sub-host-type
value: default
securityGroups:
- id: sg-00868b02fbe29de17
- id: sg-0a4658991dc5eb40a
- id: sg-009a70e28fa4ba84e
- id: sg-07323d56fb932c84c
- id: sg-08b1ffd32874d59a2
- id: sg-00868b02fbe29de17
- id: sg-0a4658991dc5eb40a
- id: sg-009a70e28fa4ba84e
- id: sg-07323d56fb932c84c
- id: sg-08b1ffd32874d59a2
publicIP: true
12 changes: 6 additions & 6 deletions examples/machine-with-filters.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,13 @@ spec:
id: meh-master-profile
keyName: tectonic
tags:
- name: "kubernetes.io/cluster/meh"
value: owned
- name: "kubernetes.io/cluster/meh"
value: owned
securityGroups:
- filters:
- name: "tag:Name"
values:
- "meh_worker_sg"
- filters:
- name: "tag:Name"
values:
- "meh_worker_sg"
userDataSecret:
name: ignition-worker
versions:
Expand Down
22 changes: 11 additions & 11 deletions examples/machine-with-user-data.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,18 @@ spec:
id: openshift_master_launch_instances
keyName: libra
tags:
- name: openshift-node-group-config
value: node-config-master
- name: host-type
value: master
- name: sub-host-type
value: default
- name: openshift-node-group-config
value: node-config-master
- name: host-type
value: master
- name: sub-host-type
value: default
securityGroups:
- id: sg-00868b02fbe29de17
- id: sg-0a4658991dc5eb40a
- id: sg-009a70e28fa4ba84e
- id: sg-07323d56fb932c84c
- id: sg-08b1ffd32874d59a2
- id: sg-00868b02fbe29de17
- id: sg-0a4658991dc5eb40a
- id: sg-009a70e28fa4ba84e
- id: sg-07323d56fb932c84c
- id: sg-08b1ffd32874d59a2
publicIp: true
userDataSecret:
name: aws-actuator-user-data-secret
Expand Down
22 changes: 11 additions & 11 deletions examples/machine.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -38,18 +38,18 @@ spec:
id: openshift_master_launch_instances
keyName: libra
tags:
- name: openshift-node-group-config
value: node-config-master
- name: host-type
value: master
- name: sub-host-type
value: default
- name: openshift-node-group-config
value: node-config-master
- name: host-type
value: master
- name: sub-host-type
value: default
securityGroups:
- id: sg-00868b02fbe29de17
- id: sg-0a4658991dc5eb40a
- id: sg-009a70e28fa4ba84e
- id: sg-07323d56fb932c84c
- id: sg-08b1ffd32874d59a2
- id: sg-00868b02fbe29de17
- id: sg-0a4658991dc5eb40a
- id: sg-009a70e28fa4ba84e
- id: sg-07323d56fb932c84c
- id: sg-08b1ffd32874d59a2
publicIp: true
versions:
kubelet: 1.10.1
Expand Down
22 changes: 11 additions & 11 deletions examples/master-machine.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,18 @@ spec:
id: openshift_master_launch_instances
keyName: libra
tags:
- name: openshift-node-group-config
value: node-config-master
- name: host-type
value: master
- name: sub-host-type
value: default
- name: openshift-node-group-config
value: node-config-master
- name: host-type
value: master
- name: sub-host-type
value: default
securityGroups:
- id: sg-00868b02fbe29de17
- id: sg-0a4658991dc5eb40a
- id: sg-009a70e28fa4ba84e
- id: sg-07323d56fb932c84c
- id: sg-08b1ffd32874d59a2
- id: sg-00868b02fbe29de17
- id: sg-0a4658991dc5eb40a
- id: sg-009a70e28fa4ba84e
- id: sg-07323d56fb932c84c
- id: sg-08b1ffd32874d59a2
publicIp: true
userDataSecret:
name: aws-actuator-master-user-data-secret
Expand Down
34 changes: 17 additions & 17 deletions examples/provider-components.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,10 +28,10 @@ spec:
- name: controller-manager
image: gcr.io/k8s-cluster-api/controller-manager:0.0.7
volumeMounts:
- name: config
mountPath: /etc/kubernetes
- name: certs
mountPath: /etc/ssl/certs
- name: config
mountPath: /etc/kubernetes
- name: certs
mountPath: /etc/ssl/certs
command:
- "./controller-manager"
args:
Expand All @@ -46,22 +46,22 @@ spec:
- name: aws-machine-controller
image: gcr.io/k8s-cluster-api/aws-machine-controller:0.0.1
volumeMounts:
- name: config
mountPath: /etc/kubernetes
- name: certs
mountPath: /etc/ssl/certs
- name: kubeadm
mountPath: /usr/bin/kubeadm
- name: config
mountPath: /etc/kubernetes
- name: certs
mountPath: /etc/ssl/certs
- name: kubeadm
mountPath: /usr/bin/kubeadm
env:
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
- name: NODE_NAME
valueFrom:
fieldRef:
fieldPath: spec.nodeName
command:
- /machine-controller
- /machine-controller
args:
- --log-level=debug
- --kubeconfig=/etc/kubernetes/admin.conf
- --log-level=debug
- --kubeconfig=/etc/kubernetes/admin.conf
resources:
requests:
cpu: 100m
Expand Down
22 changes: 11 additions & 11 deletions examples/worker-machine.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -34,18 +34,18 @@ spec:
id: openshift_master_launch_instances
keyName: libra
tags:
- name: openshift-node-group-config
value: node-config-worker
- name: host-type
value: worker
- name: sub-host-type
value: default
- name: openshift-node-group-config
value: node-config-worker
- name: host-type
value: worker
- name: sub-host-type
value: default
securityGroups:
- id: sg-00868b02fbe29de17
- id: sg-0a4658991dc5eb40a
- id: sg-009a70e28fa4ba84e
- id: sg-07323d56fb932c84c
- id: sg-08b1ffd32874d59a2
- id: sg-00868b02fbe29de17
- id: sg-0a4658991dc5eb40a
- id: sg-009a70e28fa4ba84e
- id: sg-07323d56fb932c84c
- id: sg-08b1ffd32874d59a2
publicIp: true
userDataSecret:
name: aws-actuator-node-user-data-secret
Expand Down