Prep Dockerfile for building with ART tooling. #38
Conversation
Move Dockerfile to project root to accomodate tooling, needs to have source in build context. Make sure GOPATH is set, it may not be in some build images that get auto-replaced in for the FROM. Workaround a bug in some versions of imagebuilder where WORKDIR will not create the directory if it doesn't exist.
openshift-ci-robot
added
the
size/S
|
Is it used? As far as I could tell it isn't. If so we may have an issue, there may be some problems doing multiple images from one repo. We could comebine it into the other image though. |
|
We don't need cluster controller. |
|
And you won't need cluster-apiserver for long either when they go to CRDs. |
|
/retest |
|
About failing tests:
|
|
Aha, thanks @paulfantom . Do we just get the release PR merged first and then this one or do we need to force merge both due to the deps? |
|
We can merge release one first and then this one. I have also started fixing linter stuff in #39. |
|
/retest |
|
@dgoodwin: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
|
Image testing is OK. Everything LGTM. |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dgoodwin, paulfantom The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci-robot
added
the
approved
Move Dockerfile to project root to accomodate tooling, needs to have
source in build context.
Make sure GOPATH is set, it may not be in some build images that get
auto-replaced in for the FROM.
Workaround a bug in some versions of imagebuilder where WORKDIR will not
create the directory if it doesn't exist.
We can't yet test this but I spoke with lmeyer and he spotted a couple things that might be needed, so submitting a PR for those. Let me know if anything else needs to be updated, I may have missed other routes to the Dockerfile I'm not aware of.
CC @enxebre @paulfantom