Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change Dockerfile location #1417

Merged
merged 1 commit into from
Sep 10, 2018
Merged

Change Dockerfile location #1417

merged 1 commit into from
Sep 10, 2018

Conversation

paulfantom
Copy link
Contributor

/CC: @enxebre @dgoodwin

@openshift-ci-robot openshift-ci-robot added approved Indicates a PR has been approved by an approver from all required OWNERS files. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 10, 2018
@paulfantom paulfantom mentioned this pull request Sep 10, 2018
Merged
@dgoodwin
Copy link
Contributor

/lgtm

worth a shot.

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Sep 10, 2018
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dgoodwin, paulfantom

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit ada3bed into openshift:master Sep 10, 2018
@openshift-ci-robot
Copy link
Contributor

@paulfantom: Updated the ci-operator-openshift-cluster-api-provider-aws configmap using the following files:

  • key master.json using file ci-operator/config/openshift/cluster-api-provider-aws/master.json

In response to this:

/CC: @enxebre @dgoodwin

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@paulfantom
Copy link
Contributor Author

What?! But how?! 😄

@dgoodwin
Copy link
Contributor

LOL I really did not think that would work.

@paulfantom paulfantom deleted the patch-5 branch November 29, 2018 13:11
derekhiggins pushed a commit to derekhiggins/release that referenced this pull request Oct 24, 2023
@zaneb
AGENT-40: Use output kubeconfig to check for cluster complete (opensh…
7fcfa2c 
…ift#1417)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frobware frobware Awaiting requested review from frobware

@trawler trawler Awaiting requested review from trawler

Assignees

@dgoodwin dgoodwin

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulfantom @dgoodwin @openshift-ci-robot @openshift-merge-robot