Add VM_EXTRADISKS_LIST

[lranjbar]

Adding VM_EXTRADISKS_LIST to be able to control the names and number of disks created using this option.

• Add VM_EXTRADISKS_LIST as a variable
• Test adding VM_EXTRADISKS_SIZE as a variable
• Work through ci test errors

[openshift-ci-robot]

Hi @lranjbar. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[lranjbar]

Tested this change with dev-scripts in the lab and the second disk is showing now.

Here is what the volume pool looks like when putting in two disks:

 virsh vol-list oooq_pool
 Name                      Path
---------------------------------------------------------------------------
 ostest_master_0.qcow2     /home/dev-scripts/pool/ostest_master_0.qcow2
 ostest_master_0_vdb.img   /home/dev-scripts/pool/ostest_master_0_vdb.img
 ostest_master_0_vde.img   /home/dev-scripts/pool/ostest_master_0_vde.img
 ostest_master_1.qcow2     /home/dev-scripts/pool/ostest_master_1.qcow2
 ostest_master_1_vdb.img   /home/dev-scripts/pool/ostest_master_1_vdb.img
 ostest_master_1_vde.img   /home/dev-scripts/pool/ostest_master_1_vde.img
 ostest_master_2.qcow2     /home/dev-scripts/pool/ostest_master_2.qcow2
 ostest_master_2_vdb.img   /home/dev-scripts/pool/ostest_master_2_vdb.img
 ostest_master_2_vde.img   /home/dev-scripts/pool/ostest_master_2_vde.img
 ostest_worker_0.qcow2     /home/dev-scripts/pool/ostest_worker_0.qcow2
 ostest_worker_0_vdb.img   /home/dev-scripts/pool/ostest_worker_0_vdb.img
 ostest_worker_0_vde.img   /home/dev-scripts/pool/ostest_worker_0_vde.img
 ostest_worker_1.qcow2     /home/dev-scripts/pool/ostest_worker_1.qcow2
 ostest_worker_1_vdb.img   /home/dev-scripts/pool/ostest_worker_1_vdb.img
 ostest_worker_1_vde.img   /home/dev-scripts/pool/ostest_worker_1_vde.img
 ostest_worker_2.qcow2     /home/dev-scripts/pool/ostest_worker_2.qcow2
 ostest_worker_2_vdb.img   /home/dev-scripts/pool/ostest_worker_2_vdb.img
 ostest_worker_2_vde.img   /home/dev-scripts/pool/ostest_worker_2_vde.img

[lranjbar]

/ok-to-test

[openshift-ci-robot]

@lranjbar: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[stbenjam]

/ok-to-test
/approve

Do you maybe want to include the size option? There's also extradisks_size

[openshift-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: stbenjam

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [stbenjam]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[openshift-ci]

@lranjbar: The following tests failed, say /retest to rerun all failed tests:

Test name	Commit	Details	Rerun command
ci/prow/e2e-metal-ipi	2da7b6c	link	/test e2e-metal-ipi
ci/prow/e2e-metal-ipi-ovn-ipv6	2da7b6c	link	/test e2e-metal-ipi-ovn-ipv6

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[stbenjam]

Error looks related "stderr": "error: invalid argument: invalid path /opt/dev-scripts/pool/ostest_worker_1_.img not assigned to domain",�[0m

[hardys]

nit, this example looks odd, wouldn't you generally expect contiguous device names, e.g vdb vdc?

[lranjbar]

true, that will be better for an example. I sometimes flip "b" and "d" when I read these things 😅

[flaper87]

/close

@mkowalski took this commit and pushed it across

Awesome work, you both!

[openshift-ci]

@flaper87: Closed this PR.

In response to this:

/close

@mkowalski took this commit and pushed it across

Awesome work, you both!

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.