NO-ISSUE Extend BMAC documentation #1772
Conversation
This PR extends BMAC documentation to include all the steps required to create a fully functional assisted service deployment. It collects links to various CRDs described in this repository and outlines a step-by-step process of deploying them. Some additional debugging tips&tricks are added here&there.
There was a problem hiding this comment.
Love this docs, thank you!
I proposed a few things that we could change in dev-script directly. I think we should still keep all these docs as they are, even when the dev-script changes are applied.
(although, maybe the step related to the disks could be removed)
| ```bash | ||
| export CLUSTERNAME=ostest | ||
| export VMNAME=master_0 | ||
| export DISK=sdb | ||
|
|
||
| qemu-img create -f raw /home/dev-scripts/pool/${VMNAME}_manual_${DISK}.img 10G | ||
|
|
||
| virsh attach-disk ${CLUSTERNAME}_${VMNAME} \ | ||
| --source /home/dev-scripts/pool/${VMNAME}_manual_${DISK}.img \ | ||
| --target ${DISK} \ | ||
| --persistent | ||
| ``` |
There was a problem hiding this comment.
I have a small counter-proposal for this. What do you think about taking @lranjbar dev-script PR over so that we won't need to do this? openshift-metal3/dev-scripts#1230
| @@ -136,7 +188,7 @@ spec: | |||
| credentialsName: bmc-secret | |||
| ``` | |||
|
|
|||
| Setting `automatedCleaningMode` field and the `inspect.metal3.io` annotations are both optional. If | |||
| Setting `automatedCleaningMode` field and the `inspect.metal3.io` is optional. If | |||
There was a problem hiding this comment.
Along the lines of my previous comment, what do you think about having the assisted_deployment script in dev-script prepare/modify the BareMetalHost manifest for us (starting from the one created by dev-scripts)?
| Creating AgentClusterInstall, ClusterDeployment and InfraEnv resources | ||
| === | ||
|
|
||
| A number of resources has to be created in order to have the deployment fully ready for deploying OCP clusters. A typical workflow is as follows |
There was a problem hiding this comment.
| A number of resources has to be created in order to have the deployment fully ready for deploying OCP clusters. A typical workflow is as follows | |
| A number of resources have to be created in order to have the deployment fully ready for deploying OCP clusters. A typical workflow is as follows |
| * create the [PullSecret](crds/pullsecret.yaml) | ||
| * in order to create it directly from file you can use the following | ||
| ``` | ||
| kubectl create secret -n assisted-installer generic pull-secret --from-file=.dockerconfigjson=pull_secret.json |
There was a problem hiding this comment.
I think we can also have the assisted_deployment target take care of this :)
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: flaper87, mkowalski The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-ci
bot
added
lgtm
|
/retest |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
2 similar comments
|
/retest Please review the full test history for this PR and help us cut down flakes. |
|
/retest Please review the full test history for this PR and help us cut down flakes. |
This PR extends BMAC documentation to include all the steps required to
create a fully functional assisted service deployment. It collects links
to various CRDs described in this repository and outlines a step-by-step
process of deploying them.
Some additional debugging tips&tricks are added here&there.