NO-ISSUE Add VM_EXTRADISKS_LIST and VM_EXTRADISKS_SIZE

[mkowalski]

This PR adds the ability to configure VM_EXTRADISKS_LIST and
VM_EXTRADISKS_SIZE that are required by the Assisted Service
to deploy the Local Storage Operator.

Configuration of the extra disks is automatically picked by the script
so that storageClassDevices in the LocalVolume manifest is filled
correctly with all the additional drives and does not require a manual
modification.

Co-authored-by: Lisa Rashidi-Ranjbar [email protected]

[openshift-ci]

Hi @mkowalski. Thanks for your PR.

I'm waiting for a openshift-metal3 member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[mkowalski]

This PR supersedes #1230

[mkowalski]

/ok-to-test

[openshift-ci]

@mkowalski: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/ok-to-test

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hardys]

/ok-to-test

[hardys]

/cc @lranjbar @flaper87

[openshift-ci]

@hardys: GitHub didn't allow me to request PR reviews from the following users: lranjbar.

Note that only openshift-metal3 members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

/cc @lranjbar @flaper87

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[hardys]

/approve

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hardys

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [hardys]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[flaper87]

Thanks @lranjbar and @mkowalski for the work here!

/lgtm

[mkowalski]

/retest

[mkowalski]

CI error seems to be related to #1230 (comment)

[...]
"_raw_params": "dd if=/dev/zero of=/opt/dev-scripts/pool/ostest_master_0_.img bs=1 count=0 seek=\n",�[0m
[...]

which is generated by https://github.com/metal3-io/metal3-dev-env/blob/master/vm-setup/roles/libvirt/tasks/vm_setup_tasks.yml#L90

[djzager]

Nice work.

[mkowalski]

/retest

[flaper87]

/lgtm