[Spotless] Applying Google Code Format for core/src/main files #3 #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ensearch/sql/planner core/src/main/java/org/opensearch/sql/storage core/src/main/java/org/opensearch/sql/utils Signed-off-by: Mitchell Gale <[email protected]>
… fixes files. Signed-off-by: Mitchell Gale <[email protected]>
…ava OperatorUtils.java Planner.java Signed-off-by: Mitchell Gale <[email protected]>
…re tag. Signed-off-by: Mitchell Gale <[email protected]>
[Spotless] Applying Google Code Format for core/src/main files #3
MitchellGale
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vmmusings,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
6 tasks
Signed-off-by: Mitchell Gale <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #1932 +/- ##
============================================
- Coverage 97.51% 97.51% -0.01%
Complexity 4658 4658
============================================
Files 408 408
Lines 11934 11930 -4
Branches 834 832 -2
============================================
- Hits 11637 11633 -4
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
GumpacG
previously approved these changes
Aug 4, 2023
| private final Set<String> nameRemoveList; | ||
| @Getter private final PhysicalPlan input; | ||
| @Getter private final Set<ReferenceExpression> removeList; | ||
| @ToString.Exclude @EqualsAndHashCode.Exclude private final Set<String> nameRemoveList; |
There was a problem hiding this comment.
How come the multiple annotations are put on one line here while multiple annotations for the function above are left on multiple lines?
There was a problem hiding this comment.
You'll have to look at the rules, but I think the idea is that classes aren't indented so the annotations are put above, while functions and class variables are already indented, so it doesn't hurt to indent them more...?
There was a problem hiding this comment.
I agree, this becomes unreadable. Looking forward to have exceptions configured for that rule if possible.
acarbonetto
previously approved these changes
Aug 4, 2023
Yury-Fridlyand
previously approved these changes
Aug 5, 2023
core/src/main/java/org/opensearch/sql/planner/optimizer/rule/PushFilterUnderSort.java
Outdated
Show resolved
Hide resolved
core/src/main/java/org/opensearch/sql/planner/physical/NestedOperator.java
Show resolved
Hide resolved
| private final Set<String> nameRemoveList; | ||
| @Getter private final PhysicalPlan input; | ||
| @Getter private final Set<ReferenceExpression> removeList; | ||
| @ToString.Exclude @EqualsAndHashCode.Exclude private final Set<String> nameRemoveList; |
There was a problem hiding this comment.
I agree, this becomes unreadable. Looking forward to have exceptions configured for that rule if possible.
Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale
dismissed stale reviews from Yury-Fridlyand, acarbonetto, and GumpacG
via
2cd9f69
6 tasks
GumpacG
previously approved these changes
Aug 8, 2023
6 tasks
Yury-Fridlyand
previously approved these changes
Aug 8, 2023
Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale
dismissed stale reviews from Yury-Fridlyand and GumpacG
via
db31dcd
GumpacG
approved these changes
Aug 9, 2023
Yury-Fridlyand
approved these changes
Aug 9, 2023
6 tasks
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 14, 2023
…ensearch-project#1932) * Applying Google Java code format changes to core/src/main/java/org/opensearch/sql/planner core/src/main/java/org/opensearch/sql/storage core/src/main/java/org/opensearch/sql/utils Signed-off-by: Mitchell Gale <[email protected]> * Ignore on failure for checkstyle in core and added the three spotless fixes files. Signed-off-by: Mitchell Gale <[email protected]> * Fixed javadoc formatting in LogicalPlanOptimizer.java LogicalValues.java OperatorUtils.java Planner.java Signed-off-by: Mitchell Gale <[email protected]> * spotless apply, fixing include for spotless build.gradle and adding pre tag. Signed-off-by: Mitchell Gale <[email protected]> * addressed PR comments. Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Aug 18, 2023
…ensearch-project#1932) * Applying Google Java code format changes to core/src/main/java/org/opensearch/sql/planner core/src/main/java/org/opensearch/sql/storage core/src/main/java/org/opensearch/sql/utils Signed-off-by: Mitchell Gale <[email protected]> * Ignore on failure for checkstyle in core and added the three spotless fixes files. Signed-off-by: Mitchell Gale <[email protected]> * Fixed javadoc formatting in LogicalPlanOptimizer.java LogicalValues.java OperatorUtils.java Planner.java Signed-off-by: Mitchell Gale <[email protected]> * spotless apply, fixing include for spotless build.gradle and adding pre tag. Signed-off-by: Mitchell Gale <[email protected]> * addressed PR comments. Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
6 tasks
acarbonetto
pushed a commit
that referenced
this pull request
Aug 21, 2023
…in files #3 (#1932) (#1994) * [Spotless] Applying Google Code Format for core/src/main files #3 (#1932) * Applying Google Java code format changes to core/src/main/java/org/opensearch/sql/planner core/src/main/java/org/opensearch/sql/storage core/src/main/java/org/opensearch/sql/utils Signed-off-by: Mitchell Gale <[email protected]> * Ignore on failure for checkstyle in core and added the three spotless fixes files. Signed-off-by: Mitchell Gale <[email protected]> * Fixed javadoc formatting in LogicalPlanOptimizer.java LogicalValues.java OperatorUtils.java Planner.java Signed-off-by: Mitchell Gale <[email protected]> * spotless apply, fixing include for spotless build.gradle and adding pre tag. Signed-off-by: Mitchell Gale <[email protected]> * addressed PR comments. Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]> * spotless apply Signed-off-by: Mitchell Gale <[email protected]> * add checkstyle ignore Signed-off-by: Mitchell Gale <[email protected]> * addressed PR comments Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR applies Spotless on Java code for:
core/src/main/java/org/opensearch/sql/plannercore/src/main/java/org/opensearch/sql/storagecore/src/main/java/org/opensearch/sql/utilsIssues Resolved
#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.