[Spotless] Applying Google Code Format for core #5 #1942
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding core final GJF fix. Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz,
Yury-Fridlyand,
anirudha,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov Report
@@ Coverage Diff @@
## main #1942 +/- ##
============================================
+ Coverage 97.42% 97.51% +0.08%
- Complexity 4647 4658 +11
============================================
Files 408 408
Lines 11526 11932 +406
Branches 839 832 -7
============================================
+ Hits 11229 11635 +406
Misses 290 290
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
* Fixing strings change from main OS repo. Signed-off-by: Mitchell Gale <[email protected]> * Fixing issues. Signed-off-by: Mitchell Gale <[email protected]> * Fixing changed syntax to toStirng. Signed-off-by: Mitchell Gale <[email protected]> * Fixing changed syntax to toStirng. Signed-off-by: Mitchell Gale <[email protected]> * add tosttring fix to RestSQLQueryActionCursorFallbackTest Signed-off-by: Mitchell Gale <[email protected]> * added unused function Signed-off-by: Mitchell Gale <[email protected]> --------- Signed-off-by: Mitchell Gale <[email protected]>
GumpacG
reviewed
Aug 8, 2023
| * Agg(Alias("AVG(age)", aggExpr), Alias("length(name)", groupExpr)) | ||
| * | ||
| * <ol> | ||
| * <li>1. SELECT name, AVG(age) FROM s BY name -> Project(Alias("name", expr), Alias("AVG(age)", |
There was a problem hiding this comment.
Thanks, fixed in #1930.
| * WHEN search_condition THEN result_expr | ||
| * [WHEN search_condition THEN result_expr] ... | ||
| * [ELSE result_expr] | ||
| * CASE<br> |
There was a problem hiding this comment.
Why not just use <pre> here similar to line 263 below?
There was a problem hiding this comment.
Replaced with pre in #1930.
| * <li>Define a public no-arg constructor. | ||
| * </ul> | ||
| * <li>Overwrite {@link #getPlanForSerialization} to return another instance of {@link | ||
| * SerializablePlan}. |
|
Why? |
|
Superseded by #1951 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Based off #1930, #1931. #1932. #1933 and applies spotless to entire
coreproject. Covers remaining fixes not covered by PR 1-4.NOTE: should be reviewed after PRs spotless 1-4 PRs are approved.
#1930
#1931
#1932
#1933
Issues Resolved
#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.