[Spotless] Applying Google Code Format for core #5 #324
Conversation
Signed-off-by: Mitchell Gale <[email protected]>
MitchellGale
requested review from
MaxKsyunz,
Yury-Fridlyand,
forestmvey,
acarbonetto and
GumpacG
as code owners
Codecov Report
@@ Coverage Diff @@
## integ/sl_GoogleJavaFormat5 #324 +/- ##
=============================================================
Coverage ? 97.51%
Complexity ? 4658
=============================================================
Files ? 408
Lines ? 11932
Branches ? 832
=============================================================
Hits ? 11635
Misses ? 290
Partials ? 7
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Please disable checkstyle |
Signed-off-by: Mitchell Gale <[email protected]>
Thank you! set to false. |
core/src/test/java/org/opensearch/sql/expression/ReferenceExpressionTest.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mitchell Gale <[email protected]>
| "ValuesOperator", | ||
| Map.of("values", List.of(values)), | ||
| emptyList())))))))))))), | ||
| explain.apply(plan)); |
core/src/test/java/org/opensearch/sql/expression/ReferenceExpressionTest.java
Show resolved
Hide resolved
| "array_value", ImmutableList.of(1, 2)))); | ||
| ExprValueUtils.tupleValue( | ||
| ImmutableMap.of( | ||
| "integer_value", |
| ImmutableList.of( | ||
| "%H", | ||
| "%I", "%k", "%l", "%i", "%p", "%r", "%S", "%T", " %M", "%W", "%D", "%Y", "%y", | ||
| "%a", "%b", "%j", "%m", "%d", "%h", "%s", "%w", "%f", "%q", "%"), | ||
| ImmutableList.of( |
There was a problem hiding this comment.
Any idea why these lists formatted in different styles?
There was a problem hiding this comment.
No idea.... did some experimenting and it's not which of the imutables come first, or the fact they all have % in the first one.... 🤔
There was a problem hiding this comment.
It's got something to do with 100 character line limits.... but unsure what is up.
core/src/test/java/org/opensearch/sql/planner/logical/LogicalPlanNodeVisitorTest.java
Show resolved
Hide resolved
MitchellGale
merged commit 8638f92
into
integ/sl_GoogleJavaFormat5
Description
Based off opensearch-project#1930, opensearch-project#1931. opensearch-project#1932. opensearch-project#1933 and applies spotless to entire
coreproject. Covers remaining fixes not covered by PR 1-4.Issues Resolved
opensearch-project#1101
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.