-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nested Documentation for 2.7 Related Features #1620
Merged
penghuo
merged 6 commits into
opensearch-project:main
from
Bit-Quill:integ-nested-select-doc
May 23, 2023
Merged
Add Nested Documentation for 2.7 Related Features #1620
penghuo
merged 6 commits into
opensearch-project:main
from
Bit-Quill:integ-nested-select-doc
May 23, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ific documentation. Signed-off-by: forestmvey <[email protected]>
… comments and adding table of contents. Signed-off-by: forestmvey <[email protected]>
…tion for examples, and used a better example to describe response flattening and cross join. Signed-off-by: forestmvey <[email protected]>
…uery examples, minor clarifications on descriptions. Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
Add `Nested` Documentation for 2.7 Related Features
forestmvey
requested review from
pjfitzgibbons,
ps48,
kavithacm,
derek-ho,
joshuali925,
dai-chen,
YANG-DB,
rupal-bq,
mengweieric,
vamsi-amazon,
Swiddis,
penghuo,
seankao-az,
MaxKsyunz and
Yury-Fridlyand
as code owners
May 9, 2023 21:57
matthewryanwells
approved these changes
May 9, 2023
Yury-Fridlyand
added
documentation
Improvements or additions to documentation
backport 2.x
labels
May 10, 2023
Yury-Fridlyand
approved these changes
May 10, 2023
MaxKsyunz
approved these changes
May 10, 2023
The backport to
To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1620-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 83ad16603337208f4ee1edd623d94034dfd7ccb7
# Push it to GitHub
git push --set-upstream origin backport/backport-1620-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x Then, create a pull request where the |
forestmvey
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
May 23, 2023
…#1620) * Initial commit for adding nested documentation and select clause specific documentation. Signed-off-by: forestmvey <[email protected]> * Adding priorities, additional examples, cleaning up diagrams based on comments and adding table of contents. Signed-off-by: forestmvey <[email protected]> * Fixing using complete class names for state diagrams, added clarification for examples, and used a better example to describe response flattening and cross join. Signed-off-by: forestmvey <[email protected]> * Removing release schedule, removing unnecessary portions to DSL for query examples, minor clarifications on descriptions. Signed-off-by: forestmvey <[email protected]> * Cleaning up Class diagram. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> (cherry picked from commit 83ad166)
6 tasks
forestmvey
added a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
May 24, 2023
…#1620) * Initial commit for adding nested documentation and select clause specific documentation. Signed-off-by: forestmvey <[email protected]> * Adding priorities, additional examples, cleaning up diagrams based on comments and adding table of contents. Signed-off-by: forestmvey <[email protected]> * Fixing using complete class names for state diagrams, added clarification for examples, and used a better example to describe response flattening and cross join. Signed-off-by: forestmvey <[email protected]> * Removing release schedule, removing unnecessary portions to DSL for query examples, minor clarifications on descriptions. Signed-off-by: forestmvey <[email protected]> * Cleaning up Class diagram. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> (cherry picked from commit 83ad166)
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
…#1620) * Initial commit for adding nested documentation and select clause specific documentation. Signed-off-by: forestmvey <[email protected]> * Adding priorities, additional examples, cleaning up diagrams based on comments and adding table of contents. Signed-off-by: forestmvey <[email protected]> * Fixing using complete class names for state diagrams, added clarification for examples, and used a better example to describe response flattening and cross join. Signed-off-by: forestmvey <[email protected]> * Removing release schedule, removing unnecessary portions to DSL for query examples, minor clarifications on descriptions. Signed-off-by: forestmvey <[email protected]> * Cleaning up Class diagram. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]>
MitchellGale
pushed a commit
to Bit-Quill/opensearch-project-sql
that referenced
this pull request
Jun 12, 2023
…#1620) * Initial commit for adding nested documentation and select clause specific documentation. Signed-off-by: forestmvey <[email protected]> * Adding priorities, additional examples, cleaning up diagrams based on comments and adding table of contents. Signed-off-by: forestmvey <[email protected]> * Fixing using complete class names for state diagrams, added clarification for examples, and used a better example to describe response flattening and cross join. Signed-off-by: forestmvey <[email protected]> * Removing release schedule, removing unnecessary portions to DSL for query examples, minor clarifications on descriptions. Signed-off-by: forestmvey <[email protected]> * Cleaning up Class diagram. Signed-off-by: forestmvey <[email protected]> --------- Signed-off-by: forestmvey <[email protected]> Signed-off-by: Mitchell Gale <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added documentation for architectural changes from PR-1490. The added features covers the
nested
function used in theSELECT
clause of an SQL statement. Future work has placeholders in documentation and can be added to with proposals as development continues.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.