-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Nested
Documentation for 2.7 Related Features
#262
Conversation
Codecov Report
@@ Coverage Diff @@
## integ-nested-select-doc #262 +/- ##
==========================================================
Coverage 97.16% 97.16%
Complexity 4120 4120
==========================================================
Files 371 371
Lines 10373 10373
Branches 704 704
==========================================================
Hits 10079 10079
Misses 287 287
Partials 7 7
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Not sure if it's appropriate in these docs but maybe add a simple example of mapping, data, and expected result of a simple query for devs in the future who don't have knowledge of nested in OpenSearch. May be appropriate in the use case section.
Good idea! |
|
Thanks, I have added the files I added to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Please address comments.
…ific documentation. Signed-off-by: forestmvey <[email protected]>
… comments and adding table of contents. Signed-off-by: forestmvey <[email protected]>
…tion for examples, and used a better example to describe response flattening and cross join. Signed-off-by: forestmvey <[email protected]>
…uery examples, minor clarifications on descriptions. Signed-off-by: forestmvey <[email protected]>
Signed-off-by: forestmvey <[email protected]>
3a010df
to
b8732df
Compare
Description
Added documentation for architectural changes from PR-1490. The added features covers the
nested
function used in theSELECT
clause of an SQL statement. Future work has placeholders in documentation and can be added to with proposals as development continues.Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.