Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport/backport 1620 to 2.x #1652

Merged

Conversation

forestmvey
Copy link
Collaborator

Description

(cherry picked from commit 83ad16603337208f4ee1edd623d94034dfd7ccb7

Backport from 1620

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

…#1620)

* Initial commit for adding nested documentation and select clause specific documentation.

Signed-off-by: forestmvey <[email protected]>

* Adding priorities, additional examples, cleaning up diagrams based on comments and adding table of contents.

Signed-off-by: forestmvey <[email protected]>

* Fixing using complete class names for state diagrams, added clarification for examples, and used a better example to describe response flattening and cross join.

Signed-off-by: forestmvey <[email protected]>

* Removing release schedule, removing unnecessary portions to DSL for query examples, minor clarifications on descriptions.

Signed-off-by: forestmvey <[email protected]>

* Cleaning up Class diagram.

Signed-off-by: forestmvey <[email protected]>

---------

Signed-off-by: forestmvey <[email protected]>
(cherry picked from commit 83ad166)
@forestmvey forestmvey force-pushed the backport/backport-1620-to-2.x branch from 0d0b357 to 4c71f03 Compare May 24, 2023 03:46
@codecov
Copy link

codecov bot commented May 24, 2023

Codecov Report

Merging #1652 (4c71f03) into 2.x (489364a) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                2.x    #1652   +/-   ##
=========================================
  Coverage     97.16%   97.16%           
  Complexity     4122     4122           
=========================================
  Files           371      371           
  Lines         10375    10375           
  Branches        704      704           
=========================================
  Hits          10081    10081           
  Misses          287      287           
  Partials          7        7           
Flag Coverage Δ
sql-engine 97.16% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@forestmvey forestmvey merged commit 5e884c7 into opensearch-project:2.x May 24, 2023
@forestmvey forestmvey deleted the backport/backport-1620-to-2.x branch May 24, 2023 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants