Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 2.x to Maximus feature branch #1062

Conversation

dai-chen
Copy link
Collaborator

@dai-chen dai-chen commented Nov 9, 2022

Description

We have synced 2.x and Maximus feature branch on a weekly basis. This PR has shorter interval because Jackson version bump change is required for CI build.

Issues Resolved

N/A

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Yury-Fridlyand and others added 10 commits November 7, 2022 08:38
…earch-project#1037)

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit 4a9cef3)

Co-authored-by: vamsi-amazon <[email protected]>
…pensearch-project#1010)

This maintains backwards compatibility with the v1 engine.
…nsearch-project#991)

Add option to accept datetime like string in both TIME and DATE (eg. accept "1999-01-02 12:12:12" for both TIME and DATE.

Strict check on date for testing for valid dates (eg. Don't accept Feb 30th as a valid date) and throws a SemanticCheckException.

Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: MitchellGale-BitQuill <[email protected]>
Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit d3bb902)

Co-authored-by: vamsi-amazon <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 5a1adb2)
…ckport/backport-1058-to-2.x

[Backport 2.x] [2.4] Bump jackson to 2.14.0
@dai-chen dai-chen self-assigned this Nov 9, 2022
@codecov-commenter
Copy link

codecov-commenter commented Nov 9, 2022

Codecov Report

Merging #1062 (d9d5336) into feature/maximus-m1 (5105022) will decrease coverage by 2.53%.
The diff coverage is 100.00%.

@@                   Coverage Diff                    @@
##             feature/maximus-m1    #1062      +/-   ##
========================================================
- Coverage                 98.26%   95.72%   -2.54%     
- Complexity                 3398     3423      +25     
========================================================
  Files                       339      352      +13     
  Lines                      8451     9167     +716     
  Branches                    542      661     +119     
========================================================
+ Hits                       8304     8775     +471     
- Misses                      142      334     +192     
- Partials                      5       58      +53     
Flag Coverage Δ
query-workbench 62.76% <ø> (?)
sql-engine 98.27% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <ø> (ø)
...rch/sql/planner/physical/catalog/CatalogTable.java 100.00% <ø> (ø)
...arch/storage/script/filter/FilterQueryBuilder.java 100.00% <ø> (ø)
...us/storage/model/PrometheusResponseFieldNames.java 100.00% <ø> (ø)
...rg/opensearch/sql/analysis/ExpressionAnalyzer.java 100.00% <100.00%> (ø)
...a/org/opensearch/sql/data/model/ExprDateValue.java 100.00% <100.00%> (ø)
...a/org/opensearch/sql/data/model/ExprTimeValue.java 100.00% <100.00%> (ø)
...c/main/java/org/opensearch/sql/expression/DSL.java 100.00% <100.00%> (ø)
...java/org/opensearch/sql/expression/Expression.java 100.00% <100.00%> (ø)
...rch/sql/expression/aggregation/TakeAggregator.java 100.00% <100.00%> (ø)
... and 36 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@dai-chen dai-chen marked this pull request as ready for review November 9, 2022 20:16
@dai-chen dai-chen requested a review from a team as a code owner November 9, 2022 20:16
@dai-chen dai-chen merged commit 3c6b37a into opensearch-project:feature/maximus-m1 Nov 9, 2022
@dai-chen dai-chen deleted the maximus-m1/merge-jackson-version-changes branch December 16, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants