-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Query Function As Alternate Syntax to Query_string Function #1010
Add Query Function As Alternate Syntax to Query_string Function #1010
Conversation
Signed-off-by: GabeFernandez310 <[email protected]>
Added Query Function As Query_string Function
.../java/org/opensearch/sql/opensearch/storage/script/filter/lucene/relevance/NoFieldQuery.java
Show resolved
Hide resolved
...in/java/org/opensearch/sql/opensearch/storage/script/filter/lucene/relevance/QueryQuery.java
Outdated
Show resolved
Hide resolved
Signed-off-by: GabeFernandez310 <[email protected]>
Codecov Report
@@ Coverage Diff @@
## 2.x #1010 +/- ##
============================================
- Coverage 98.22% 95.60% -2.62%
- Complexity 3272 3290 +18
============================================
Files 314 326 +12
Lines 8205 8904 +699
Branches 535 654 +119
============================================
+ Hits 8059 8513 +454
- Misses 142 334 +192
- Partials 4 57 +53
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
.../java/org/opensearch/sql/opensearch/storage/script/filter/lucene/relevance/NoFieldQuery.java
Show resolved
Hide resolved
...in/java/org/opensearch/sql/opensearch/storage/script/filter/lucene/relevance/QueryQuery.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the changes!
* Fix `FLOAT` -> `DOUBLE` cast. (#1025) Signed-off-by: Yury-Fridlyand <[email protected]> * Fix error messaging from prometheus. (#1029) (#1037) Signed-off-by: vamsi-amazon <[email protected]> (cherry picked from commit 4a9cef3) Co-authored-by: vamsi-amazon <[email protected]> * Add `query` function as alternate syntax to `query_string` function (#1010) This maintains backwards compatibility with the v1 engine. * Update DATE and TIME functions to parse string input as datetime (#991) Add option to accept datetime like string in both TIME and DATE (eg. accept "1999-01-02 12:12:12" for both TIME and DATE. Strict check on date for testing for valid dates (eg. Don't accept Feb 30th as a valid date) and throws a SemanticCheckException. Co-authored-by: Yury-Fridlyand <[email protected]> Signed-off-by: MitchellGale-BitQuill <[email protected]> * back quote fix (#1041) (#1050) Signed-off-by: vamsi-amazon <[email protected]> (cherry picked from commit d3bb902) Co-authored-by: vamsi-amazon <[email protected]> * Catalog to Datasource changes (#1027) (#1049) Signed-off-by: vamsi-amazon <[email protected]> (cherry picked from commit 3e30379) * Bump jackson to 2.14.0 (#1058) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 5a1adb2) * Add valueOf() to Expression (#1055) Signed-off-by: Joshua Li <[email protected]> Signed-off-by: Yury-Fridlyand <[email protected]> Signed-off-by: MitchellGale-BitQuill <[email protected]> Signed-off-by: Joshua Li <[email protected]> Signed-off-by: Chen Dai <[email protected]> Co-authored-by: Yury-Fridlyand <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: vamsi-amazon <[email protected]> Co-authored-by: GabeFernandez310 <[email protected]> Co-authored-by: MitchellGale-BitQuill <[email protected]> Co-authored-by: Joshua Li <[email protected]>
Description
Query function was added to SQL plugin as alternate syntax to query_string Function. Achieved by routing function calls from the SQL plugin to the query_string function which currently exists in OpenSearch.
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.