Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] Fix for errors in prometheus connector when backquotes are used for fieldnames in aggregations. #1050

Merged
merged 1 commit into from
Nov 8, 2022

Conversation

opensearch-trigger-bot[bot]
Copy link
Contributor

Backport d3bb902 from #1041

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit d3bb902)
@opensearch-trigger-bot opensearch-trigger-bot bot requested a review from a team as a code owner November 8, 2022 22:47
@codecov-commenter
Copy link

codecov-commenter commented Nov 8, 2022

Codecov Report

Merging #1050 (d3bb902) into 2.x (8c91689) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head d3bb902 differs from pull request most recent head 75229e0. Consider uploading reports for the commit 75229e0 to get more accurate results

@@             Coverage Diff              @@
##                2.x    #1050      +/-   ##
============================================
- Coverage     98.27%   98.26%   -0.01%     
+ Complexity     3344     3332      -12     
============================================
  Files           326      324       -2     
  Lines          8443     8413      -30     
  Branches        553      553              
============================================
- Hits           8297     8267      -30     
  Misses          142      142              
  Partials          4        4              
Flag Coverage Δ
sql-engine 98.26% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...arch/sql/expression/datetime/DateTimeFunction.java 100.00% <ø> (ø)
...rch/sql/planner/physical/catalog/CatalogTable.java 100.00% <ø> (ø)
...a/org/opensearch/sql/utils/MLCommonsConstants.java 0.00% <ø> (ø)
...ensearch/sql/ppl/utils/PPLQueryDataAnonymizer.java 100.00% <ø> (ø)
...metheus/storage/PrometheusMetricDefaultSchema.java 100.00% <ø> (ø)
...ain/java/org/opensearch/sql/analysis/Analyzer.java 100.00% <100.00%> (ø)
...a/org/opensearch/sql/analysis/TypeEnvironment.java 100.00% <100.00%> (ø)
.../org/opensearch/sql/planner/logical/LogicalML.java 100.00% <100.00%> (ø)
...ch/sql/planner/logical/LogicalPlanNodeVisitor.java 100.00% <100.00%> (ø)
.../sql/planner/physical/PhysicalPlanNodeVisitor.java 100.00% <100.00%> (ø)
... and 80 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@vmmusings vmmusings merged commit 2ec975a into 2.x Nov 8, 2022
@github-actions github-actions bot deleted the backport/backport-1041-to-2.x branch November 8, 2022 23:13
dai-chen added a commit that referenced this pull request Nov 9, 2022
* Fix `FLOAT` -> `DOUBLE` cast. (#1025)

Signed-off-by: Yury-Fridlyand <[email protected]>

* Fix error messaging from prometheus. (#1029) (#1037)

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit 4a9cef3)

Co-authored-by: vamsi-amazon <[email protected]>

* Add `query` function as alternate syntax to `query_string` function (#1010)

This maintains backwards compatibility with the v1 engine.

* Update DATE and TIME functions to parse string input as datetime (#991)

Add option to accept datetime like string in both TIME and DATE (eg. accept "1999-01-02 12:12:12" for both TIME and DATE.

Strict check on date for testing for valid dates (eg. Don't accept Feb 30th as a valid date) and throws a SemanticCheckException.

Co-authored-by: Yury-Fridlyand <[email protected]>
Signed-off-by: MitchellGale-BitQuill <[email protected]>

* back quote fix (#1041) (#1050)

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit d3bb902)

Co-authored-by: vamsi-amazon <[email protected]>

* Catalog to Datasource changes (#1027) (#1049)

Signed-off-by: vamsi-amazon <[email protected]>
(cherry picked from commit 3e30379)

* Bump jackson to 2.14.0 (#1058)

Signed-off-by: Joshua Li <[email protected]>
(cherry picked from commit 5a1adb2)

* Add valueOf() to Expression (#1055)

Signed-off-by: Joshua Li <[email protected]>

Signed-off-by: Yury-Fridlyand <[email protected]>
Signed-off-by: MitchellGale-BitQuill <[email protected]>
Signed-off-by: Joshua Li <[email protected]>
Signed-off-by: Chen Dai <[email protected]>
Co-authored-by: Yury-Fridlyand <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: vamsi-amazon <[email protected]>
Co-authored-by: GabeFernandez310 <[email protected]>
Co-authored-by: MitchellGale-BitQuill <[email protected]>
Co-authored-by: Joshua Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants