Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maven wrapper plugin for encapsulated build setup #1414

Closed
wants to merge 1 commit into from
Closed

Add maven wrapper plugin for encapsulated build setup #1414

wants to merge 1 commit into from

Conversation

adnapibar
Copy link

@adnapibar adnapibar commented Aug 20, 2021

opensearch-security pull request intake form

Please provide as much details as possible to get feedback/acceptance on your PR quickly

  1. Category: (Enhancement, New feature, Bug fix, Test fix, Refactoring, Maintenance, Documentation)

Enhancement

  1. Github Issue # or road-map entry, if available:

Resolves #1413

  1. Description of changes:

Adds the maven wrapper plugin which enables users to have a fully encapsulated build setup provided by the project. More details on the linked issue.

  1. Why these changes are required?

For easier build setup

  1. What is the old behavior before changes and new behavior after changes? (Please add any example/logs/screen-shot if available)

Users have to install and manage different versions of maven as enforced by projects

  1. Testing done: (Please provide details of testing done: Unit testing, integration testing and manual testing)

Run the build locally

  1. TO-DOs, if any: (Please describe pending items and provide Github issues# for each of them)

N/A

  1. Is it backport from main branch? (If yes, please add backport PR # and commits #)

No

By making a contribution to this project, I certify that:

(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Rabi Panda [email protected]

This enables users to have a fully encapsulated build setup provided by the project.

Signed-off-by: Rabi Panda <[email protected]>
@adnapibar adnapibar requested a review from a team August 20, 2021 19:18
@codecov-commenter
Copy link

Codecov Report

Merging #1414 (954f281) into main (a08555f) will decrease coverage by 0.04%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##               main    #1414      +/-   ##
============================================
- Coverage     64.81%   64.77%   -0.05%     
  Complexity     3202     3202              
============================================
  Files           247      247              
  Lines         17243    17243              
  Branches       3050     3050              
============================================
- Hits          11176    11169       -7     
- Misses         4517     4524       +7     
  Partials       1550     1550              
Impacted Files Coverage Δ
...org/opensearch/security/rest/TenantInfoAction.java 77.94% <0.00%> (-10.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e98b141...954f281. Read the comment docs.

Copy link
Contributor

@vrozov vrozov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See discussion in #1413.

@adnapibar adnapibar closed this Jan 8, 2022
gaobinlong pushed a commit to gaobinlong/security that referenced this pull request Aug 30, 2023
Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>
gaobinlong pushed a commit to gaobinlong/security that referenced this pull request Aug 30, 2023
…ect#1450)

* Replace legacy template with index template (opensearch-project#1359)

Signed-off-by: Chang Liu <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* added loginEndPointWithPath (opensearch-project#1358)

* added loginEndPointWithPath
Signed-off-by: Mattijs Vanhaverbeke <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Add release notes for 1.3.9 (opensearch-project#1379)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* No blank backend role before adding a new one in Create User page (opensearch-project#1384)

* Add last backend role empty check

Signed-off-by: nursaadat <[email protected]>
Signed-off-by: Saadat Nursultan <[email protected]>

* Add backend role empty check

Signed-off-by: nursaadat <[email protected]>
Signed-off-by: Saadat Nursultan <[email protected]>

* Add strict comparison

Signed-off-by: nursaadat <[email protected]>
Signed-off-by: Saadat Nursultan <[email protected]>

* Fix lint errors

Signed-off-by: nursaadat <[email protected]>
Signed-off-by: Saadat Nursultan <[email protected]>

* Add tests for backend role panel

Signed-off-by: Saadat Nursultan <[email protected]>

* Fix lint errors

Signed-off-by: Saadat Nursultan <[email protected]>

---------

Signed-off-by: nursaadat <[email protected]>
Signed-off-by: Saadat Nursultan <[email protected]>
Co-authored-by: nursaadat <[email protected]>
Co-authored-by: Saadat Nursultan <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Fix script for Windows (opensearch-project#1393)

* Fix script for Windows

Signed-off-by: nurbqq <[email protected]>
Signed-off-by: nurbqq <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding new actions for ppl and datasource apis (opensearch-project#1395)

* Adding new actions for ppl and datasource apis

Signed-off-by: vamsi-amazon <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Fix "Get started" image is not adaptive to the browser window size. (opensearch-project#1396)

* Fixed get-started page image not adapting to the browser window size

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Update fix by applying suggested changes

Signed-off-by: Sirazh Gabdullin <[email protected]>

* Update unit tests snapshot

Signed-off-by: Sirazh Gabdullin <[email protected]>

---------

Signed-off-by: Sirazh Gabdullin <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Split up a value into multiple cookie payloads (opensearch-project#1352)

* PoC for splitting up a value into multiple cookie payloads

Signed-off-by: Jochen Kressin <[email protected]>

* Cookie splitting for OpenId and SAML

Signed-off-by: Jochen Kressin <[email protected]>

* Changes after review comments

Signed-off-by: Jochen Kressin <[email protected]>

* WIP: First unit tests

Signed-off-by: Jochen Kressin <[email protected]>

* More unit tests

Signed-off-by: Jochen Kressin <[email protected]>

* Fix for multi auth, request argument was missing

Signed-off-by: Jochen Kressin <[email protected]>

* Fixed linting errors

Signed-off-by: Jochen Kressin <[email protected]>

* Added one additional cookie for the SAML integration tests

Signed-off-by: Jochen Kressin <[email protected]>

---------

Signed-off-by: Jochen Kressin <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Dynamic tenancy configurations (opensearch-project#1394)

* Dynamic multitenancy feature.

Signed-off-by: Abhi Kalra <[email protected]>

* Dynamic multitenancy feature -PR feedback

Signed-off-by: Abhi Kalra <[email protected]>

---------

Signed-off-by: Abhi Kalra <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Add release notes for 2.7.0 (opensearch-project#1407)

* Add release notes for 2.7.0

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removes tiny.amazon.com links (opensearch-project#1420)

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Fixing dynamic tenancy changes for issues 1412 (opensearch-project#1419)

* Fixing dynamic tenancy changes for opensearchdasbhoard.yaml

Signed-off-by: Abhi Kalra <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Change the testuser's password in some integration test cases into a stronger password (opensearch-project#1428)

* Change the testuser's password into a stronger password

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Increment version to 3.0.0.0 (opensearch-project#1414)

Signed-off-by: opensearch-ci-bot <[email protected]>
Co-authored-by: opensearch-ci-bot <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adds the newly created admin api permissions to the static dropdown list (opensearch-project#1426)

* Adds the newly created admin api permissions to the static dropdown of permissions displayed when creating/modifying a role

---------

Signed-off-by: Darshit Chanpura <[email protected]>
Co-authored-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update account-nav-button.tsx

Fix added to set the window.location to the pathname, rather than just reload & clear lastURL as it would be from the previous tenant.

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update account-nav-button.tsx

Adding comments to explain changes

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* add new cluster permissions constants for lron (opensearch-project#1444)

Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* removing whitespace due to linting fix

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests for account-nav-button wip

Signed-off-by: leanneeliatra <[email protected]>

* put commented code to original state

Signed-off-by: leanneeliatra <[email protected]>

* Skip flaky SAML test as it awaits a fix (opensearch-project#1453)

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Use version from package.json for integration tests (opensearch-project#1463)

* Use version from package.json for integration tests

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adds 2.8 release notes (opensearch-project#1464)

Signed-off-by: Darshit Chanpura <[email protected]>
Co-authored-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests to jest test for tenant switch. Putting test in correct folder and renaming function.
Signed-off-by: leanneeliatra <[email protected]>

Signed-off-by: leanneeliatra <[email protected]>

* handle switch calling correct function

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* checking for session storage
Signed-off-by: leanneeliatra <[email protected]>

Signed-off-by: leanneeliatra <[email protected]>

* adding window to make sessionStorage more explicit

Signed-off-by: leanneeliatra <[email protected]>

* Moved the test into account-nav-button.test.tsx

Signed-off-by: leanneeliatra <[email protected]>

* Removing additional files.

Signed-off-by: leanneeliatra <[email protected]>

* Declared session storage as a constant

Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update account-nav-button.tsx

Fix added to set the window.location to the pathname, rather than just reload & clear lastURL as it would be from the previous tenant.

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update account-nav-button.tsx

Adding comments to explain changes

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* removing whitespace due to linting fix

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests for account-nav-button wip

Signed-off-by: leanneeliatra <[email protected]>

* put commented code to original state

Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests to jest test for tenant switch. Putting test in correct folder and renaming function.
Signed-off-by: leanneeliatra <[email protected]>

Signed-off-by: leanneeliatra <[email protected]>

* handle switch calling correct function

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing additional files.

Signed-off-by: leanneeliatra <[email protected]>

* Fix unwanted changes

Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Update account-nav-button.tsx

Fix added to set the window.location to the pathname, rather than just reload & clear lastURL as it would be from the previous tenant.

Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests for account-nav-button wip

Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests to jest test for tenant switch. Putting test in correct folder and renaming function.
Signed-off-by: leanneeliatra <[email protected]>

Signed-off-by: leanneeliatra <[email protected]>

* checking for session storage
Signed-off-by: leanneeliatra <[email protected]>

Signed-off-by: leanneeliatra <[email protected]>

* Declared session storage as a constant

Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests for account-nav-button wip

Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Adding tests to jest test for tenant switch. Putting test in correct folder and renaming function.
Signed-off-by: leanneeliatra <[email protected]>

Signed-off-by: leanneeliatra <[email protected]>

* Moved the test into account-nav-button.test.tsx

Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Dynamic tenancy configurations (opensearch-project#1394)

* Dynamic multitenancy feature.

Signed-off-by: Abhi Kalra <[email protected]>

* Dynamic multitenancy feature -PR feedback

Signed-off-by: Abhi Kalra <[email protected]>

---------

Signed-off-by: Abhi Kalra <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Fixing dynamic tenancy changes for issues 1412 (opensearch-project#1419)

* Fixing dynamic tenancy changes for opensearchdasbhoard.yaml

Signed-off-by: Abhi Kalra <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing Prerequisite Checks Workflow (opensearch-project#1456)

Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Use version from package.json for integration tests (opensearch-project#1463)

* Use version from package.json for integration tests

Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>

* Removing unneded file

Signed-off-by: leanneeliatra <[email protected]>

---------

Signed-off-by: Chang Liu <[email protected]>
Signed-off-by: leanneeliatra <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: nursaadat <[email protected]>
Signed-off-by: Saadat Nursultan <[email protected]>
Signed-off-by: nurbqq <[email protected]>
Signed-off-by: nurbqq <[email protected]>
Signed-off-by: vamsi-amazon <[email protected]>
Signed-off-by: Sirazh Gabdullin <[email protected]>
Signed-off-by: Jochen Kressin <[email protected]>
Signed-off-by: Abhi Kalra <[email protected]>
Signed-off-by: Darshit Chanpura <[email protected]>
Signed-off-by: opensearch-ci-bot <[email protected]>
Signed-off-by: Leanne Lacey-Byrne <[email protected]>
Signed-off-by: zhichao-aws <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Signed-off-by: Ryan Liang <[email protected]>
Signed-off-by: Craig Perkins <[email protected]>
Co-authored-by: Chang Liu <[email protected]>
Co-authored-by: mattieserver <[email protected]>
Co-authored-by: Ryan Liang <[email protected]>
Co-authored-by: Saadat Nursultan <[email protected]>
Co-authored-by: nursaadat <[email protected]>
Co-authored-by: Saadat Nursultan <[email protected]>
Co-authored-by: Nurbakhyt Sembayev <[email protected]>
Co-authored-by: Stephen Crawford <[email protected]>
Co-authored-by: Vamsi Manohar <[email protected]>
Co-authored-by: Sirazh Gabdullin <[email protected]>
Co-authored-by: Jochen Kressin <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
Co-authored-by: Abhi Kalra <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: opensearch-ci-bot <[email protected]>
Co-authored-by: zhichao-aws <[email protected]>
Co-authored-by: Craig Perkins <[email protected]>
Co-authored-by: Darshit Chanpura <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add maven wrapper plugin to the project
3 participants