Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maven wrapper plugin to the project #1413

Closed
adnapibar opened this issue Aug 20, 2021 · 4 comments
Closed

Add maven wrapper plugin to the project #1413

adnapibar opened this issue Aug 20, 2021 · 4 comments
Labels
maintenance Project maintenance

Comments

@adnapibar
Copy link

Is your feature request related to a problem? Please describe.

Similar to Gradle wrapper, provide a Maven wrapper for this project. This enables users to have a fully encapsulated build setup provided by the project.

Describe the solution you'd like
There is wrapper plugin for maven (https://github.com/takari/maven-wrapper) which is going to be a default wrapper in Maven 4.0.

Adding this wrapper plugin to this project, makes life easier for users as they don't have to manage different versions of Maven locally. This also helps the CI system not to worry about managing Maven versions as well.

Describe alternatives you've considered
None

Additional context
N/A

@vrozov
Copy link
Contributor

vrozov commented Aug 21, 2021

I'd prefer to wait till Apache Maven accepts maven wrapper as a contribution.

@vrozov vrozov added maintenance Project maintenance and removed enhancement New feature or request labels Aug 21, 2021
@adnapibar
Copy link
Author

adnapibar commented Aug 21, 2021

I'd prefer to wait till Apache Maven accepts maven wrapper as a contribution.

It is already accepted and included as part of maven 4 which is to be released yet.
https://github.com/apache/maven-wrapper-plugin
https://issues.apache.org/jira/projects/MWRAPPER/issues/MWRAPPER-13?filter=allopenissues

So, for this version of maven this is the plugin to be used.

@vrozov
Copy link
Contributor

vrozov commented Aug 21, 2021

It needs to be part of the official Apache maven release and looks like will require upgrade to maven 4.0. Relying on a project that is not backed by Apache Maven may limit our ability to upgrade maven version to the next minor release.

@davidlago
Copy link

davidlago commented Jan 8, 2022

Closing as we will be moving to Gradle soon with #1533.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
maintenance Project maintenance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants