Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace maven by gradle #1533

Closed
Tracked by #1375
dblock opened this issue Dec 18, 2021 · 4 comments
Closed
Tracked by #1375

Replace maven by gradle #1533

dblock opened this issue Dec 18, 2021 · 4 comments
Assignees
Labels
enhancement New feature or request

Comments

@dblock
Copy link
Member

dblock commented Dec 18, 2021

Is your feature request related to a problem? Please describe.

When working with multiple plugins, such as when making a patch release, security plugin is a 1-off and creates unnecessary friction.

See opensearch-project/opensearch-plugins#119 and https://github.com/opensearch-project/opensearch-build/blob/main/scripts/components/security/build.sh#L70 as examples.

Describe the solution you'd like
Replace maven with standardized gradle implementation just like all the other plugins in OpenSearch.

@davidlago
Copy link

#1121 was a first attempt at this.

This PR is outdated and it does too many things: move CI to gradle, upgrade gradle version, update tests (apparently this last one was more involved as it introduced a new runner)...

We are prioritizing work on our test suite, to start using the OpenSearch Test Framework, and moving to gradle is part of that initiative. That said, @cliu123, do you think there is a subset of that PR that we could merge, moving to gradle while leaving the tests mostly unchanged until we tackle that larger body of work?

@rs-eliatra
Copy link
Contributor

PR: #1592

@prudhvigodithi
Copy link
Member

Hey I can see the security component build system uses gradle, can this issue be closed? :)
@dblock @davidlago @rs-eliatra @bbarani

@peternied
Copy link
Member

Thanks for noticing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

6 participants