SAML Integration Tests #1088

expani · 2022-08-30T21:08:23Z

Description

Adds integration tests using selenium web driver for SAML Authentication flows

What is the old behavior before changes and new behavior after changes?

Integration test were not included.

Issues Resolved

Integration tests for fixes #1058 and #1039

Duplicate of the previous PR #1044

Testing

Integration tests are present in the file saml_auth.test.ts

Check List

New functionality includes testing
New functionality has been documented
Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

… driver Signed-off-by: Deepak Devarakonda <[email protected]>

…ation in developer guide Signed-off-by: Deepak Devarakonda <[email protected]>

Signed-off-by: Deepak Devarakonda <[email protected]>

Signed-off-by: Aniketh Jain <[email protected]>

…ation in developer guide Signed-off-by: Deepak Devarakonda <[email protected]>

Signed-off-by: Aniketh Jain <[email protected]>

expani · 2022-08-30T22:29:21Z

@peternied The integration tests keep failing because of an issue we have observed during testing as well.
FailedWorkflow

For local testing we performed the following steps :

Start and stop the OpenSearch Dashboard Server using yarn start
Run the integration tests using yarn test:jest_server

If we don't run yarn start after a fresh checkout, then the Selenium Web-driver throws up an error ( attached SS ) after logging in via IDP.

A naive solution is to start and stop the OpenSearch Dashboard Server before this

Could you share some insights on what exactly could be causing this ?

expani · 2022-08-31T18:00:32Z

I have identified the issue for the integration tests failing in Github Actions workflow.

Enabled verbose logging for OSD Server.

logging: {
  silent: false,
  verbose: true
}

Checked out the security-dashboard-plugin and ran yarn osd bootstrap

Ran the jest Integration tests using the command yarn test:jest_server with headless mode disabled for the Selenium web-driver.

When the tests ran, all the ITs failed as after SAML login the error page attached in previous comment was thrown. Upon checking the logs, I could see lot of calls to fetch plugin bundles were failing with the 404 response code.

Checked around OSD Server code base and found that build_opensearch_dashboards_platform_plugins gets invoked for generating these plugins when yarn start command is called.

So, ran the command node scripts/build_opensearch_dashboards_platform_plugins.js after yarn osd bootstrap before starting the Integration tests. The entire suite of selenium web-driver based tests ran without any hiccups.

In order, to make the same run in Github Actions, I think we can add the following line before this

node ./OpenSearch-Dashboards/scripts/build_opensearch_dashboards_platform_plugins.js

This will ensure that all integration tests using selenium web driver with security-dashboards-plugin work seamlessly in the future.

Signed-off-by: Aniketh Jain <[email protected]>

…ise_pr Pulling in changes from upstream

Removed a comment no longer required Signed-off-by: Aniketh Jain <[email protected]>

Signed-off-by: Aniketh Jain <[email protected]>

codecov-commenter · 2022-09-01T16:20:32Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 72.43%. Comparing base (5d018b0) to head (fba014d).
Report is 211 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1088   +/-   ##
=======================================
  Coverage   72.43%   72.43%           
=======================================
  Files          88       88           
  Lines        1919     1919           
  Branches      246      246           
=======================================
  Hits         1390     1390           
  Misses        474      474           
  Partials       55       55

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Aniketh Jain <[email protected]>

cliu123 · 2022-09-01T20:24:48Z

.github/workflows/integration-test.yml

+          echo -e "\n\nPrinting the Settings"
+          curl -XGET https://localhost:9200/_cluster/settings?include_defaults=true -u 'admin:admin' -k
+          echo -e "\nFetching Docker Logs for OS Server\n"
+          docker logs oss


Are \ns needed from line 117 - 122?

These are added for debugging, will remove once the ITs succeed.

cliu123 · 2022-09-01T20:33:08Z

server/backend/opensearch_security_client.ts

@@ -157,6 +157,9 @@ export class SecurityClient {
      //     location="https://<your-auth-domain.com>/api/saml2/v1/sso?SAMLRequest=<some-encoded-string>"
      //     requestId="<request_id>"
      //   '
+
+      console.log('Recieved error from authinfo API', error);


Please remove if this is for debugging.

These are added for debugging, will remove once the ITs succeed.

cliu123 · 2022-09-01T20:37:22Z

test/helper/cookie.ts

@@ -20,7 +20,7 @@ import { AUTHORIZATION_HEADER_NAME } from '../constant';

 export function extractAuthCookie(response: Response) {
  const setCookieHeaders = response.header['set-cookie'] as string[];
-  let securityAuthCookie: string;
+  let securityAuthCookie: string | null = null;


Does securityAuthCookie need to be null here? The return value can be undefined.

yes, since null can valid value for securityAuthCookie

cliu123 · 2022-09-01T22:59:09Z

test/jest_integration/saml_auth.test.ts

+    await driver.wait(until.elementsLocated(By.xpath(pageTitleXPath)), 10000);
+
+    const cookie = await driver.manage().getCookies();
+    expect(cookie.length).toEqual(2);


Is the length of the cookie a constant here? alway equals to 2?

yes, one cookie for set by the idp and one cookie set by the security dashboard plugin. So in total there should be two cookies

It looks like the confusion here is in the variable name cookie. The call to getCookies is returning all cookies that the browser encounters which is multiple cookies in this case. Perhaps we should rename this variable to cookies?

peternied

In order, to make the same run in Github Actions, I think we can add the following line before this
node ./OpenSearch-Dashboards/scripts/build_opensearch_dashboards_platform_plugins.js
This will ensure that all integration tests using selenium web driver with security-dashboards-plugin work seamlessly in the future.

Sure, if we need to update how the configuration is performed we should do so, it looks this added this to the current changes 👍

In the CI run it looks like there are some failures - it seems like there was several API call failures Recieved error from authinfo API StatusCodeError {... that might indicate there was a problem during the test setup

peternied · 2022-09-02T01:42:17Z

idp-private-key.pem

@@ -0,0 +1,28 @@
+-----BEGIN PRIVATE KEY-----


Let's generate these certs so we don't have to check them into the codebase

peternied · 2022-09-02T01:44:08Z

package.json

@@ -17,6 +17,7 @@
    "lint:es": "node ../../scripts/eslint",
    "lint:style": "node ../../scripts/stylelint",
    "lint": "yarn run lint:es && yarn run lint:style",
+    "pretest:jest_server": "node ./test/jest_integration/runIdpServer.js &",


Doesn't this start the IDP before all jest tests, could we start it in the setup for the saml_auth.tests.ts?

I'm curious as well, can we spin this up and tear it down as needed for a test or suite of tests?

peternied · 2022-09-02T01:47:20Z

test/jest_integration/saml_auth.test.ts

+    } catch (error) {
+      console.log('Got an error!!', error.stack);
+    }
+    console.log('The Config Response is : ' + JSON.stringify(config));


This looks like debugging info, is this needed during a standard run to diagnose failures? If not could we remove it

We will remove it post integration tests run successfully.

peternied · 2022-09-02T01:55:41Z

test/jest_integration/saml_auth.test.ts

@@ -0,0 +1,340 @@
+/*


Previously there was mention of // 1 Integ Test to test Cookie expiry could you include that test as well?

Signed-off-by: Aniketh Jain <[email protected]>

opensearch-trigger-bot · 2022-09-19T20:34:18Z

The backport to 2.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-1088-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a4fa35d0008b2652c3922f5f2fa814bfa79e0ff3
# Push it to GitHub
git push --set-upstream origin backport/backport-1088-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.x

Then, create a pull request where the base branch is 2.x and the compare/head branch is backport/backport-1088-to-2.x.

cwperks · 2022-09-19T20:56:49Z

Backport to 2.x failed - manually created backport PR: #1104

cwperks · 2022-09-19T21:05:29Z

Automatic backport failed because this PR did not get the backport 2.x label: #1039

* Refactor + add support to run saml based integ tests via selenium web driver Signed-off-by: Deepak Devarakonda <[email protected]> * Add plugins.security.unsupported.restapi.allow_securityconfig_modification in developer guide Signed-off-by: Deepak Devarakonda <[email protected]> * Add one more test Signed-off-by: Deepak Devarakonda <[email protected]> * Added tests for checking tenancy retention after logout in SAML Signed-off-by: Aniketh Jain <[email protected]> * Lint formatting fixes Signed-off-by: Aniketh Jain <[email protected]> * Removed unused imports Signed-off-by: Aniketh Jain <[email protected]> * Add plugins.security.unsupported.restapi.allow_securityconfig_modification in developer guide Signed-off-by: Deepak Devarakonda <[email protected]> * Added License header Signed-off-by: Aniketh Jain <[email protected]> * Added building the plugin bundles while running ITs Signed-off-by: Aniketh Jain <[email protected]> * Signed off the commit Removed a comment no longer required Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added a new stage for debug loggers before cleanup Signed-off-by: Aniketh Jain <[email protected]> * Added a new stage for debug loggers before cleanup Signed-off-by: Aniketh Jain <[email protected]> * Added logger to print error recieved from auth info during saml login Signed-off-by: Aniketh Jain <[email protected]> * Added Docker host N/W Config to allow connection to SAML IDP Signed-off-by: Aniketh Jain <[email protected]> * Added discovery type config to be single node for passing bootstrap checks Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Reverted run command to see change in error Signed-off-by: Aniketh Jain <[email protected]> * Trying with full docker image of OS Signed-off-by: Aniketh Jain <[email protected]> * Refactored the integration test yaml to use OS Full Docker image Signed-off-by: Aniketh Jain <[email protected]> * Removed all debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Added selfSigned package for generating certs and integrated with saml-idp Signed-off-by: Aniketh Jain <[email protected]> * Deleted checked-in key and cert for saml-idp server Signed-off-by: Aniketh Jain <[email protected]> * Reverted use of docker image and testing again with manual build Signed-off-by: Aniketh Jain <[email protected]> * Reverted use of docker image and testing again with manual build Signed-off-by: Aniketh Jain <[email protected]> * Upgraded version from 2.3 to 2.4 Signed-off-by: Aniketh Jain <[email protected]> * Removed debug pointers Signed-off-by: Aniketh Jain <[email protected]> * Commented out failing IT temporarily Signed-off-by: Aniketh Jain <[email protected]> * Lint formatting fix Signed-off-by: Aniketh Jain <[email protected]> * Added the commented failing test back again Signed-off-by: Aniketh Jain <[email protected]> * Removed assertion from test again to make it pass Signed-off-by: Aniketh Jain <[email protected]> * Used a better XPath and improved error logging in tests Signed-off-by: Aniketh Jain <[email protected]> * Removed an unused XPath Signed-off-by: Aniketh Jain <[email protected]> * Added back the assertion for failing IT Signed-off-by: Aniketh Jain <[email protected]> * Added steps to run Selenium based Integ Tests Signed-off-by: Aniketh Jain <[email protected]> * Commented out the test, will re-enable it again in the fix PR Signed-off-by: Aniketh Jain <[email protected]> * Parameterized the getDriver function Signed-off-by: Aniketh Jain <[email protected]> Signed-off-by: Deepak Devarakonda <[email protected]> Signed-off-by: Aniketh Jain <[email protected]> Co-authored-by: Deepak Devarakonda <[email protected]> (cherry picked from commit a4fa35d)

* Refactor + add support to run saml based integ tests via selenium web driver Signed-off-by: Deepak Devarakonda <[email protected]> * Add plugins.security.unsupported.restapi.allow_securityconfig_modification in developer guide Signed-off-by: Deepak Devarakonda <[email protected]> * Add one more test Signed-off-by: Deepak Devarakonda <[email protected]> * Added tests for checking tenancy retention after logout in SAML Signed-off-by: Aniketh Jain <[email protected]> * Lint formatting fixes Signed-off-by: Aniketh Jain <[email protected]> * Removed unused imports Signed-off-by: Aniketh Jain <[email protected]> * Add plugins.security.unsupported.restapi.allow_securityconfig_modification in developer guide Signed-off-by: Deepak Devarakonda <[email protected]> * Added License header Signed-off-by: Aniketh Jain <[email protected]> * Added building the plugin bundles while running ITs Signed-off-by: Aniketh Jain <[email protected]> * Signed off the commit Removed a comment no longer required Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added a new stage for debug loggers before cleanup Signed-off-by: Aniketh Jain <[email protected]> * Added a new stage for debug loggers before cleanup Signed-off-by: Aniketh Jain <[email protected]> * Added logger to print error recieved from auth info during saml login Signed-off-by: Aniketh Jain <[email protected]> * Added Docker host N/W Config to allow connection to SAML IDP Signed-off-by: Aniketh Jain <[email protected]> * Added discovery type config to be single node for passing bootstrap checks Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Reverted run command to see change in error Signed-off-by: Aniketh Jain <[email protected]> * Trying with full docker image of OS Signed-off-by: Aniketh Jain <[email protected]> * Refactored the integration test yaml to use OS Full Docker image Signed-off-by: Aniketh Jain <[email protected]> * Removed all debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Added selfSigned package for generating certs and integrated with saml-idp Signed-off-by: Aniketh Jain <[email protected]> * Deleted checked-in key and cert for saml-idp server Signed-off-by: Aniketh Jain <[email protected]> * Reverted use of docker image and testing again with manual build Signed-off-by: Aniketh Jain <[email protected]> * Reverted use of docker image and testing again with manual build Signed-off-by: Aniketh Jain <[email protected]> * Upgraded version from 2.3 to 2.4 Signed-off-by: Aniketh Jain <[email protected]> * Removed debug pointers Signed-off-by: Aniketh Jain <[email protected]> * Commented out failing IT temporarily Signed-off-by: Aniketh Jain <[email protected]> * Lint formatting fix Signed-off-by: Aniketh Jain <[email protected]> * Added the commented failing test back again Signed-off-by: Aniketh Jain <[email protected]> * Removed assertion from test again to make it pass Signed-off-by: Aniketh Jain <[email protected]> * Used a better XPath and improved error logging in tests Signed-off-by: Aniketh Jain <[email protected]> * Removed an unused XPath Signed-off-by: Aniketh Jain <[email protected]> * Added back the assertion for failing IT Signed-off-by: Aniketh Jain <[email protected]> * Added steps to run Selenium based Integ Tests Signed-off-by: Aniketh Jain <[email protected]> * Commented out the test, will re-enable it again in the fix PR Signed-off-by: Aniketh Jain <[email protected]> * Parameterized the getDriver function Signed-off-by: Aniketh Jain <[email protected]> Signed-off-by: Deepak Devarakonda <[email protected]> Signed-off-by: Aniketh Jain <[email protected]> Co-authored-by: Deepak Devarakonda <[email protected]> Signed-off-by: Aozixuan Priscilla Guan <[email protected]>

* SAML Integration Tests (#1088) (cherry picked from commit a4fa35d) Signed-off-by: Deepak Devarakonda <[email protected]> Signed-off-by: Aniketh Jain <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Signed-off-by: anijain-Amazon <[email protected]>

* Refactor + add support to run saml based integ tests via selenium web driver Signed-off-by: Deepak Devarakonda <[email protected]> * Add plugins.security.unsupported.restapi.allow_securityconfig_modification in developer guide Signed-off-by: Deepak Devarakonda <[email protected]> * Add one more test Signed-off-by: Deepak Devarakonda <[email protected]> * Added tests for checking tenancy retention after logout in SAML Signed-off-by: Aniketh Jain <[email protected]> * Lint formatting fixes Signed-off-by: Aniketh Jain <[email protected]> * Removed unused imports Signed-off-by: Aniketh Jain <[email protected]> * Add plugins.security.unsupported.restapi.allow_securityconfig_modification in developer guide Signed-off-by: Deepak Devarakonda <[email protected]> * Added License header Signed-off-by: Aniketh Jain <[email protected]> * Added building the plugin bundles while running ITs Signed-off-by: Aniketh Jain <[email protected]> * Signed off the commit Removed a comment no longer required Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added a new stage for debug loggers before cleanup Signed-off-by: Aniketh Jain <[email protected]> * Added a new stage for debug loggers before cleanup Signed-off-by: Aniketh Jain <[email protected]> * Added logger to print error recieved from auth info during saml login Signed-off-by: Aniketh Jain <[email protected]> * Added Docker host N/W Config to allow connection to SAML IDP Signed-off-by: Aniketh Jain <[email protected]> * Added discovery type config to be single node for passing bootstrap checks Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Reverted run command to see change in error Signed-off-by: Aniketh Jain <[email protected]> * Trying with full docker image of OS Signed-off-by: Aniketh Jain <[email protected]> * Refactored the integration test yaml to use OS Full Docker image Signed-off-by: Aniketh Jain <[email protected]> * Removed all debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Added selfSigned package for generating certs and integrated with saml-idp Signed-off-by: Aniketh Jain <[email protected]> * Deleted checked-in key and cert for saml-idp server Signed-off-by: Aniketh Jain <[email protected]> * Reverted use of docker image and testing again with manual build Signed-off-by: Aniketh Jain <[email protected]> * Reverted use of docker image and testing again with manual build Signed-off-by: Aniketh Jain <[email protected]> * Upgraded version from 2.3 to 2.4 Signed-off-by: Aniketh Jain <[email protected]> * Removed debug pointers Signed-off-by: Aniketh Jain <[email protected]> * Commented out failing IT temporarily Signed-off-by: Aniketh Jain <[email protected]> * Lint formatting fix Signed-off-by: Aniketh Jain <[email protected]> * Added the commented failing test back again Signed-off-by: Aniketh Jain <[email protected]> * Removed assertion from test again to make it pass Signed-off-by: Aniketh Jain <[email protected]> * Used a better XPath and improved error logging in tests Signed-off-by: Aniketh Jain <[email protected]> * Removed an unused XPath Signed-off-by: Aniketh Jain <[email protected]> * Added back the assertion for failing IT Signed-off-by: Aniketh Jain <[email protected]> * Added steps to run Selenium based Integ Tests Signed-off-by: Aniketh Jain <[email protected]> * Commented out the test, will re-enable it again in the fix PR Signed-off-by: Aniketh Jain <[email protected]> * Parameterized the getDriver function Signed-off-by: Aniketh Jain <[email protected]> Signed-off-by: Deepak Devarakonda <[email protected]> Signed-off-by: Aniketh Jain <[email protected]> Co-authored-by: Deepak Devarakonda <[email protected]> (cherry picked from commit a4fa35d) Signed-off-by: Aniketh Jain <[email protected]>

* Refactor + add support to run saml based integ tests via selenium web driver Signed-off-by: Deepak Devarakonda <[email protected]> * Add plugins.security.unsupported.restapi.allow_securityconfig_modification in developer guide Signed-off-by: Deepak Devarakonda <[email protected]> * Add one more test Signed-off-by: Deepak Devarakonda <[email protected]> * Added tests for checking tenancy retention after logout in SAML Signed-off-by: Aniketh Jain <[email protected]> * Lint formatting fixes Signed-off-by: Aniketh Jain <[email protected]> * Removed unused imports Signed-off-by: Aniketh Jain <[email protected]> * Add plugins.security.unsupported.restapi.allow_securityconfig_modification in developer guide Signed-off-by: Deepak Devarakonda <[email protected]> * Added License header Signed-off-by: Aniketh Jain <[email protected]> * Added building the plugin bundles while running ITs Signed-off-by: Aniketh Jain <[email protected]> * Signed off the commit Removed a comment no longer required Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added a new stage for debug loggers before cleanup Signed-off-by: Aniketh Jain <[email protected]> * Added a new stage for debug loggers before cleanup Signed-off-by: Aniketh Jain <[email protected]> * Added logger to print error recieved from auth info during saml login Signed-off-by: Aniketh Jain <[email protected]> * Added Docker host N/W Config to allow connection to SAML IDP Signed-off-by: Aniketh Jain <[email protected]> * Added discovery type config to be single node for passing bootstrap checks Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Reverted run command to see change in error Signed-off-by: Aniketh Jain <[email protected]> * Trying with full docker image of OS Signed-off-by: Aniketh Jain <[email protected]> * Refactored the integration test yaml to use OS Full Docker image Signed-off-by: Aniketh Jain <[email protected]> * Removed all debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Added selfSigned package for generating certs and integrated with saml-idp Signed-off-by: Aniketh Jain <[email protected]> * Deleted checked-in key and cert for saml-idp server Signed-off-by: Aniketh Jain <[email protected]> * Reverted use of docker image and testing again with manual build Signed-off-by: Aniketh Jain <[email protected]> * Reverted use of docker image and testing again with manual build Signed-off-by: Aniketh Jain <[email protected]> * Upgraded version from 2.3 to 2.4 Signed-off-by: Aniketh Jain <[email protected]> * Removed debug pointers Signed-off-by: Aniketh Jain <[email protected]> * Commented out failing IT temporarily Signed-off-by: Aniketh Jain <[email protected]> * Lint formatting fix Signed-off-by: Aniketh Jain <[email protected]> * Added the commented failing test back again Signed-off-by: Aniketh Jain <[email protected]> * Removed assertion from test again to make it pass Signed-off-by: Aniketh Jain <[email protected]> * Used a better XPath and improved error logging in tests Signed-off-by: Aniketh Jain <[email protected]> * Removed an unused XPath Signed-off-by: Aniketh Jain <[email protected]> * Added back the assertion for failing IT Signed-off-by: Aniketh Jain <[email protected]> * Added steps to run Selenium based Integ Tests Signed-off-by: Aniketh Jain <[email protected]> * Commented out the test, will re-enable it again in the fix PR Signed-off-by: Aniketh Jain <[email protected]> * Parameterized the getDriver function Signed-off-by: Aniketh Jain <[email protected]> Signed-off-by: Deepak Devarakonda <[email protected]> Signed-off-by: Aniketh Jain <[email protected]> Co-authored-by: Deepak Devarakonda <[email protected]> (cherry picked from commit a4fa35d)

…Authentication flow (#1134) * SAML Integration Tests (#1088) Signed-off-by: Deepak Devarakonda <[email protected]> Signed-off-by: Aniketh Jain <[email protected]> Signed-off-by: Aniketh Jain <[email protected]> Co-authored-by: Deepak Devarakonda <[email protected]> (cherry picked from commit a4fa35d) (cherry picked from commit 05649d6)

* Fix for Tenancy info getting lost on re-login in SAML Authentication flow #1058 * SAML Integration Tests #1088 * Preserve URL Hash for SAML based login #1054 Signed-off-by: Aniketh Jain <[email protected]> Signed-off-by: Deepak Devarakonda <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]> Co-authored-by: Deepak Devarakonda <[email protected]> Co-authored-by: Deepak Devarakonda <[email protected]> (cherry picked from commit a9d10d8) (cherry picked from commit a4fa35d) (cherry picked from commit 05649d6)

opensearch-trigger-bot · 2022-11-16T22:38:38Z

The backport to 1.3 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3 1.3
# Navigate to the new working tree
cd .worktrees/backport-1.3
# Create a new branch
git switch --create backport/backport-1088-to-1.3
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 a4fa35d0008b2652c3922f5f2fa814bfa79e0ff3
# Push it to GitHub
git push --set-upstream origin backport/backport-1088-to-1.3
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3

Then, create a pull request where the base branch is 1.3 and the compare/head branch is backport/backport-1088-to-1.3.

* SAML Integration Tests (#1088) * Preserve URL Hash for SAML based login (#1039) * Preserve URL HASH after user logs via SAML IDP Signed-off-by: Deepak Devarakonda <[email protected]> Signed-off-by: Aniketh Jain <[email protected]> Signed-off-by: Craig Perkins <[email protected]> Co-authored-by: anijain-Amazon <[email protected]> Co-authored-by: Deepak Devarakonda <[email protected]> Co-authored-by: Deepak Devarakonda <[email protected]> Co-authored-by: Darshit Chanpura <[email protected]>

devardee and others added 8 commits August 30, 2022 23:00

Refactor + add support to run saml based integ tests via selenium web…

861c909

… driver Signed-off-by: Deepak Devarakonda <[email protected]>

Add plugins.security.unsupported.restapi.allow_securityconfig_modific…

c42dacc

…ation in developer guide Signed-off-by: Deepak Devarakonda <[email protected]>

Add one more test

7415746

Signed-off-by: Deepak Devarakonda <[email protected]>

Added tests for checking tenancy retention after logout in SAML

a1afaa5

Signed-off-by: Aniketh Jain <[email protected]>

Lint formatting fixes

381de0c

Signed-off-by: Aniketh Jain <[email protected]>

Removed unused imports

69c765f

Signed-off-by: Aniketh Jain <[email protected]>

Add plugins.security.unsupported.restapi.allow_securityconfig_modific…

2234f77

…ation in developer guide Signed-off-by: Deepak Devarakonda <[email protected]>

Added License header

776e134

Signed-off-by: Aniketh Jain <[email protected]>

devardee mentioned this pull request Sep 1, 2022

Initial draft PR to introduce Integration Tests for SAML auth flow #1044

Closed

3 tasks

Added building the plugin bundles while running ITs

4e73818

Signed-off-by: Aniketh Jain <[email protected]>

expani marked this pull request as ready for review September 1, 2022 06:34

expani requested a review from a team September 1, 2022 06:34

expani added 6 commits September 1, 2022 12:27

Merge remote-tracking branch 'upstream/main' into saml_integ_tests_ra…

d68808a

…ise_pr Pulling in changes from upstream

Signed off the commit

1a641ba

Removed a comment no longer required Signed-off-by: Aniketh Jain <[email protected]>

Added debug loggers for checking IT failures

016087c

Signed-off-by: Aniketh Jain <[email protected]>

Added debug loggers for checking IT failures

4c3561a

Signed-off-by: Aniketh Jain <[email protected]>

Added debug loggers for checking IT failures

5c486b4

Signed-off-by: Aniketh Jain <[email protected]>

Added debug loggers for checking IT failures

fc133ae

Signed-off-by: Aniketh Jain <[email protected]>

expani added 3 commits September 1, 2022 21:59

Added a new stage for debug loggers before cleanup

a39fa6f

Signed-off-by: Aniketh Jain <[email protected]>

Added a new stage for debug loggers before cleanup

15f7483

Signed-off-by: Aniketh Jain <[email protected]>

Added logger to print error recieved from auth info during saml login

07688fa

Signed-off-by: Aniketh Jain <[email protected]>

cliu123 reviewed Sep 1, 2022

View reviewed changes

peternied reviewed Sep 2, 2022

View reviewed changes

Added Docker host N/W Config to allow connection to SAML IDP

a0338d4

Signed-off-by: Aniketh Jain <[email protected]>

peternied approved these changes Sep 19, 2022

View reviewed changes

cwperks approved these changes Sep 19, 2022

View reviewed changes

cwperks merged commit a4fa35d into opensearch-project:main Sep 19, 2022

cwperks mentioned this pull request Sep 19, 2022

[Backport 2.x] SAML Integration Tests #1104

Merged

expani mentioned this pull request Oct 6, 2022

[ Backport 2.3 ] 1054, 1058 and 1088 #1132

Merged

3 tasks

expani mentioned this pull request Oct 6, 2022

[Backport 2.x] Fix for Tenancy info getting lost on re-login in SAML Authentication flow #1134

Merged

3 tasks

cwperks mentioned this pull request Nov 16, 2022

[Backport 1.3] Preserve URL Hash for SAML based login #1219

Closed

stephen-crawford added the backport 1.3 label Nov 16, 2022

cwperks mentioned this pull request Nov 23, 2022

[Backport 1.3] Preserve URL Hash for SAML based login #1226

Merged

3 tasks

cwperks mentioned this pull request Mar 7, 2023

[FEATURE]Automation Test for OIDC #1150

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

SAML Integration Tests #1088

SAML Integration Tests #1088

expani commented Aug 30, 2022

expani commented Aug 30, 2022 •

edited

Loading

expani commented Aug 31, 2022 •

edited

Loading

codecov-commenter commented Sep 1, 2022 •

edited by codecov bot

Loading

cliu123 Sep 1, 2022

expani Sep 2, 2022

cliu123 Sep 1, 2022

expani Sep 2, 2022

cliu123 Sep 1, 2022

devardee Sep 14, 2022

cliu123 Sep 1, 2022 •

edited

Loading

devardee Sep 14, 2022

cwperks Sep 15, 2022

peternied left a comment

peternied Sep 2, 2022

peternied Sep 2, 2022

cwperks Sep 15, 2022

peternied Sep 2, 2022

expani Sep 2, 2022

peternied Sep 2, 2022

opensearch-trigger-bot bot commented Sep 19, 2022

cwperks commented Sep 19, 2022

cwperks commented Sep 19, 2022

opensearch-trigger-bot bot commented Nov 16, 2022

SAML Integration Tests #1088

SAML Integration Tests #1088

Conversation

expani commented Aug 30, 2022

Description

Category

What is the old behavior before changes and new behavior after changes?

Issues Resolved

Testing

Check List

expani commented Aug 30, 2022 • edited Loading

expani commented Aug 31, 2022 • edited Loading

codecov-commenter commented Sep 1, 2022 • edited by codecov bot Loading

Codecov Report

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cliu123 Sep 1, 2022 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

peternied left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

opensearch-trigger-bot bot commented Sep 19, 2022

cwperks commented Sep 19, 2022

cwperks commented Sep 19, 2022

opensearch-trigger-bot bot commented Nov 16, 2022

expani commented Aug 30, 2022 •

edited

Loading

expani commented Aug 31, 2022 •

edited

Loading

codecov-commenter commented Sep 1, 2022 •

edited by codecov bot

Loading

cliu123 Sep 1, 2022 •

edited

Loading