[Backport 2.x] Fix for Tenancy info getting lost on re-login in SAML Authentication flow #1134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Refactor + add support to run saml based integ tests via selenium web driver Signed-off-by: Deepak Devarakonda <[email protected]> * Add plugins.security.unsupported.restapi.allow_securityconfig_modification in developer guide Signed-off-by: Deepak Devarakonda <[email protected]> * Add one more test Signed-off-by: Deepak Devarakonda <[email protected]> * Added tests for checking tenancy retention after logout in SAML Signed-off-by: Aniketh Jain <[email protected]> * Lint formatting fixes Signed-off-by: Aniketh Jain <[email protected]> * Removed unused imports Signed-off-by: Aniketh Jain <[email protected]> * Add plugins.security.unsupported.restapi.allow_securityconfig_modification in developer guide Signed-off-by: Deepak Devarakonda <[email protected]> * Added License header Signed-off-by: Aniketh Jain <[email protected]> * Added building the plugin bundles while running ITs Signed-off-by: Aniketh Jain <[email protected]> * Signed off the commit Removed a comment no longer required Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added debug loggers for checking IT failures Signed-off-by: Aniketh Jain <[email protected]> * Added a new stage for debug loggers before cleanup Signed-off-by: Aniketh Jain <[email protected]> * Added a new stage for debug loggers before cleanup Signed-off-by: Aniketh Jain <[email protected]> * Added logger to print error recieved from auth info during saml login Signed-off-by: Aniketh Jain <[email protected]> * Added Docker host N/W Config to allow connection to SAML IDP Signed-off-by: Aniketh Jain <[email protected]> * Added discovery type config to be single node for passing bootstrap checks Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Reverted run command to see change in error Signed-off-by: Aniketh Jain <[email protected]> * Trying with full docker image of OS Signed-off-by: Aniketh Jain <[email protected]> * Refactored the integration test yaml to use OS Full Docker image Signed-off-by: Aniketh Jain <[email protected]> * Removed all debug loggers Signed-off-by: Aniketh Jain <[email protected]> * Added selfSigned package for generating certs and integrated with saml-idp Signed-off-by: Aniketh Jain <[email protected]> * Deleted checked-in key and cert for saml-idp server Signed-off-by: Aniketh Jain <[email protected]> * Reverted use of docker image and testing again with manual build Signed-off-by: Aniketh Jain <[email protected]> * Reverted use of docker image and testing again with manual build Signed-off-by: Aniketh Jain <[email protected]> * Upgraded version from 2.3 to 2.4 Signed-off-by: Aniketh Jain <[email protected]> * Removed debug pointers Signed-off-by: Aniketh Jain <[email protected]> * Commented out failing IT temporarily Signed-off-by: Aniketh Jain <[email protected]> * Lint formatting fix Signed-off-by: Aniketh Jain <[email protected]> * Added the commented failing test back again Signed-off-by: Aniketh Jain <[email protected]> * Removed assertion from test again to make it pass Signed-off-by: Aniketh Jain <[email protected]> * Used a better XPath and improved error logging in tests Signed-off-by: Aniketh Jain <[email protected]> * Removed an unused XPath Signed-off-by: Aniketh Jain <[email protected]> * Added back the assertion for failing IT Signed-off-by: Aniketh Jain <[email protected]> * Added steps to run Selenium based Integ Tests Signed-off-by: Aniketh Jain <[email protected]> * Commented out the test, will re-enable it again in the fix PR Signed-off-by: Aniketh Jain <[email protected]> * Parameterized the getDriver function Signed-off-by: Aniketh Jain <[email protected]> Signed-off-by: Deepak Devarakonda <[email protected]> Signed-off-by: Aniketh Jain <[email protected]> Co-authored-by: Deepak Devarakonda <[email protected]> (cherry picked from commit a4fa35d)
…flow (opensearch-project#1058) * Fix for picking up tenancy from local storage in SAML AuthN flow Signed-off-by: Aniketh Jain <[email protected]> (cherry picked from commit 05649d6)
peternied
reviewed
Oct 6, 2022
|
@peternied Not sure about the exact cause of the issue. But, the backport bot failed to create the PRs. Here is the comment on backport 2.x failing by the bot. |
cwperks
changed the title
cwperks
approved these changes
Oct 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This backport PR is for the following PRs :
Category
[Backport]
Why these changes are required?
Changes need to be back-ported
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.