Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport 2.x] SAML Integration Tests #1104

Merged

Conversation

cwperks
Copy link
Member

@cwperks cwperks commented Sep 19, 2022

Backport a4fa35d from #1088

@cwperks cwperks requested a review from a team September 19, 2022 20:55
@cwperks cwperks mentioned this pull request Sep 19, 2022
3 tasks
* Refactor + add support to run saml based integ tests via selenium web driver

Signed-off-by: Deepak Devarakonda <[email protected]>

* Add plugins.security.unsupported.restapi.allow_securityconfig_modification in developer guide

Signed-off-by: Deepak Devarakonda <[email protected]>

* Add one more test

Signed-off-by: Deepak Devarakonda <[email protected]>

* Added tests for checking tenancy retention after logout in SAML

Signed-off-by: Aniketh Jain <[email protected]>

* Lint formatting fixes

Signed-off-by: Aniketh Jain <[email protected]>

* Removed unused imports

Signed-off-by: Aniketh Jain <[email protected]>

* Add plugins.security.unsupported.restapi.allow_securityconfig_modification in developer guide

Signed-off-by: Deepak Devarakonda <[email protected]>

* Added License header

Signed-off-by: Aniketh Jain <[email protected]>

* Added building the plugin bundles while running ITs

Signed-off-by: Aniketh Jain <[email protected]>

* Signed off the commit

Removed a comment no longer required

Signed-off-by: Aniketh Jain <[email protected]>

* Added debug loggers for checking IT failures

Signed-off-by: Aniketh Jain <[email protected]>

* Added debug loggers for checking IT failures

Signed-off-by: Aniketh Jain <[email protected]>

* Added debug loggers for checking IT failures

Signed-off-by: Aniketh Jain <[email protected]>

* Added debug loggers for checking IT failures

Signed-off-by: Aniketh Jain <[email protected]>

* Added a new stage for debug loggers before cleanup

Signed-off-by: Aniketh Jain <[email protected]>

* Added a new stage for debug loggers before cleanup

Signed-off-by: Aniketh Jain <[email protected]>

* Added logger to print error recieved from auth info during saml login

Signed-off-by: Aniketh Jain <[email protected]>

* Added Docker host N/W Config to allow connection to SAML IDP

Signed-off-by: Aniketh Jain <[email protected]>

* Added discovery type config to be single node for passing bootstrap checks

Signed-off-by: Aniketh Jain <[email protected]>

* Debug loggers

Signed-off-by: Aniketh Jain <[email protected]>

* Debug loggers

Signed-off-by: Aniketh Jain <[email protected]>

* Debug loggers

Signed-off-by: Aniketh Jain <[email protected]>

* Reverted run command to see change in error

Signed-off-by: Aniketh Jain <[email protected]>

* Trying with full docker image of OS

Signed-off-by: Aniketh Jain <[email protected]>

* Refactored the integration test yaml to use OS Full Docker image

Signed-off-by: Aniketh Jain <[email protected]>

* Removed all debug loggers

Signed-off-by: Aniketh Jain <[email protected]>

* Added selfSigned package for generating certs and integrated with saml-idp

Signed-off-by: Aniketh Jain <[email protected]>

* Deleted checked-in key and cert for saml-idp server

Signed-off-by: Aniketh Jain <[email protected]>

* Reverted use of docker image and testing again with manual build

Signed-off-by: Aniketh Jain <[email protected]>

* Reverted use of docker image and testing again with manual build

Signed-off-by: Aniketh Jain <[email protected]>

* Upgraded version from 2.3 to 2.4

Signed-off-by: Aniketh Jain <[email protected]>

* Removed debug pointers

Signed-off-by: Aniketh Jain <[email protected]>

* Commented out failing IT temporarily

Signed-off-by: Aniketh Jain <[email protected]>

* Lint formatting fix

Signed-off-by: Aniketh Jain <[email protected]>

* Added the commented failing test back again

Signed-off-by: Aniketh Jain <[email protected]>

* Removed assertion from test again to make it pass

Signed-off-by: Aniketh Jain <[email protected]>

* Used a better XPath and improved error logging in tests

Signed-off-by: Aniketh Jain <[email protected]>

* Removed an unused XPath

Signed-off-by: Aniketh Jain <[email protected]>

* Added back the assertion for failing IT

Signed-off-by: Aniketh Jain <[email protected]>

* Added steps to run Selenium based Integ Tests

Signed-off-by: Aniketh Jain <[email protected]>

* Commented out the test, will re-enable it again in the fix PR

Signed-off-by: Aniketh Jain <[email protected]>

* Parameterized the getDriver function

Signed-off-by: Aniketh Jain <[email protected]>

Signed-off-by: Deepak Devarakonda <[email protected]>
Signed-off-by: Aniketh Jain <[email protected]>
Co-authored-by: Deepak Devarakonda <[email protected]>
(cherry picked from commit a4fa35d)
@cwperks cwperks force-pushed the backport/backport-1088-to-2.x branch from 0713cea to 6d6ae3b Compare September 23, 2022 17:01
@codecov-commenter
Copy link

Codecov Report

Merging #1104 (3e8a4d8) into 2.x (3a04a68) will increase coverage by 2.09%.
The diff coverage is n/a.

❗ Current head 3e8a4d8 differs from pull request most recent head 5fcdd0a. Consider uploading reports for the commit 5fcdd0a to get more accurate results

@@            Coverage Diff             @@
##              2.x    #1104      +/-   ##
==========================================
+ Coverage   72.43%   74.53%   +2.09%     
==========================================
  Files          88       86       -2     
  Lines        1919     1865      -54     
  Branches      246      240       -6     
==========================================
  Hits         1390     1390              
+ Misses        474      420      -54     
  Partials       55       55              
Impacted Files Coverage Δ
...-plugin/public/apps/account/account-nav-button.tsx 71.42% <0.00%> (ø)
...lugins/security-dashboards-plugin/public/plugin.ts
...plugins/security-dashboards-plugin/public/index.ts

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cwperks
Copy link
Member Author

cwperks commented Sep 27, 2022

@opensearch-project/security I had to manually create this backport PR. I'm not able to approve or merge this since I created the PR, can someone take a look?

@peternied peternied merged commit 169790b into opensearch-project:2.x Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants