Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create vpc dashboard using saved object client #392

Conversation

amsiglan
Copy link
Collaborator

Description

[Describe what this change achieves]

Issues Resolved

[List any issues this PR will resolve]

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Jan 31, 2023

Codecov Report

Merging #392 (cb86cf4) into main (9a62208) will decrease coverage by 0.12%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   35.56%   35.44%   -0.12%     
==========================================
  Files         111      116       +5     
  Lines        3051     3120      +69     
  Branches      479      489      +10     
==========================================
+ Hits         1085     1106      +21     
- Misses       1851     1894      +43     
- Partials      115      120       +5     
Impacted Files Coverage Δ
.../Detectors/containers/Detector/DetectorDetails.tsx 50.00% <0.00%> (-6.85%) ⬇️
...ectorBasicDetailsView/DetectorBasicDetailsView.tsx 50.00% <0.00%> (-5.56%) ⬇️
...ashboards-plugin/public/security_analytics_app.tsx 5.55% <0.00%> (-0.33%) ⬇️
...ytics-dashboards-plugin/public/pages/Main/Main.tsx 10.00% <0.00%> (ø)
...-dashboards-plugin/public/services/IndexService.ts 50.00% <0.00%> (ø)
...pages/Findings/components/FindingDetailsFlyout.tsx 9.72% <0.00%> (ø)
...ainers/DetectorDetailsView/DetectorDetailsView.tsx 66.66% <0.00%> (ø)
...shboards-plugin/public/store/savedObjectsConfig.ts 33.33% <0.00%> (ø)
...ards-plugin/public/store/config/savedObjects/s3.ts 100.00% <0.00%> (ø)
...gin/public/store/config/savedObjects/cloudtrail.ts 100.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@amsiglan amsiglan changed the title Create vpc dashboard suing saved object client Create vpc dashboard using saved object client Jan 31, 2023
amsiglan and others added 12 commits January 31, 2023 13:51
* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] The detector details shouldn't have a wrapper around the whole page opensearch-project#384

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components opensearch-project#383
[BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Expand the chart's vertical domain so that top positioning elements are not clipped. opensearch-project#334

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature/update vertical domain opensearch-project#638

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature/update vertical domain opensearch-project#638

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature/update vertical domain opensearch-project#638

Signed-off-by: Jovan Cvetkovic <[email protected]>

* testing github-action v5

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature/update vertical domain opensearch-project#372

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components opensearch-project#383
[BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Co-authored-by: AWSHurneyt <[email protected]>
* Updated the MAINTAINERS doc.

Signed-off-by: AWSHurneyt <[email protected]>

* Added CODEOWNERS List.

Signed-off-by: AWSHurneyt <[email protected]>

---------

Signed-off-by: AWSHurneyt <[email protected]>
* [FEATURE] Detector must have at least one alert set opensearch-project#288

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [BUG] Create detector | Interval field can be empty opensearch-project#378

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Adjust styling for Finding details flyout opensearch-project#369

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* detector unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* detector unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* detector unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* detector unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* detector unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* detector unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* detector unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* detector unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* detector unit tests

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* unit tests review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Feature/update vertical domain opensearch-project#372

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components opensearch-project#383

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components opensearch-project#383

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components opensearch-project#383

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components opensearch-project#383

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components opensearch-project#383
[BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components opensearch-project#383
[BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406

Signed-off-by: Jovan Cvetkovic <[email protected]>

* PR code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

* PR code review

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan marked this pull request as ready for review February 22, 2023 01:37
@amsiglan amsiglan requested a review from a team February 22, 2023 01:37
Signed-off-by: dblock <[email protected]>
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan force-pushed the create-vpc-dashboard-suing-saved-object-client branch from cb86cf4 to 82a6308 Compare February 22, 2023 01:56
@amsiglan amsiglan closed this Feb 22, 2023
@amsiglan
Copy link
Collaborator Author

Created #437 to resolve the DCO check issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants