Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Add edit detector links into breadcrumbs #393

Closed
jovancacvetkovic opened this issue Jan 31, 2023 · 0 comments · Fixed by #404
Closed

[FEATURE] Add edit detector links into breadcrumbs #393

jovancacvetkovic opened this issue Jan 31, 2023 · 0 comments · Fixed by #404
Labels
enhancement New feature or request

Comments

@jovancacvetkovic
Copy link

Is your feature request related to a problem?
The current breadcrumbs for the edit detector don't show the last action but just the detector name.

What solution would you like?
Add the last action to the breadcrumbs, eg Edit details

Do you have any additional context?
Doesn't have the last action eg Edit details
edit breadcrumbs
@jovancacvetkovic jovancacvetkovic added enhancement New feature or request untriaged labels Jan 31, 2023
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Jan 31, 2023
@jovancvetkovic3006
[FEATURE] Add edit detector links into breadcrumbs opensearch-project…
0ac575f 
…#393

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Feb 6, 2023
@jovancvetkovic3006
[FEATURE] Add edit detector links into breadcrumbs opensearch-project…
2b5e877 
…#393

Signed-off-by: Jovan Cvetkovic <[email protected]>
jovancacvetkovic pushed a commit to jovancacvetkovic/security-analytics-dashboards-plugin that referenced this issue Feb 6, 2023
@jovancvetkovic3006
[FEATURE] Add edit detector links into breadcrumbs opensearch-project…
98697bd 
…#393

Signed-off-by: Jovan Cvetkovic <[email protected]>
@jovancacvetkovic jovancacvetkovic mentioned this issue Feb 6, 2023
Merged
1 task
amsiglan pushed a commit that referenced this issue Feb 14, 2023
@jovancvetkovic3006
Fixes UX issues with edit detector pages (#404)
85f2ee4 
* [FEATURE] Add edit detector links into breadcrumbs #393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs #393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs #393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components #383
[BUG] Detector Edit | Custom rule are not selected on update rules #406

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
opensearch-trigger-bot bot pushed a commit that referenced this issue Feb 14, 2023
@jovancvetkovic3006 @github-actions
Fixes UX issues with edit detector pages (#404)
21cd339 
* [FEATURE] Add edit detector links into breadcrumbs #393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs #393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs #393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components #383
[BUG] Detector Edit | Custom rule are not selected on update rules #406

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 85f2ee4)
amsiglan pushed a commit that referenced this issue Feb 15, 2023
@opensearch-trigger-bot @jovancvetkovic3006
Fixes UX issues with edit detector pages (#404) (#411)
0222d93 
* [FEATURE] Add edit detector links into breadcrumbs #393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs #393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs #393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components #383
[BUG] Detector Edit | Custom rule are not selected on update rules #406

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 85f2ee4)

Co-authored-by: Jovan Cvetkovic <[email protected]>
amsiglan pushed a commit to amsiglan/security-analytics-dashboards-plugin that referenced this issue Feb 22, 2023
@jovancvetkovic3006 @amsiglan
Fixes UX issues with edit detector pages (opensearch-project#404)
71810a1 
* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components opensearch-project#383
[BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Feb 22, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
Fixes UX issues with edit detector pages (opensearch-project#404) (op…
1a09105 
…ensearch-project#411)

* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components opensearch-project#383
[BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 85f2ee4)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this issue Oct 12, 2023
@opensearch-trigger-bot @jovancvetkovic3006 @AWSHurneyt
Fixes UX issues with edit detector pages (opensearch-project#404) (op…
1637b59 
…ensearch-project#411)

* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs opensearch-project#393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components opensearch-project#383
[BUG] Detector Edit | Custom rule are not selected on update rules opensearch-project#406

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 85f2ee4)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
amsiglan pushed a commit that referenced this issue Mar 16, 2024
@opensearch-trigger-bot @jovancvetkovic3006 @amsiglan
Fixes UX issues with edit detector pages (#404) (#411)
129a774 
* [FEATURE] Add edit detector links into breadcrumbs #393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs #393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* [FEATURE] Add edit detector links into breadcrumbs #393

Signed-off-by: Jovan Cvetkovic <[email protected]>

* Unit tests for public components #383
[BUG] Detector Edit | Custom rule are not selected on update rules #406

Signed-off-by: Jovan Cvetkovic <[email protected]>

---------

Signed-off-by: Jovan Cvetkovic <[email protected]>
(cherry picked from commit 85f2ee4)

Co-authored-by: Jovan Cvetkovic <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes UX issues with edit detector pages jovancacvetkovic/security-analytics-dashboards-plugin
2 participants
@jovancacvetkovic @AWSHurneyt