Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added create dashboard feature #437

Merged

Conversation

amsiglan
Copy link
Collaborator

Description

Creating dashboard for three log types: vpcflow logs, cloudtrail logs, s3 access logs

  • When detector is created successfully for these log types. we also create a dashboard using pre-configured templates

Issues Resolved

#14

Check List

  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan requested a review from a team February 22, 2023 02:17
@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2023

Codecov Report

Merging #437 (9dc925a) into main (18066d3) will decrease coverage by 0.22%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #437      +/-   ##
==========================================
- Coverage   35.57%   35.35%   -0.22%     
==========================================
  Files         111      116       +5     
  Lines        3050     3131      +81     
  Branches      480      490      +10     
==========================================
+ Hits         1085     1107      +22     
- Misses       1850     1904      +54     
- Partials      115      120       +5     
Impacted Files Coverage Δ
...-dashboards-plugin/public/services/IndexService.ts 40.00% <0.00%> (-10.00%) ⬇️
.../Detectors/containers/Detector/DetectorDetails.tsx 50.00% <0.00%> (-6.85%) ⬇️
...ectorBasicDetailsView/DetectorBasicDetailsView.tsx 50.00% <0.00%> (-5.56%) ⬇️
...ashboards-plugin/public/security_analytics_app.tsx 5.55% <0.00%> (-0.33%) ⬇️
...ytics-dashboards-plugin/public/pages/Main/Main.tsx 10.00% <0.00%> (ø)
...pages/Findings/components/FindingDetailsFlyout.tsx 9.72% <0.00%> (ø)
...ainers/DetectorDetailsView/DetectorDetailsView.tsx 66.66% <0.00%> (ø)
...oards-plugin/public/services/SavedObjectService.ts 14.28% <0.00%> (ø)
...ards-plugin/public/store/config/savedObjects/s3.ts 100.00% <0.00%> (ø)
.../public/store/config/savedObjects/vpc-flow-logs.ts 100.00% <0.00%> (ø)
... and 4 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@amsiglan amsiglan added backport 2.x backport 2.6 Used for marking changes that must be merged into 2.6 branch labels Feb 22, 2023
Signed-off-by: Amardeepsingh Siglani <[email protected]>
@amsiglan amsiglan merged commit 28763d6 into opensearch-project:main Feb 22, 2023
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 22, 2023
* added create dashboard feature

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* creating alias for input indices

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added callout for dashboard creation

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* disabled test temporarily

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed reference error

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 28763d6)
opensearch-trigger-bot bot pushed a commit that referenced this pull request Feb 22, 2023
* added create dashboard feature

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* creating alias for input indices

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added callout for dashboard creation

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* disabled test temporarily

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed reference error

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 28763d6)
AWSHurneyt pushed a commit that referenced this pull request Feb 22, 2023
* added create dashboard feature

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* creating alias for input indices

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added callout for dashboard creation

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* disabled test temporarily

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed reference error

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 28763d6)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
amsiglan added a commit that referenced this pull request Feb 22, 2023
* added create dashboard feature

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* creating alias for input indices

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added callout for dashboard creation

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* disabled test temporarily

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed reference error

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 28763d6)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
AWSHurneyt pushed a commit to AWSHurneyt/security-analytics-dashboards-plugin that referenced this pull request Oct 12, 2023
…roject#447)

* added create dashboard feature

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* creating alias for input indices

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* added callout for dashboard creation

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* disabled test temporarily

Signed-off-by: Amardeepsingh Siglani <[email protected]>

* fixed reference error

Signed-off-by: Amardeepsingh Siglani <[email protected]>

---------

Signed-off-by: Amardeepsingh Siglani <[email protected]>
(cherry picked from commit 28763d6)

Co-authored-by: Amardeepsingh Siglani <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport 2.x backport 2.6 Used for marking changes that must be merged into 2.6 branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants