Buffer waitForLoader before checking for icon
#857
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <[email protected]>
kavilla
requested review from
xluo-aws,
Hailong-am,
SuZhou-Joe,
ruanyl,
wanglam and
raintygao
as code owners
gaiksaya
approved these changes
Sep 14, 2023
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit e7c7e59)
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Sep 15, 2023
Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit e7c7e59)
kavilla
added a commit
that referenced
this pull request
Sep 15, 2023
Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit e7c7e59) Co-authored-by: Kawika Avilla <[email protected]>
ananzh
pushed a commit
that referenced
this pull request
Sep 18, 2023
Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit e7c7e59) Co-authored-by: Kawika Avilla <[email protected]>
leanneeliatra
pushed a commit
to leanneeliatra/opensearch-dashboards-functional-test-fork
that referenced
this pull request
Sep 29, 2023
…) (opensearch-project#859) Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit e7c7e59) Co-authored-by: Kawika Avilla <[email protected]> Signed-off-by: [email protected] <[email protected]>
ruanyl
added a commit
that referenced
this pull request
Oct 10, 2023
…ain tenant in shortlink (#736) * Test to ensure when a shortlink is copied, tenant is changed and short link is visited. The tenant from the link is visited. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * After link copy, allow tenant change Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Addressing comments, removing function to it's own file and removing unneeded code in before. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Spelling error rectified Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Linting errors resolved Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Update cypress/utils/commands.js Co-authored-by: Yulong Ruan <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Changed data-test-subj to getElementByTestId for consitency Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Switch tenant updated to use interceps and should() for improved test performance Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * switch tenant changed to use intercepts and should() for increaced test performance. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Adding commen to explain how the addtion of the should() helps Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Global declaration of the tenant removed. The clearing of session storage is not needed actually, cy.visit() does this for us Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Additition of 'createDashboard' method to allow programatic dashboard creation. Also improvements to the test. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * When testing we are looking for the private tenant. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * check changed to allow for both 'private' and __user__ Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * linting errors resolved Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * merging in changes on remote Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Adding back --headless parameter. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * undoing package-lock changes. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Use library from release tag instead of git reference (#706) The module installed from the OSD test library seems to update or not based on caching issues. Related proposal: opensearch-project/opensearch-dashboards-test-library#36 Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: [email protected] <[email protected]> * update testSplitTables test (#731) Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: [email protected] <[email protected]> * [Vis Augmenter / Feature Anywhere] Add tests in core OSD and AD plugin (#739) * [Vis Augmenter / Feature Anywhere] Add test suite for vanilla OSD + helper fns for plugins (#725) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Remove unnecessary test case Signed-off-by: Tyler Ohlsen <[email protected]> * Optimize getters Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> * [Feature Anywhere / Vis Augmenter] Add test flows for integration with AD plugin (#727) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Add AD vis augmenter tests Signed-off-by: Tyler Ohlsen <[email protected]> * More refactoring Signed-off-by: Tyler Ohlsen <[email protected]> * More tests Signed-off-by: Tyler Ohlsen <[email protected]> * Add test for AD cleanup scenario Signed-off-by: Tyler Ohlsen <[email protected]> * Set up saved obj test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Add reminder TODO Signed-off-by: Tyler Ohlsen <[email protected]> * Add tests regarding saved obj visibility Signed-off-by: Tyler Ohlsen <[email protected]> * Add view events tests Signed-off-by: Tyler Ohlsen <[email protected]> * cleanup Signed-off-by: Tyler Ohlsen <[email protected]> * remove import Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: [email protected] <[email protected]> * Revert "[Vis Augmenter / Feature Anywhere] Add tests in core OSD and AD plugin (#739)" (#748) This reverts commit 07a67d7. Signed-off-by: manasvinibs <[email protected]> Signed-off-by: [email protected] <[email protected]> * Test sample data with multiple data source enabled on local cluster (#756) Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: [email protected] <[email protected]> * [Vis Augmenter] Add tests in OSD & AD plugin (#752) * [Vis Augmenter / Feature Anywhere] Add test suite for vanilla OSD + helper fns for plugins (#725) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Remove unnecessary test case Signed-off-by: Tyler Ohlsen <[email protected]> * Optimize getters Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> * [Feature Anywhere / Vis Augmenter] Add test flows for integration with AD plugin (#727) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Add AD vis augmenter tests Signed-off-by: Tyler Ohlsen <[email protected]> * More refactoring Signed-off-by: Tyler Ohlsen <[email protected]> * More tests Signed-off-by: Tyler Ohlsen <[email protected]> * Add test for AD cleanup scenario Signed-off-by: Tyler Ohlsen <[email protected]> * Set up saved obj test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Add reminder TODO Signed-off-by: Tyler Ohlsen <[email protected]> * Add tests regarding saved obj visibility Signed-off-by: Tyler Ohlsen <[email protected]> * Add view events tests Signed-off-by: Tyler Ohlsen <[email protected]> * cleanup Signed-off-by: Tyler Ohlsen <[email protected]> * remove import Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> * Fix NPE Signed-off-by: Tyler Ohlsen <[email protected]> * Fix bug of non-empty dashboard; remove unnecessary test Signed-off-by: Tyler Ohlsen <[email protected]> * Simplify dashboard creation Signed-off-by: Tyler Ohlsen <[email protected]> * Update undefined check Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: [email protected] <[email protected]> * fix: CVE of tough-cookie and word-wrap (#763) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: [email protected] <[email protected]> * feat: use "overrides" to install desired version of tough-cookie and word-wrap. (#772) * feat: use npm v8 to install and initialize package-lock Signed-off-by: SuZhou-Joe <[email protected]> * feat: add Node version requirement in DEVELOPER_GUIDE Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: [email protected] <[email protected]> * Improve date selection across versions of OUI (#778) Signed-off-by: Miki <[email protected]> Signed-off-by: [email protected] <[email protected]> * feat: sync cypress test from notifications-dashboards (#776) (#784) * feat: sync cypress test from notifications-dashboards Signed-off-by: SuZhou-Joe <[email protected]> * feat: rename commands Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: add larger wait time Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: add refresh before delete all notifications configs Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 81f70c3) Signed-off-by: [email protected] <[email protected]> * [Table Visualizations] Tests cleanup (#785) Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: [email protected] <[email protected]> * Bump dependency on opensearch-dashboards-test-library (#790) Signed-off-by: Miki <[email protected]> Signed-off-by: [email protected] <[email protected]> * [Table Visualizations] Test Update (#787) * fix-test * simplify selector --------- Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: [email protected] <[email protected]> * fix discover (#803) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: [email protected] <[email protected]> * Change to toast message in Reports (#578) * Change to toast message in Reports download spec Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Update test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Fix lint Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> --------- Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: [email protected] <[email protected]> * fix discover (#807) Signed-off-by: Qingyang(Abby) Hu <[email protected]> Signed-off-by: [email protected] <[email protected]> * feat: add test cases for remote models (#813) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: [email protected] <[email protected]> * fix workbench download text and csv schema (#814) (#817) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 46c0882) Co-authored-by: Joshua Li <[email protected]> Signed-off-by: [email protected] <[email protected]> * update trace analytics cypress tests according to observability changes (#775) * update ftr Signed-off-by: Derek Ho <[email protected]> * revert file Signed-off-by: Derek Ho <[email protected]> * update with trace analytics accordian changes Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: [email protected] <[email protected]> * Bump semver from 7.3.7 to 7.5.4 (#822) Bumps [semver](https://github.com/npm/node-semver) from 7.3.7 to 7.5.4. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.7...v7.5.4) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: [email protected] <[email protected]> * [Dashboard] Retry visbuilder dashboard test (#823) Seeing it pass in video replays but occassionally doesn't pass. However, it doesn't pass with security enabled so I'd imagine it could be related to the refreshing of the session. Issue: opensearch-project/OpenSearch-Dashboards#4947 Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: [email protected] <[email protected]> * Add new tests for alerting dashboards (#832) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: [email protected] <[email protected]> * Update source element in import_vector_map_tab.spec.js (#844) * Update source element in import_vector_map_tab.spec.js Signed-off-by: Junqiu Lei <[email protected]> * Update source element in import_vector_map_tab.spec.js Signed-off-by: Junqiu Lei <[email protected]> --------- Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: [email protected] <[email protected]> * Use index pattern id to find page in import_vector_map_tab.spec.js (#847) Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: [email protected] <[email protected]> * Buffer `waitForLoader` before checking for icon (#857) (#859) Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit e7c7e59) Co-authored-by: Kawika Avilla <[email protected]> Signed-off-by: [email protected] <[email protected]> * Overwrite removed and moved to after in unit test Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Update dashboard.spec.js Signed-off-by: leanneeliatra <[email protected]> * Update dashboard_sample_data_spec.js remove unneeded change Signed-off-by: leanneeliatra <[email protected]> --------- Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: manasvinibs <[email protected]> Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Qingyang(Abby) Hu <[email protected]> Signed-off-by: Lin Wang <[email protected]> Signed-off-by: Derek Ho <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Junqiu Lei <[email protected]> Co-authored-by: Yulong Ruan <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Sirazh Gabdullin <[email protected]> Co-authored-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Kristen Tian <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Lin Wang <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ashish Agrawal <[email protected]> Co-authored-by: Junqiu Lei <[email protected]>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Oct 10, 2023
…ain tenant in shortlink (#736) * Test to ensure when a shortlink is copied, tenant is changed and short link is visited. The tenant from the link is visited. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * After link copy, allow tenant change Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Addressing comments, removing function to it's own file and removing unneeded code in before. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Spelling error rectified Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Linting errors resolved Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Update cypress/utils/commands.js Co-authored-by: Yulong Ruan <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Changed data-test-subj to getElementByTestId for consitency Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Switch tenant updated to use interceps and should() for improved test performance Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * switch tenant changed to use intercepts and should() for increaced test performance. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Adding commen to explain how the addtion of the should() helps Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Global declaration of the tenant removed. The clearing of session storage is not needed actually, cy.visit() does this for us Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Additition of 'createDashboard' method to allow programatic dashboard creation. Also improvements to the test. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * When testing we are looking for the private tenant. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * check changed to allow for both 'private' and __user__ Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * linting errors resolved Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * merging in changes on remote Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Adding back --headless parameter. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * undoing package-lock changes. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Use library from release tag instead of git reference (#706) The module installed from the OSD test library seems to update or not based on caching issues. Related proposal: opensearch-project/opensearch-dashboards-test-library#36 Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: [email protected] <[email protected]> * update testSplitTables test (#731) Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: [email protected] <[email protected]> * [Vis Augmenter / Feature Anywhere] Add tests in core OSD and AD plugin (#739) * [Vis Augmenter / Feature Anywhere] Add test suite for vanilla OSD + helper fns for plugins (#725) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Remove unnecessary test case Signed-off-by: Tyler Ohlsen <[email protected]> * Optimize getters Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> * [Feature Anywhere / Vis Augmenter] Add test flows for integration with AD plugin (#727) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Add AD vis augmenter tests Signed-off-by: Tyler Ohlsen <[email protected]> * More refactoring Signed-off-by: Tyler Ohlsen <[email protected]> * More tests Signed-off-by: Tyler Ohlsen <[email protected]> * Add test for AD cleanup scenario Signed-off-by: Tyler Ohlsen <[email protected]> * Set up saved obj test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Add reminder TODO Signed-off-by: Tyler Ohlsen <[email protected]> * Add tests regarding saved obj visibility Signed-off-by: Tyler Ohlsen <[email protected]> * Add view events tests Signed-off-by: Tyler Ohlsen <[email protected]> * cleanup Signed-off-by: Tyler Ohlsen <[email protected]> * remove import Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: [email protected] <[email protected]> * Revert "[Vis Augmenter / Feature Anywhere] Add tests in core OSD and AD plugin (#739)" (#748) This reverts commit 07a67d7. Signed-off-by: manasvinibs <[email protected]> Signed-off-by: [email protected] <[email protected]> * Test sample data with multiple data source enabled on local cluster (#756) Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: [email protected] <[email protected]> * [Vis Augmenter] Add tests in OSD & AD plugin (#752) * [Vis Augmenter / Feature Anywhere] Add test suite for vanilla OSD + helper fns for plugins (#725) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Remove unnecessary test case Signed-off-by: Tyler Ohlsen <[email protected]> * Optimize getters Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> * [Feature Anywhere / Vis Augmenter] Add test flows for integration with AD plugin (#727) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Add AD vis augmenter tests Signed-off-by: Tyler Ohlsen <[email protected]> * More refactoring Signed-off-by: Tyler Ohlsen <[email protected]> * More tests Signed-off-by: Tyler Ohlsen <[email protected]> * Add test for AD cleanup scenario Signed-off-by: Tyler Ohlsen <[email protected]> * Set up saved obj test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Add reminder TODO Signed-off-by: Tyler Ohlsen <[email protected]> * Add tests regarding saved obj visibility Signed-off-by: Tyler Ohlsen <[email protected]> * Add view events tests Signed-off-by: Tyler Ohlsen <[email protected]> * cleanup Signed-off-by: Tyler Ohlsen <[email protected]> * remove import Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> * Fix NPE Signed-off-by: Tyler Ohlsen <[email protected]> * Fix bug of non-empty dashboard; remove unnecessary test Signed-off-by: Tyler Ohlsen <[email protected]> * Simplify dashboard creation Signed-off-by: Tyler Ohlsen <[email protected]> * Update undefined check Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: [email protected] <[email protected]> * fix: CVE of tough-cookie and word-wrap (#763) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: [email protected] <[email protected]> * feat: use "overrides" to install desired version of tough-cookie and word-wrap. (#772) * feat: use npm v8 to install and initialize package-lock Signed-off-by: SuZhou-Joe <[email protected]> * feat: add Node version requirement in DEVELOPER_GUIDE Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: [email protected] <[email protected]> * Improve date selection across versions of OUI (#778) Signed-off-by: Miki <[email protected]> Signed-off-by: [email protected] <[email protected]> * feat: sync cypress test from notifications-dashboards (#776) (#784) * feat: sync cypress test from notifications-dashboards Signed-off-by: SuZhou-Joe <[email protected]> * feat: rename commands Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: add larger wait time Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: add refresh before delete all notifications configs Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 81f70c3) Signed-off-by: [email protected] <[email protected]> * [Table Visualizations] Tests cleanup (#785) Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: [email protected] <[email protected]> * Bump dependency on opensearch-dashboards-test-library (#790) Signed-off-by: Miki <[email protected]> Signed-off-by: [email protected] <[email protected]> * [Table Visualizations] Test Update (#787) * fix-test * simplify selector --------- Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: [email protected] <[email protected]> * fix discover (#803) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: [email protected] <[email protected]> * Change to toast message in Reports (#578) * Change to toast message in Reports download spec Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Update test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Fix lint Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> --------- Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: [email protected] <[email protected]> * fix discover (#807) Signed-off-by: Qingyang(Abby) Hu <[email protected]> Signed-off-by: [email protected] <[email protected]> * feat: add test cases for remote models (#813) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: [email protected] <[email protected]> * fix workbench download text and csv schema (#814) (#817) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 46c0882) Co-authored-by: Joshua Li <[email protected]> Signed-off-by: [email protected] <[email protected]> * update trace analytics cypress tests according to observability changes (#775) * update ftr Signed-off-by: Derek Ho <[email protected]> * revert file Signed-off-by: Derek Ho <[email protected]> * update with trace analytics accordian changes Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: [email protected] <[email protected]> * Bump semver from 7.3.7 to 7.5.4 (#822) Bumps [semver](https://github.com/npm/node-semver) from 7.3.7 to 7.5.4. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.7...v7.5.4) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: [email protected] <[email protected]> * [Dashboard] Retry visbuilder dashboard test (#823) Seeing it pass in video replays but occassionally doesn't pass. However, it doesn't pass with security enabled so I'd imagine it could be related to the refreshing of the session. Issue: opensearch-project/OpenSearch-Dashboards#4947 Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: [email protected] <[email protected]> * Add new tests for alerting dashboards (#832) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: [email protected] <[email protected]> * Update source element in import_vector_map_tab.spec.js (#844) * Update source element in import_vector_map_tab.spec.js Signed-off-by: Junqiu Lei <[email protected]> * Update source element in import_vector_map_tab.spec.js Signed-off-by: Junqiu Lei <[email protected]> --------- Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: [email protected] <[email protected]> * Use index pattern id to find page in import_vector_map_tab.spec.js (#847) Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: [email protected] <[email protected]> * Buffer `waitForLoader` before checking for icon (#857) (#859) Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit e7c7e59) Co-authored-by: Kawika Avilla <[email protected]> Signed-off-by: [email protected] <[email protected]> * Overwrite removed and moved to after in unit test Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Update dashboard.spec.js Signed-off-by: leanneeliatra <[email protected]> * Update dashboard_sample_data_spec.js remove unneeded change Signed-off-by: leanneeliatra <[email protected]> --------- Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: manasvinibs <[email protected]> Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Qingyang(Abby) Hu <[email protected]> Signed-off-by: Lin Wang <[email protected]> Signed-off-by: Derek Ho <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Junqiu Lei <[email protected]> Co-authored-by: Yulong Ruan <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Sirazh Gabdullin <[email protected]> Co-authored-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Kristen Tian <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Lin Wang <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ashish Agrawal <[email protected]> Co-authored-by: Junqiu Lei <[email protected]> (cherry picked from commit 21bf25f)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state.
This adds the ability to buffer before checking for the homeIcon.
Defaulted to 0 ms, but for
yarn cypress:run-with-securityconfigures WAIT_FOR_LOADER_BUFFER_MS to be 500 msNOTE:
The resolution for this issue: #856
Would be a less arbitrary timed solution.
Issues Resolved
opensearch-project/OpenSearch-Dashboards#5028
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.