Tenant change related integration tests - allow tenant change and retain tenant in shortlink #736

leanneeliatra · 2023-07-07T10:27:35Z

Description

This integration test covers tests for 2 scenarios:

When a shortlink is copied and later visited, the tenant information is retained in the shortlink and the shortlink is loaded with the correct link/tenant intact. Bug fix for Bugfix for 1203
After visiting a shared link, the tenant can successfully be changed & the user can continue in the UI. Bugfix for 1204

Issues Resolved

This pull request cover the cypress integration tests for the 2 issues below:

1203 - When a shortURL link was copied, the tenant information was not being retained & the user was being directed to the incorrect tenant.
1204 - When a page was shared (not using short URL link) & pasted by the user, the user could not then subsequently visit any other tenant. They were locked into the tenant that had previously been copied in the link.

Questions

How can I see if the integration tests have passed, usually these tests are run in the pipeline when committing to the security-dashboards-plugin project. In the instance we push to the test repo. Do I need to consider how the tests will run? Or this repo has it's own pipeline that will take care of checking the tests (which seems to be the case)? Thanks.

Check List

Commits are signed per the DCO using --signoff

Notes

The original PR was reviewed by @cwperks and @DarshitChanpura.
cc @peternied these are the requested integration tests for Pull Request & Pull Request
The original bugfix was merged in pull request Add the tenant into the short URL once the short URL is resolved #1462

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

cwperks

Thank you @leanneeliatra. These tests look good to me. I see a little duplication in the switchTenantTo function, could that be extracted into a common location so that its useful in both tests?

cypress/integration/plugins/security-dashboards-plugin/change_tenant_successfully.js

cypress/integration/plugins/security-dashboards-plugin/tenancy_change_on_shortlink.js

cypress/integration/plugins/security-dashboards-plugin/change_tenant_successfully.js

cypress/integration/plugins/security-dashboards-plugin/tenancy_change_on_shortlink.js

cypress/utils/commands.js

leanneeliatra · 2023-07-26T09:44:05Z

@cwperks and @ruanyl would it be possible for you to take another look whenever you have a moment please :) Thanks.
Merging can be performed automatically with 2 approving reviews.

package.json

cypress/utils/commands.js

leanneeliatra · 2023-08-22T10:10:00Z

Hi @cwperks can you tell me if there is anything I need to do for this please do you know, just to follow up. Thanks

cwperks

@leanneeliatra This looks good to merge from my POV. Could a maintainer of this repo please review?

kavilla

Overall looks pretty good only the overwrite should be address to avoid impacting other tests

cypress/integration/plugins/security-dashboards-plugin/change_tenant_successfully.js

cypress/integration/plugins/security-dashboards-plugin/switch_tenant.js

cypress/utils/commands.js

cypress/integration/plugins/security-dashboards-plugin/tenancy_change_on_shortlink.js

…t link is visited. The tenant from the link is visited. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

…unneeded code in before. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

Co-authored-by: Yulong Ruan <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: [email protected] <[email protected]>

…oject#844) * Update source element in import_vector_map_tab.spec.js Signed-off-by: Junqiu Lei <[email protected]> * Update source element in import_vector_map_tab.spec.js Signed-off-by: Junqiu Lei <[email protected]> --------- Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: [email protected] <[email protected]>

…pensearch-project#847) Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: [email protected] <[email protected]>

…) (opensearch-project#859) Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit e7c7e59) Co-authored-by: Kawika Avilla <[email protected]> Signed-off-by: [email protected] <[email protected]>

Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

leanneeliatra · 2023-09-29T15:59:02Z

Overall looks pretty good only the overwrite should be address to avoid impacting other tests

This is addressed now, thanks for spotting it. If possible it would be great to get this over the line now. Please let me know if there is anything else and I will address it ASAP.

leanneeliatra · 2023-10-04T14:23:18Z

Could a maintainer of this repo please review?

Could this please be reviewed/signed off. It has been through many review rounds and a rebase too, with 2 more reviews hopefully it can be closed.

Thank you. cc if possible please @ruanyl @kavilla @ashwin-pc @xluo-aws

ruanyl · 2023-10-07T02:09:55Z

Hi @leanneeliatra Thank you very much for your dedication on the PR! It looks the changed files includes lots of files which are not belong to this PR, could you update your branch accordingly?

Signed-off-by: leanneeliatra <[email protected]>

leanneeliatra · 2023-10-09T10:07:22Z

Hi @leanneeliatra Thank you very much for your dedication on the PR! It looks the changed files includes lots of files which are not belong to this PR, could you update your branch accordingly?

Thanks for taking a look @ruanyl, this was due to the fact that the original changes were done on branch 2.8. A rebase to main was then required, that is why there are so many other changes.

I have also resolved conflicts with main just now.

leanneeliatra · 2023-10-09T10:22:42Z

Hi @leanneeliatra Thank you very much for your dedication on the PR! It looks the changed files includes lots of files which are not belong to this PR, could you update your branch accordingly?

@ruanyl, scene as it would be much clearer and cleaner, I will add the changes to a new branch, originated from main and just add my changes. 60 + changed files is a lot.

Edit: when creating a new branch from main, there are over 300+ linting errors being flagged when I try to commit to the branch (not my changes). Therefore I will stick with the rebased branch and changes that are currently there on this PR.

Signed-off-by: leanneeliatra <[email protected]>

leanneeliatra · 2023-10-09T14:57:44Z

CI is failing on Error as below, can someone assist me on the possible remedy here please?

Path does not exist /home/runner/work/opensearch-dashboards-functional-test/opensearch-dashboards-functional-test/monetery-test/cypress/results
Error: Exit code 1 returned from process: file name '/home/runner/runners/2.309.0/bin/Runner.PluginHost', arguments 'action "GitHub.Runner.Plugins.Artifact.PublishArtifact, Runner.Plugins"'

I've been speaking to @Hailong-am. He requested I merge in the main branch, then he could review.
Thank you Hailong.
Adding here for clarity on the PR.

I've also been speaking to @ruanyl, please review at your nearest connivance thank you.

cypress/integration/common/dashboard_sample_data_spec.js

remove unneeded change Signed-off-by: leanneeliatra <[email protected]>

leanneeliatra · 2023-10-10T09:07:32Z

Could a maintainer of this repository please review this PR for me please? Thank you.

ruanyl · 2023-10-10T10:00:02Z

@kavilla I see E2E Cypress tests are failed, not only this PR, but also others. Looks like OSD server didn't start successfully(can see timeout from the log). Are you familiar with this issue? Did this happen before? I tried to clear the cache , but seems not working.

leanneeliatra · 2023-10-10T10:17:13Z

@kavilla I see E2E Cypress tests are failed, not only this PR, but also others. Looks like OSD server didn't start successfully(can see timeout from the log). Are you familiar with this issue? Did this happen before? I tried to clear the cache , but seems not working.

Ahhh thanks for checking this @ruanyl, I am in a similar predicament with another PR of mine but it's from the repository security-dashboards-plugin so probably not related. @RyanL1997 was assisting me with looking into the cypress tests for that repository. In that instance, there was an issue with Cypress overall: I think the socket failure is related to this issue: cypress-io/cypress-documentation#5483. So it is not from our end. But I can try to fix it by rolling back the chrome driver version. to share in case it could be an issue.

I am at a bit of a loss not being super informed on the whole cypress or CI pipeline in full. So if you have any ideas @kavilla that would be great. It would be brilliant to get this merged scene as it's all good to go now too, apart from the cypress test portion. Thanks very much for your assistance all.

ruanyl · 2023-10-10T13:49:32Z

@leanneeliatra Thanks for the clarification. The PR overall looks good to me, I'll merge it now. And I found this issue #902 which might be related. Will track the workflow running issue separately.

…ain tenant in shortlink (#736) * Test to ensure when a shortlink is copied, tenant is changed and short link is visited. The tenant from the link is visited. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * After link copy, allow tenant change Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Addressing comments, removing function to it's own file and removing unneeded code in before. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Spelling error rectified Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Linting errors resolved Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Update cypress/utils/commands.js Co-authored-by: Yulong Ruan <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Changed data-test-subj to getElementByTestId for consitency Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Switch tenant updated to use interceps and should() for improved test performance Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * switch tenant changed to use intercepts and should() for increaced test performance. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Adding commen to explain how the addtion of the should() helps Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Global declaration of the tenant removed. The clearing of session storage is not needed actually, cy.visit() does this for us Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Additition of 'createDashboard' method to allow programatic dashboard creation. Also improvements to the test. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * When testing we are looking for the private tenant. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * check changed to allow for both 'private' and __user__ Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * linting errors resolved Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * merging in changes on remote Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Adding back --headless parameter. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * undoing package-lock changes. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Use library from release tag instead of git reference (#706) The module installed from the OSD test library seems to update or not based on caching issues. Related proposal: opensearch-project/opensearch-dashboards-test-library#36 Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: [email protected] <[email protected]> * update testSplitTables test (#731) Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: [email protected] <[email protected]> * [Vis Augmenter / Feature Anywhere] Add tests in core OSD and AD plugin (#739) * [Vis Augmenter / Feature Anywhere] Add test suite for vanilla OSD + helper fns for plugins (#725) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Remove unnecessary test case Signed-off-by: Tyler Ohlsen <[email protected]> * Optimize getters Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> * [Feature Anywhere / Vis Augmenter] Add test flows for integration with AD plugin (#727) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Add AD vis augmenter tests Signed-off-by: Tyler Ohlsen <[email protected]> * More refactoring Signed-off-by: Tyler Ohlsen <[email protected]> * More tests Signed-off-by: Tyler Ohlsen <[email protected]> * Add test for AD cleanup scenario Signed-off-by: Tyler Ohlsen <[email protected]> * Set up saved obj test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Add reminder TODO Signed-off-by: Tyler Ohlsen <[email protected]> * Add tests regarding saved obj visibility Signed-off-by: Tyler Ohlsen <[email protected]> * Add view events tests Signed-off-by: Tyler Ohlsen <[email protected]> * cleanup Signed-off-by: Tyler Ohlsen <[email protected]> * remove import Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: [email protected] <[email protected]> * Revert "[Vis Augmenter / Feature Anywhere] Add tests in core OSD and AD plugin (#739)" (#748) This reverts commit 07a67d7. Signed-off-by: manasvinibs <[email protected]> Signed-off-by: [email protected] <[email protected]> * Test sample data with multiple data source enabled on local cluster (#756) Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: [email protected] <[email protected]> * [Vis Augmenter] Add tests in OSD & AD plugin (#752) * [Vis Augmenter / Feature Anywhere] Add test suite for vanilla OSD + helper fns for plugins (#725) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Remove unnecessary test case Signed-off-by: Tyler Ohlsen <[email protected]> * Optimize getters Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> * [Feature Anywhere / Vis Augmenter] Add test flows for integration with AD plugin (#727) * feature anywhere initial tests Signed-off-by: Jovan Cvetkovic <[email protected]> * Add test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Add AD vis augmenter tests Signed-off-by: Tyler Ohlsen <[email protected]> * More refactoring Signed-off-by: Tyler Ohlsen <[email protected]> * More tests Signed-off-by: Tyler Ohlsen <[email protected]> * Add test for AD cleanup scenario Signed-off-by: Tyler Ohlsen <[email protected]> * Set up saved obj test suite Signed-off-by: Tyler Ohlsen <[email protected]> * Add reminder TODO Signed-off-by: Tyler Ohlsen <[email protected]> * Add tests regarding saved obj visibility Signed-off-by: Tyler Ohlsen <[email protected]> * Add view events tests Signed-off-by: Tyler Ohlsen <[email protected]> * cleanup Signed-off-by: Tyler Ohlsen <[email protected]> * remove import Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> * Fix NPE Signed-off-by: Tyler Ohlsen <[email protected]> * Fix bug of non-empty dashboard; remove unnecessary test Signed-off-by: Tyler Ohlsen <[email protected]> * Simplify dashboard creation Signed-off-by: Tyler Ohlsen <[email protected]> * Update undefined check Signed-off-by: Tyler Ohlsen <[email protected]> --------- Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Signed-off-by: [email protected] <[email protected]> * fix: CVE of tough-cookie and word-wrap (#763) Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: [email protected] <[email protected]> * feat: use "overrides" to install desired version of tough-cookie and word-wrap. (#772) * feat: use npm v8 to install and initialize package-lock Signed-off-by: SuZhou-Joe <[email protected]> * feat: add Node version requirement in DEVELOPER_GUIDE Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: [email protected] <[email protected]> * Improve date selection across versions of OUI (#778) Signed-off-by: Miki <[email protected]> Signed-off-by: [email protected] <[email protected]> * feat: sync cypress test from notifications-dashboards (#776) (#784) * feat: sync cypress test from notifications-dashboards Signed-off-by: SuZhou-Joe <[email protected]> * feat: rename commands Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: add larger wait time Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: update Signed-off-by: SuZhou-Joe <[email protected]> * feat: add refresh before delete all notifications configs Signed-off-by: SuZhou-Joe <[email protected]> --------- Signed-off-by: SuZhou-Joe <[email protected]> (cherry picked from commit 81f70c3) Signed-off-by: [email protected] <[email protected]> * [Table Visualizations] Tests cleanup (#785) Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: [email protected] <[email protected]> * Bump dependency on opensearch-dashboards-test-library (#790) Signed-off-by: Miki <[email protected]> Signed-off-by: [email protected] <[email protected]> * [Table Visualizations] Test Update (#787) * fix-test * simplify selector --------- Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: [email protected] <[email protected]> * fix discover (#803) Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: [email protected] <[email protected]> * Change to toast message in Reports (#578) * Change to toast message in Reports download spec Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Update test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Fix lint Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> --------- Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: [email protected] <[email protected]> * fix discover (#807) Signed-off-by: Qingyang(Abby) Hu <[email protected]> Signed-off-by: [email protected] <[email protected]> * feat: add test cases for remote models (#813) Signed-off-by: Lin Wang <[email protected]> Signed-off-by: [email protected] <[email protected]> * fix workbench download text and csv schema (#814) (#817) Signed-off-by: Joshua Li <[email protected]> (cherry picked from commit 46c0882) Co-authored-by: Joshua Li <[email protected]> Signed-off-by: [email protected] <[email protected]> * update trace analytics cypress tests according to observability changes (#775) * update ftr Signed-off-by: Derek Ho <[email protected]> * revert file Signed-off-by: Derek Ho <[email protected]> * update with trace analytics accordian changes Signed-off-by: Derek Ho <[email protected]> --------- Signed-off-by: Derek Ho <[email protected]> Signed-off-by: [email protected] <[email protected]> * Bump semver from 7.3.7 to 7.5.4 (#822) Bumps [semver](https://github.com/npm/node-semver) from 7.3.7 to 7.5.4. - [Release notes](https://github.com/npm/node-semver/releases) - [Changelog](https://github.com/npm/node-semver/blob/main/CHANGELOG.md) - [Commits](npm/node-semver@v7.3.7...v7.5.4) --- updated-dependencies: - dependency-name: semver dependency-type: indirect ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Signed-off-by: [email protected] <[email protected]> * [Dashboard] Retry visbuilder dashboard test (#823) Seeing it pass in video replays but occassionally doesn't pass. However, it doesn't pass with security enabled so I'd imagine it could be related to the refreshing of the session. Issue: opensearch-project/OpenSearch-Dashboards#4947 Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: [email protected] <[email protected]> * Add new tests for alerting dashboards (#832) Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: [email protected] <[email protected]> * Update source element in import_vector_map_tab.spec.js (#844) * Update source element in import_vector_map_tab.spec.js Signed-off-by: Junqiu Lei <[email protected]> * Update source element in import_vector_map_tab.spec.js Signed-off-by: Junqiu Lei <[email protected]> --------- Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: [email protected] <[email protected]> * Use index pattern id to find page in import_vector_map_tab.spec.js (#847) Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: [email protected] <[email protected]> * Buffer `waitForLoader` before checking for icon (#857) (#859) Some async calls occur after navigating and sometimes navigating too quickly prevents the calls from having correct data and therefore the homeIcon is in a bad state. This adds the ability to buffer before checking for the homeIcon. Defaulted to 0 ms, but for `yarn cypress:run-with-security` configures WAIT_FOR_LOADER_BUFFER_MS to be 500 ms Issue resolved: opensearch-project/OpenSearch-Dashboards#5028 Signed-off-by: Kawika Avilla <[email protected]> (cherry picked from commit e7c7e59) Co-authored-by: Kawika Avilla <[email protected]> Signed-off-by: [email protected] <[email protected]> * Overwrite removed and moved to after in unit test Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> * Update dashboard.spec.js Signed-off-by: leanneeliatra <[email protected]> * Update dashboard_sample_data_spec.js remove unneeded change Signed-off-by: leanneeliatra <[email protected]> --------- Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: Kawika Avilla <[email protected]> Signed-off-by: Sirazh Gabdullin <[email protected]> Signed-off-by: Jovan Cvetkovic <[email protected]> Signed-off-by: Tyler Ohlsen <[email protected]> Signed-off-by: manasvinibs <[email protected]> Signed-off-by: Kristen Tian <[email protected]> Signed-off-by: SuZhou-Joe <[email protected]> Signed-off-by: Miki <[email protected]> Signed-off-by: abbyhu2000 <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Qingyang(Abby) Hu <[email protected]> Signed-off-by: Lin Wang <[email protected]> Signed-off-by: Derek Ho <[email protected]> Signed-off-by: dependabot[bot] <[email protected]> Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: Junqiu Lei <[email protected]> Co-authored-by: Yulong Ruan <[email protected]> Co-authored-by: Kawika Avilla <[email protected]> Co-authored-by: Sirazh Gabdullin <[email protected]> Co-authored-by: Tyler Ohlsen <[email protected]> Co-authored-by: Jovan Cvetkovic <[email protected]> Co-authored-by: Manasvini B Suryanarayana <[email protected]> Co-authored-by: Kristen Tian <[email protected]> Co-authored-by: SuZhou-Joe <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Miki <[email protected]> Co-authored-by: Qingyang(Abby) Hu <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Lin Wang <[email protected]> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: Joshua Li <[email protected]> Co-authored-by: Derek Ho <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Ashish Agrawal <[email protected]> Co-authored-by: Junqiu Lei <[email protected]> (cherry picked from commit 21bf25f)

leanneeliatra · 2023-10-10T14:17:32Z

@leanneeliatra Thanks for the clarification. The PR overall looks good to me, I'll merge it now. And I found this issue #902 which might be related. Will track the workflow running issue separately.

That's fabulous @ruanyl thanks very much for your assistance on this. I really appreciate it.

ruanyl · 2023-10-10T14:23:21Z

@ananzh I see this PR is tagged to v2.10.0, is that correct?

leanneeliatra · 2023-10-11T09:45:12Z

@ananzh I see this PR is tagged to v2.10.0, is that correct?

It has been now updated to have all the changes from main so it is now updated.

…ain tenant in shortlink (opensearch-project#736) * Test to ensure when a shortlink is copied, tenant is changed and short link is visited. The tenant from the link is visited. Signed-off-by: leanneeliatra

leanneeliatra requested review from xluo-aws, Hailong-am, SuZhou-Joe, ruanyl, wanglam and raintygao as code owners July 7, 2023 10:27

leanneeliatra force-pushed the shortlink-tenancy-retained-test branch from 045f21c to 14b23e3 Compare July 7, 2023 10:53

cwperks reviewed Jul 7, 2023

View reviewed changes

ananzh added v2.10.0 backport 2.x labels Jul 10, 2023

leanneeliatra changed the title ~~Shortlink tenant retained when visiting shortlink.~~ Tenant change related integration tests - allow tenant change and retain tenant in shortlink Jul 12, 2023

cwperks reviewed Jul 13, 2023

View reviewed changes

cypress/integration/plugins/security-dashboards-plugin/tenancy_change_on_shortlink.js Outdated Show resolved Hide resolved

ruanyl reviewed Jul 14, 2023

View reviewed changes

cypress/integration/plugins/security-dashboards-plugin/change_tenant_successfully.js Show resolved Hide resolved

ruanyl reviewed Jul 14, 2023

View reviewed changes

leanneeliatra force-pushed the shortlink-tenancy-retained-test branch from 228ea82 to 0b29197 Compare July 24, 2023 14:48

cwperks reviewed Jul 26, 2023

View reviewed changes

package.json Outdated Show resolved Hide resolved

cwperks reviewed Jul 26, 2023

View reviewed changes

cypress/utils/commands.js Outdated Show resolved Hide resolved

DarshitChanpura approved these changes Jul 27, 2023

View reviewed changes

cwperks approved these changes Aug 22, 2023

View reviewed changes

kavilla reviewed Aug 24, 2023

View reviewed changes

cypress/integration/plugins/security-dashboards-plugin/change_tenant_successfully.js Show resolved Hide resolved

cypress/integration/plugins/security-dashboards-plugin/switch_tenant.js Show resolved Hide resolved

ashwin-pc reviewed Aug 26, 2023

View reviewed changes

cypress/utils/commands.js Outdated Show resolved Hide resolved

cypress/integration/plugins/security-dashboards-plugin/tenancy_change_on_shortlink.js Show resolved Hide resolved

leanneeliatra and others added 7 commits September 29, 2023 16:58

Test to ensure when a shortlink is copied, tenant is changed and shor…

46dd03a

…t link is visited. The tenant from the link is visited. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

After link copy, allow tenant change

f68f455

Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

Addressing comments, removing function to it's own file and removing …

631a03f

…unneeded code in before. Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

Spelling error rectified

836089a

Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

Linting errors resolved

5b0df4a

Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

Update cypress/utils/commands.js

d5f3520

Co-authored-by: Yulong Ruan <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

Changed data-test-subj to getElementByTestId for consitency

dee3b57

Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

lezzago and others added 5 commits September 29, 2023 16:58

Add new tests for alerting dashboards (opensearch-project#832)

d6201f9

Signed-off-by: Ashish Agrawal <[email protected]> Signed-off-by: [email protected] <[email protected]>

Use index pattern id to find page in import_vector_map_tab.spec.js (o…

3a3063a

…pensearch-project#847) Signed-off-by: Junqiu Lei <[email protected]> Signed-off-by: [email protected] <[email protected]>

Overwrite removed and moved to after in unit test

df07263

Signed-off-by: leanneeliatra <[email protected]> Signed-off-by: [email protected] <[email protected]>

leanneeliatra force-pushed the shortlink-tenancy-retained-test branch from 3017d60 to df07263 Compare September 29, 2023 15:58

Merge branch 'main' into shortlink-tenancy-retained-test

758300b

Signed-off-by: leanneeliatra <[email protected]>

Update dashboard.spec.js

53b38e3

Signed-off-by: leanneeliatra <[email protected]>

Hailong-am approved these changes Oct 9, 2023

View reviewed changes

ruanyl reviewed Oct 10, 2023

View reviewed changes

cypress/integration/common/dashboard_sample_data_spec.js Outdated Show resolved Hide resolved

Update dashboard_sample_data_spec.js

2731dbf

remove unneeded change Signed-off-by: leanneeliatra <[email protected]>

raintygao approved these changes Oct 10, 2023

View reviewed changes

ruanyl approved these changes Oct 10, 2023

View reviewed changes

ruanyl merged commit 21bf25f into opensearch-project:main Oct 10, 2023
36 of 37 checks passed

opensearch-trigger-bot bot mentioned this pull request Oct 10, 2023

[Backport 2.x] Tenant change related integration tests - allow tenant change and retain tenant in shortlink #915

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Tenant change related integration tests - allow tenant change and retain tenant in shortlink #736

Tenant change related integration tests - allow tenant change and retain tenant in shortlink #736

leanneeliatra commented Jul 7, 2023 •

edited

Loading

cwperks left a comment

leanneeliatra commented Jul 26, 2023 •

edited

Loading

leanneeliatra commented Aug 22, 2023

cwperks left a comment

kavilla left a comment

leanneeliatra commented Sep 29, 2023 •

edited

Loading

leanneeliatra commented Oct 4, 2023 •

edited

Loading

ruanyl commented Oct 7, 2023

leanneeliatra commented Oct 9, 2023

leanneeliatra commented Oct 9, 2023 •

edited

Loading

leanneeliatra commented Oct 9, 2023 •

edited

Loading

leanneeliatra commented Oct 10, 2023

ruanyl commented Oct 10, 2023

leanneeliatra commented Oct 10, 2023 •

edited

Loading

ruanyl commented Oct 10, 2023 •

edited

Loading

leanneeliatra commented Oct 10, 2023

ruanyl commented Oct 10, 2023

leanneeliatra commented Oct 11, 2023

Tenant change related integration tests - allow tenant change and retain tenant in shortlink #736

Tenant change related integration tests - allow tenant change and retain tenant in shortlink #736

Conversation

leanneeliatra commented Jul 7, 2023 • edited Loading

Description

Issues Resolved

Questions

Check List

Notes

cwperks left a comment

Choose a reason for hiding this comment

leanneeliatra commented Jul 26, 2023 • edited Loading

leanneeliatra commented Aug 22, 2023

cwperks left a comment

Choose a reason for hiding this comment

kavilla left a comment

Choose a reason for hiding this comment

leanneeliatra commented Sep 29, 2023 • edited Loading

leanneeliatra commented Oct 4, 2023 • edited Loading

ruanyl commented Oct 7, 2023

leanneeliatra commented Oct 9, 2023

leanneeliatra commented Oct 9, 2023 • edited Loading

leanneeliatra commented Oct 9, 2023 • edited Loading

leanneeliatra commented Oct 10, 2023

ruanyl commented Oct 10, 2023

leanneeliatra commented Oct 10, 2023 • edited Loading

ruanyl commented Oct 10, 2023 • edited Loading

leanneeliatra commented Oct 10, 2023

ruanyl commented Oct 10, 2023

leanneeliatra commented Oct 11, 2023

leanneeliatra commented Jul 7, 2023 •

edited

Loading

leanneeliatra commented Jul 26, 2023 •

edited

Loading

leanneeliatra commented Sep 29, 2023 •

edited

Loading

leanneeliatra commented Oct 4, 2023 •

edited

Loading

leanneeliatra commented Oct 9, 2023 •

edited

Loading

leanneeliatra commented Oct 9, 2023 •

edited

Loading

leanneeliatra commented Oct 10, 2023 •

edited

Loading

ruanyl commented Oct 10, 2023 •

edited

Loading