[Vis Augmenter] Add tests in OSD & AD plugin

[ohltyler]

Description

Adds tests for the Vis Augmenter / Feature Anywhere feature. Includes new tests in core OSD + tests in AD plugin to test the integration of the plugin with the feature. Includes many helper fns in core OSD for plugins to use too bootstrap a test cluster with appropriate data to test plugin integration (e.g., create a dashboard with a feature-eligible visualization and sufficient sample data).

NOTE: there may be follow-ups to refactor when these new test suites are run, and some existing script cmds may need to be updated.

Issues Resolved

Closes #426
Closes #428
Closes #431
Closes #432
Closes #749

Check List

• Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

[ohltyler]

@kavilla fixed NPE in latest commit. Regarding saved obj imports, I can explore doing that for some of the functionality. But a lot of the UI-based setup is through functions that take different parameters to be able to create different visualizations specific for a certain test suite or certain plugin testing the integration. I guess this could also be done with pre-created saved obj fixtures, but my concern is it could lead to a large number of json files for that.

I can write this up in a separate issue. For 2.9, I would prefer to get the current implementation merged to unblock. Thanks for taking the time to help debug as well :)

Update: separate issue here: #753

[kavilla]

@ohltyler I understand but with the NPE check I was not able get to actual test cases locally because it fails to succeed the setup steps. Im running the tests with cypress open from my Macbook and pointing to my EC2 instance.

Im willing to merge if not flakey. Do you have a github actions link with the cypress test passing consistently that we can feel confident in adding this? Otherwise i can see the situation being this will lead to false test failures which can mask actual test failures.

[ohltyler]

@kavilla i've fixed the setup failures caused by a non-empty cluster putting pages into different state. Besides that, I've always been able to pass successfully on my local 3.0 cluster. Now it passes with existing data / saved objs on my local as well. Please try with the latest if you are still seeing issues

I'm still trying to figure out how to easily run on a non-3.0 branch since none of the tests are running since it fails to bring up 3.0 clusters to begin with...

[kavilla]

@kavilla i've fixed the setup failures caused by a non-empty cluster putting pages into different state. Besides that, I've always been able to pass successfully on my local 3.0 cluster. Now it passes with existing data / saved objs on my local as well. Please try with the latest if you are still seeing issues

I'm still trying to figure out how to easily run on a non-3.0 branch since none of the tests are running since it fails to bring up 3.0 clusters to begin with...

@ohltyler I have created a draft PR and recreated the feature anywhere branch (since it was already merge). So any changes on the cypress feature/feature-anywhere branch should be pulled in here:
opensearch-project/OpenSearch-Dashboards#4561
^
So just want to verify this one is consistent.

[ohltyler]

@kavilla I've created one directly to 2.9 but it's failing to bring up a cluster due to observability dashboards failure. #757

[ohltyler]

For merging to main, I'm seeing the following 2 issues:

1. When running the AD test workflows, all tests are failing due to elements not found. And when looking at the workflow logs, looks like AD Dashboards plugin is not being added into the cluster, hence all tests fail
2. When running in AD plugin, it is failing due to the following issue. It isn't seen on 2.x/2.9/etc., but I'm able to reproduce locally on a 3.0 build:

http://localhost:5601/api/console/proxy

We attempted to make an http request to this URL but the request failed without a response.

We received this error at the network level:

  > Error: connect ECONNREFUSED 127.0.0.1:5601

Workflow ref: here

[kavilla]

@ohltyler test seem to be passing well on the cypress test run for OpenSearch Dashboards. But can you check out the linter issues?

[ohltyler]

@ohltyler test seem to be passing well on the cypress test run for OpenSearch Dashboards. But can you check out the linter issues?

I think this can be ignored. All of the tests across the entire repo have similar issues and I always have to run with --no-verify since there are 300+ violations. I think there is some integration with babel and/or updates to .eslintrc.json file to fix.

The primary issue I'm seeing is related to imports, which resolve in an IDE and do follow correct paths but there is issues with named exports and certain configurations that need to change.

[kavilla]

Thanks for fixing! Yeah we should either update our eslint or add a parser to let us use optional chaining.

[ohltyler]

@SuZhou-Joe Can you help take a look here, since you helped with the original merge? The blocking issue that caused the revert has been resolved.