Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge feature/metrics branch to 2.4 #1234

Merged
merged 11 commits into from
Nov 3, 2022

Conversation

ps48
Copy link
Member

@ps48 ps48 commented Nov 3, 2022

Description

Cherry picked commits from feature/metrics to 2.4

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

sejli and others added 11 commits November 2, 2022 19:03
* Added Metrics Home Page and date picker

Signed-off-by: Sean Li <[email protected]>

* Minor changes

Signed-off-by: Sean Li <[email protected]>

* Adding empty view and sidebar

Signed-off-by: Sean Li <[email protected]>

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
* Added Metrics Home Page and date picker

Signed-off-by: Sean Li <[email protected]>

* Minor changes

Signed-off-by: Sean Li <[email protected]>

* Adding empty view and sidebar

Signed-off-by: Sean Li <[email protected]>

* Adding metrics reducer to redux store

Signed-off-by: Sean Li <[email protected]>

* Adding functioning sidebar to home page

Signed-off-by: Sean Li <[email protected]>

* Removing unnecessary function

Signed-off-by: Sean Li <[email protected]>

Signed-off-by: Sean Li <[email protected]>
* Save panel

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* remove comments

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* remove milliseconds from constants

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
…t#1211)

* Adding API connects

Signed-off-by: Sean Li <[email protected]>

* Addressing constant chagne

Signed-off-by: Sean Li <[email protected]>

Signed-off-by: Sean Li <[email protected]>
* Add schema to router in events

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* update Saved Visualization in backend to include metrics

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* add SelectedLabels class

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* Add Token class in saved visualization

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* update test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* fix frontend API data

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* update default subtype state to viz

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* disabling labels on front end

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* remove console.log comments

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* remove logger comments

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
* adding vizualization components

Signed-off-by: Shenoy Pratik <[email protected]>

* added metrics layout to redux

Signed-off-by: Shenoy Pratik <[email protected]>

* removed comments and updated constants

Signed-off-by: Shenoy Pratik <[email protected]>

* remove excess console.log

Signed-off-by: Shenoy Pratik <[email protected]>

Signed-off-by: Shenoy Pratik <[email protected]>
* Add Metrics to events home page and fix jest test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* fix save_query_table jest test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* fix backend test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
* Updating sidepanel

Signed-off-by: Sean Li <[email protected]>

* Removing mock metrics

Signed-off-by: Sean Li <[email protected]>

* Allowing horizontal scroll on metric lists

Signed-off-by: Sean Li <[email protected]>

* Minor changes

Signed-off-by: Sean Li <[email protected]>

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
@ps48 ps48 requested a review from a team as a code owner November 3, 2022 02:32
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #1234 (9751001) into 2.4 (b3a541a) will decrease coverage by 18.61%.
The diff coverage is 34.69%.

@@              Coverage Diff              @@
##                2.4    #1234       +/-   ##
=============================================
- Coverage     71.87%   53.26%   -18.62%     
- Complexity      291      292        +1     
=============================================
  Files            42      282      +240     
  Lines          2311     9690     +7379     
  Branches        240     2274     +2034     
=============================================
+ Hits           1661     5161     +3500     
- Misses          509     4358     +3849     
- Partials        141      171       +30     
Flag Coverage Δ
dashboards-observability 47.65% <42.18%> (?)
opensearch-observability 70.35% <28.91%> (-1.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ability/public/components/common/search/search.tsx 54.54% <ø> (ø)
...ces/saved_objects/event_analytics/saved_objects.ts 5.40% <0.00%> (ø)
...ensearch/observability/model/SavedVisualization.kt 60.73% <28.91%> (-33.17%) ⬇️
.../public/components/custom_panels/helpers/utils.tsx 73.38% <31.81%> (ø)
...event_analytics/explorer/save_panel/save_panel.tsx 47.61% <45.45%> (ø)
...isualization_container/visualization_container.tsx 69.56% <66.66%> (ø)
...nents/event_analytics/home/saved_objects_table.tsx 75.60% <85.71%> (ø)
...hboards-observability/common/constants/explorer.ts 100.00% <100.00%> (ø)
...onents/event_analytics/redux/slices/field_slice.ts 33.33% <0.00%> (ø)
...trace_analytics/components/traces/traces_table.tsx 69.56% <0.00%> (ø)
... and 238 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@kavithacm
Copy link
Collaborator

Awesome!! 😎

@ps48 ps48 merged commit 04852a7 into opensearch-project:2.4 Nov 3, 2022
@pjfitzgibbons pjfitzgibbons mentioned this pull request Nov 3, 2022
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants