-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Events] Save panel #1185
[Events] Save panel #1185
Conversation
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## feature/metrics opensearch-project/observability#1185 +/- ##
==================================================
Coverage 71.87% 71.87%
Complexity 291 291
==================================================
Files 42 42
Lines 2311 2311
Branches 240 240
==================================================
Hits 1661 1661
Misses 509 509
Partials 141 141
Flags with carried forward coverage won't be shown. Click here to find out more. Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
|
||
// Metrics constants | ||
export const UNITS_OF_MEASURE = [ | ||
'milliseconds (ms)', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Milliseconds is no longer necessary; can you confirm @pjfitzgibbons?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oh okay, i'll remove it
I think we should exclude it. Milliseconds doesn't make sense for a
time-span.
Thanks and Kindest Regards,
Peter Fitzgibbons
(224) 307-9689
…On Wed, Oct 26, 2022 at 1:23 PM Sean Li ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In dashboards-observability/common/constants/explorer.ts
<#1185 (comment)>
:
> @@ -269,3 +269,14 @@ export enum ConfigChartOptionsEnum {
export const CUSTOM_LABEL = 'customLabel';
export const BREAKDOWNS = 'breakdowns';
+
+// Metrics constants
+export const UNITS_OF_MEASURE = [
+ 'milliseconds (ms)',
Milliseconds is no longer necessary; can you confirm @pjfitzgibbons
<https://github.com/pjfitzgibbons>?
—
Reply to this email directly, view it on GitHub
<#1185 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAACYNXK3VFUDTJIMISWL7DWFGHNVANCNFSM6AAAAAARORAQ2Y>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
* Save panel Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * remove comments Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * remove milliseconds from constants Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
* Adding Empty View and Side Bar (#1154) * Added Metrics Home Page and date picker Signed-off-by: Sean Li <[email protected]> * Minor changes Signed-off-by: Sean Li <[email protected]> * Adding empty view and sidebar Signed-off-by: Sean Li <[email protected]> Signed-off-by: Sean Li <[email protected]> * added empty view Signed-off-by: Shenoy Pratik <[email protected]> * Adding Sidebar to Metrics Home (#1171) * Added Metrics Home Page and date picker Signed-off-by: Sean Li <[email protected]> * Minor changes Signed-off-by: Sean Li <[email protected]> * Adding empty view and sidebar Signed-off-by: Sean Li <[email protected]> * Adding metrics reducer to redux store Signed-off-by: Sean Li <[email protected]> * Adding functioning sidebar to home page Signed-off-by: Sean Li <[email protected]> * Removing unnecessary function Signed-off-by: Sean Li <[email protected]> Signed-off-by: Sean Li <[email protected]> * [Events] Save panel (#1185) * Save panel Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * remove comments Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * remove milliseconds from constants Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * [Metrics] Adding API Connection to Metrics Sidebar (#1211) * Adding API connects Signed-off-by: Sean Li <[email protected]> * Addressing constant chagne Signed-off-by: Sean Li <[email protected]> Signed-off-by: Sean Li <[email protected]> * Metrics api events (#1214) * Add schema to router in events Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * update Saved Visualization in backend to include metrics Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * add SelectedLabels class Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Add Token class in saved visualization Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * update test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * fix frontend API data Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * update default subtype state to viz Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * disabling labels on front end Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * remove console.log comments Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * remove logger comments Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Adding visualizations panel to metrics (#1222) * adding vizualization components Signed-off-by: Shenoy Pratik <[email protected]> * added metrics layout to redux Signed-off-by: Shenoy Pratik <[email protected]> * removed comments and updated constants Signed-off-by: Shenoy Pratik <[email protected]> * remove excess console.log Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> * added dummy search field, panel push button (#1227) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> * Show metrics in events homepage (#1232) * Add Metrics to events home page and fix jest test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * fix save_query_table jest test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * fix backend test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Sidepanel update (#1230) * Updating sidepanel Signed-off-by: Sean Li <[email protected]> * Removing mock metrics Signed-off-by: Sean Li <[email protected]> * Allowing horizontal scroll on metric lists Signed-off-by: Sean Li <[email protected]> * Minor changes Signed-off-by: Sean Li <[email protected]> Signed-off-by: Sean Li <[email protected]> * add metrics to nav bar Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Sean Li <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Sean Li <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]>
* Save panel Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * remove comments Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * remove milliseconds from constants Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan [email protected]
Description
Include save as metric workflow to save custom metric under event analytics
Issues Resolved
opensearch-project/dashboards-observability#139
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.