-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show metrics in events homepage #1232
Merged
ps48
merged 3 commits into
opensearch-project:feature/metrics
from
kavithacm:show-metrics-events-homepage
Nov 3, 2022
Merged
Show metrics in events homepage #1232
ps48
merged 3 commits into
opensearch-project:feature/metrics
from
kavithacm:show-metrics-events-homepage
Nov 3, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## feature/metrics opensearch-project/observability#1232 +/- ##
=====================================================
- Coverage 71.87% 70.35% -1.52%
- Complexity 291 292 +1
=====================================================
Files 42 42
Lines 2311 2392 +81
Branches 240 248 +8
=====================================================
+ Hits 1661 1683 +22
- Misses 509 568 +59
Partials 141 141
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ps48
approved these changes
Nov 3, 2022
ps48
pushed a commit
to ps48/observability
that referenced
this pull request
Nov 3, 2022
* Add Metrics to events home page and fix jest test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * fix save_query_table jest test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * fix backend test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
ps48
added a commit
that referenced
this pull request
Nov 3, 2022
* Adding Empty View and Side Bar (#1154) * Added Metrics Home Page and date picker Signed-off-by: Sean Li <[email protected]> * Minor changes Signed-off-by: Sean Li <[email protected]> * Adding empty view and sidebar Signed-off-by: Sean Li <[email protected]> Signed-off-by: Sean Li <[email protected]> * added empty view Signed-off-by: Shenoy Pratik <[email protected]> * Adding Sidebar to Metrics Home (#1171) * Added Metrics Home Page and date picker Signed-off-by: Sean Li <[email protected]> * Minor changes Signed-off-by: Sean Li <[email protected]> * Adding empty view and sidebar Signed-off-by: Sean Li <[email protected]> * Adding metrics reducer to redux store Signed-off-by: Sean Li <[email protected]> * Adding functioning sidebar to home page Signed-off-by: Sean Li <[email protected]> * Removing unnecessary function Signed-off-by: Sean Li <[email protected]> Signed-off-by: Sean Li <[email protected]> * [Events] Save panel (#1185) * Save panel Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * remove comments Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * remove milliseconds from constants Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * [Metrics] Adding API Connection to Metrics Sidebar (#1211) * Adding API connects Signed-off-by: Sean Li <[email protected]> * Addressing constant chagne Signed-off-by: Sean Li <[email protected]> Signed-off-by: Sean Li <[email protected]> * Metrics api events (#1214) * Add schema to router in events Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * update Saved Visualization in backend to include metrics Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * add SelectedLabels class Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Add Token class in saved visualization Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * update test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * fix frontend API data Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * update default subtype state to viz Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * disabling labels on front end Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * remove console.log comments Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * remove logger comments Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Adding visualizations panel to metrics (#1222) * adding vizualization components Signed-off-by: Shenoy Pratik <[email protected]> * added metrics layout to redux Signed-off-by: Shenoy Pratik <[email protected]> * removed comments and updated constants Signed-off-by: Shenoy Pratik <[email protected]> * remove excess console.log Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> * added dummy search field, panel push button (#1227) Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> * Show metrics in events homepage (#1232) * Add Metrics to events home page and fix jest test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * fix save_query_table jest test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * fix backend test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * Sidepanel update (#1230) * Updating sidepanel Signed-off-by: Sean Li <[email protected]> * Removing mock metrics Signed-off-by: Sean Li <[email protected]> * Allowing horizontal scroll on metric lists Signed-off-by: Sean Li <[email protected]> * Minor changes Signed-off-by: Sean Li <[email protected]> Signed-off-by: Sean Li <[email protected]> * add metrics to nav bar Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Sean Li <[email protected]> Signed-off-by: Shenoy Pratik <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Co-authored-by: Sean Li <[email protected]> Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]>
derek-ho
pushed a commit
that referenced
this pull request
Dec 22, 2022
* Add Metrics to events home page and fix jest test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * fix save_query_table jest test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> * fix backend test Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]> Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kavitha Conjeevaram Mohan [email protected]
Description
Note - custom panels jest test might fail
Issues Resolved
opensearch-project/dashboards-observability#40
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.