Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show metrics in events homepage #1232

Conversation

kavithacm
Copy link
Collaborator

@kavithacm kavithacm commented Nov 3, 2022

Signed-off-by: Kavitha Conjeevaram Mohan [email protected]

Description

  1. Add Metrics option to events home page table
  2. Fix jest test
  3. Add tool tip for save as metric switch in events explorer page
  4. Fix backend test

Note - custom panels jest test might fail

Issues Resolved

opensearch-project/dashboards-observability#40

Check List

  • New functionality includes testing.
    • All tests pass, including unit test, integration test and doctest
  • New functionality has been documented.
    • New functionality has javadoc added
    • New functionality has user manual doc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
@kavithacm kavithacm requested a review from a team as a code owner November 3, 2022 00:45
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
@codecov-commenter
Copy link

codecov-commenter commented Nov 3, 2022

Codecov Report

Merging #1232 (18ec780) into feature/metrics (4d99688) will decrease coverage by 1.51%.
The diff coverage is 28.91%.

@@                  Coverage Diff                  @@
##             feature/metrics    opensearch-project/observability#1232      +/-   ##
=====================================================
- Coverage              71.87%   70.35%   -1.52%     
- Complexity               291      292       +1     
=====================================================
  Files                     42       42              
  Lines                   2311     2392      +81     
  Branches                 240      248       +8     
=====================================================
+ Hits                    1661     1683      +22     
- Misses                   509      568      +59     
  Partials                 141      141              
Flag Coverage Δ
opensearch-observability 70.35% <28.91%> (-1.52%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ensearch/observability/model/SavedVisualization.kt 60.73% <28.91%> (-33.17%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ps48 ps48 merged commit 019ad23 into opensearch-project:feature/metrics Nov 3, 2022
ps48 pushed a commit to ps48/observability that referenced this pull request Nov 3, 2022
* Add Metrics to events home page and fix jest test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* fix save_query_table jest test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* fix backend test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
ps48 added a commit that referenced this pull request Nov 3, 2022
* Adding Empty View and Side Bar (#1154)

* Added Metrics Home Page and date picker

Signed-off-by: Sean Li <[email protected]>

* Minor changes

Signed-off-by: Sean Li <[email protected]>

* Adding empty view and sidebar

Signed-off-by: Sean Li <[email protected]>

Signed-off-by: Sean Li <[email protected]>

* added empty view

Signed-off-by: Shenoy Pratik <[email protected]>

* Adding Sidebar to Metrics Home (#1171)

* Added Metrics Home Page and date picker

Signed-off-by: Sean Li <[email protected]>

* Minor changes

Signed-off-by: Sean Li <[email protected]>

* Adding empty view and sidebar

Signed-off-by: Sean Li <[email protected]>

* Adding metrics reducer to redux store

Signed-off-by: Sean Li <[email protected]>

* Adding functioning sidebar to home page

Signed-off-by: Sean Li <[email protected]>

* Removing unnecessary function

Signed-off-by: Sean Li <[email protected]>

Signed-off-by: Sean Li <[email protected]>

* [Events] Save panel (#1185)

* Save panel

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* remove comments

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* remove milliseconds from constants

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* [Metrics] Adding API Connection to Metrics Sidebar (#1211)

* Adding API connects

Signed-off-by: Sean Li <[email protected]>

* Addressing constant chagne

Signed-off-by: Sean Li <[email protected]>

Signed-off-by: Sean Li <[email protected]>

* Metrics api events (#1214)

* Add schema to router in events

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* update Saved Visualization in backend to include metrics

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* add SelectedLabels class

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* Add Token class in saved visualization

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* update test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* fix frontend API data

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* update default subtype state to viz

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* disabling labels on front end

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* remove console.log comments

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* remove logger comments

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* Adding visualizations panel to metrics (#1222)

* adding vizualization components

Signed-off-by: Shenoy Pratik <[email protected]>

* added metrics layout to redux

Signed-off-by: Shenoy Pratik <[email protected]>

* removed comments and updated constants

Signed-off-by: Shenoy Pratik <[email protected]>

* remove excess console.log

Signed-off-by: Shenoy Pratik <[email protected]>

Signed-off-by: Shenoy Pratik <[email protected]>

* added dummy search field, panel push button (#1227)

Signed-off-by: Shenoy Pratik <[email protected]>

Signed-off-by: Shenoy Pratik <[email protected]>

* Show metrics in events homepage (#1232)

* Add Metrics to events home page and fix jest test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* fix save_query_table jest test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* fix backend test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* Sidepanel update (#1230)

* Updating sidepanel

Signed-off-by: Sean Li <[email protected]>

* Removing mock metrics

Signed-off-by: Sean Li <[email protected]>

* Allowing horizontal scroll on metric lists

Signed-off-by: Sean Li <[email protected]>

* Minor changes

Signed-off-by: Sean Li <[email protected]>

Signed-off-by: Sean Li <[email protected]>

* add metrics to nav bar

Signed-off-by: Shenoy Pratik <[email protected]>

Signed-off-by: Sean Li <[email protected]>
Signed-off-by: Shenoy Pratik <[email protected]>
Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Co-authored-by: Sean Li <[email protected]>
Co-authored-by: Kavitha Conjeevaram Mohan <[email protected]>
derek-ho pushed a commit that referenced this pull request Dec 22, 2022
* Add Metrics to events home page and fix jest test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* fix save_query_table jest test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

* fix backend test

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>

Signed-off-by: Kavitha Conjeevaram Mohan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants